Files
minstrel/web/scripts/check-tint-contrast.test.js
T
bvandeusenandClaude Opus 5.5 b46c080d19
release / govulncheck (push) Successful in 17s
release / web (push) Successful in 1m11s
release / go (push) Successful in 1m26s
release / integration (push) Successful in 4m18s
release / android (push) Successful in 4m44s
release / Build signed APK (releases and dev) (push) Successful in 4m53s
release / Attach APK to the Release (tag releases only) (push) Skipped
release / Build + push container image (push) Successful in 26s
release / Verify release artifacts (tag releases only) (push) Skipped
fix(web): all accent text and icons use accent-fg (#5318)
The raw accent fails AA as text on every dark surface, not only on its
own tint: 3.04:1 on the page, 2.70 on iron, 2.21 on slate, against 4.5.
accent-fg (the house formula, 45% toward parchment) measures 5.62 at
worst across both modes. The operator chose the readable colour over the
signature teal for text, on 2026-10-08.

- 36 sites swap. They are 35 Tailwind uses: links, "Now playing", the
  ingest progress line, active shuffle/repeat, the liked heart, the app
  download icon and its hover. The last is the alphabet rail's pending
  spinner in CSS. Icons follow the text: as graphics they need only
  3:1, and the raw accent misses even that on iron.
- check-tint-contrast adds accent to TEXT_NEVER_RAW, so a new raw
  text-accent or color: var(--fs-accent) fails the web lane. Run against
  the files before the swap, it finds all 36. Borders, rings and fills
  keep the raw accent.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-08 00:17:19 -04:00

83 lines
3.7 KiB
JavaScript

import { describe, expect, test } from 'vitest';
import { fileURLToPath } from 'node:url';
import { dirname, resolve } from 'node:path';
import { findCss, findRawText, findTailwind, scan } from './check-tint-contrast.js';
const web = resolve(dirname(fileURLToPath(import.meta.url)), '..');
describe('hue-on-own-tint check (#3150)', () => {
test('no source paints a hue as text on a tint of itself', () => {
expect(scan(resolve(web, 'src'), web)).toEqual([]);
});
describe('Tailwind', () => {
test('finds text-X on bg-X-tint and bg-X/NN in one class string', () => {
expect(findTailwind(`class="rounded bg-accent-tint px-2 text-accent"`)).toHaveLength(1);
expect(findTailwind(`'bg-error/15 text-error'`)).toHaveLength(1);
expect(findTailwind("`bg-moss/10 text-moss`")[0].fix).toBe('text-success-fg');
});
test('a class string spanning lines is one string', () => {
expect(findTailwind(`class="bg-accent-tint\n text-accent"`)).toHaveLength(1);
});
test('an apostrophe earlier in the file does not hide a pair', () => {
expect(
findTailwind(`<p>Couldn't add</p>\n<span class={on ? 'bg-accent-tint text-accent' : ''}>`)
).toHaveLength(1);
});
test('passes the -fg partner, another hue, and a tint with no hue text', () => {
expect(findTailwind(`"bg-accent-tint text-accent-fg"`)).toEqual([]);
expect(findTailwind(`"bg-accent-tint text-error"`)).toEqual([]);
expect(findTailwind(`"bg-accent-tint text-text-primary"`)).toEqual([]);
expect(findTailwind(`"text-accent"`)).toEqual([]);
});
});
describe('raw error text, on any surface', () => {
test('finds text-error, class:text-error and color: var(--fs-error)', () => {
expect(findRawText(`<p class="text-sm text-error">x</p>`)).toHaveLength(1);
expect(findRawText(`<div class:text-error={bad}>`)).toHaveLength(1);
expect(findRawText(`.msg { color: var(--fs-error); }`)[0].fix).toBe('var(--fs-error-fg)');
});
test('raw accent text is caught too, including hover: variants (#5318)', () => {
expect(findRawText(`<a class="text-sm text-accent hover:underline">`)[0].fix).toBe('text-accent-fg');
expect(findRawText(`<a class="hover:text-accent">`)).toHaveLength(1);
expect(findRawText(`.pending { color: var(--fs-accent); }`)[0].fix).toBe('var(--fs-accent-fg)');
expect(findRawText(`<a class="text-accent-fg border-accent">`)).toEqual([]);
});
test('passes error-fg, and error as a border or outline', () => {
expect(findRawText(`<p class="text-error-fg">x</p>`)).toEqual([]);
expect(findRawText(`<div class="border-error" class:border-error={bad}>`)).toEqual([]);
expect(findRawText(`.a { border-color: var(--fs-error); outline-color: var(--fs-error); }`)).toEqual([]);
});
});
describe('CSS', () => {
const tinted = (color) =>
`.pill { background: color-mix(in srgb, var(--fs-warning) 15%, transparent); ${color} }`;
test('finds color: var(--fs-X) on a color-mix tint of X', () => {
expect(findCss(tinted('color: var(--fs-warning);'))).toHaveLength(1);
expect(findCss(tinted('color: var(--fs-warning);'))[0].fix).toBe('var(--fs-warning-fg)');
});
test('passes the -fg partner and border or outline colours', () => {
expect(findCss(tinted('color: var(--fs-warning-fg);'))).toEqual([]);
expect(findCss(tinted('border-color: var(--fs-warning);'))).toEqual([]);
expect(findCss(tinted('outline-color: var(--fs-warning);'))).toEqual([]);
});
test('a tint and a colour in different rules are not a pair', () => {
expect(
findCss(
`.a { background: color-mix(in srgb, var(--fs-accent) 15%, transparent); }\n.b { color: var(--fs-accent); }`
)
).toEqual([]);
});
});
});