bvandeusenandClaude Opus 5
86af79bd2f
Migration 0049 adds suggestion_snoozes(user_id, candidate_mbid, candidate_name, snoozed_until), and SuggestArtistsForUser excludes rows whose snooze hasn't expired. This is NOT a dislike. Rule #101 forbids a "Not for me" / thumbs-down UI; a snooze is the approved shape instead because it records no verdict on the music, expires on its own (~90d), and never reaches the taste profile. It's acquisition triage — "not right now" — so the filter sits at the candidate stage rather than in the score, where it would become a ranking signal by the back door. Per-user throughout (rule #47): one household member parking a candidate leaves everyone else's deck untouched. candidate_name is denormalized because suggestions are out-of-library by definition — there is no artists row to resolve a display name from, and the un-snooze list has to show something. That list is why GET /discover/snoozes exists at all: a parked candidate is by definition absent from the deck, so without it the DELETE would be unreachable. Also fixes a hole in the codegen check from #2380: `git diff` ignores untracked paths, so a brand-new generated file would have passed it silently. `git add -N` first. This commit is the first to add one. Endpoints: POST /api/discover/suggestions/{mbid}/snooze (body: name, days) DELETE /api/discover/suggestions/{mbid}/snooze GET /api/discover/snoozes UI lands in slice 4 (#2375) before any of this merges — rule #27. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
53 lines
2.1 KiB
Makefile
53 lines
2.1 KiB
Makefile
.PHONY: generate generate-go verify-generate test test-short test-integration lint build
|
|
|
|
# renovate: datasource=docker depName=sqlc/sqlc
|
|
SQLC_VERSION := 1.31.1
|
|
|
|
# Local codegen. Containerised so a dev needs no sqlc install.
|
|
generate:
|
|
docker run --rm -v "$(CURDIR):/src" -w /src sqlc/sqlc:$(SQLC_VERSION) generate
|
|
|
|
# Same codegen, run as a Go tool instead of a container. This is the CI path:
|
|
# the ci-go image already has Go, so it avoids docker-in-docker. Pinned to the
|
|
# SAME version as `generate` above so both routes emit identical output.
|
|
generate-go:
|
|
go run github.com/sqlc-dev/sqlc/cmd/sqlc@v$(SQLC_VERSION) generate
|
|
|
|
# Fail if the committed generated code no longer matches the .sql sources.
|
|
#
|
|
# Nothing verified this before, so internal/db/dbq could silently drift from
|
|
# internal/db/queries — a hand-edit, a half-applied regen, or a schema change
|
|
# without a regen would all pass CI while the typed layer lied about the SQL.
|
|
#
|
|
# The diff is printed BEFORE the exit-code check on purpose: when this fails,
|
|
# the log then contains sqlc's exact expected output, which is what you commit.
|
|
verify-generate: generate-go
|
|
# -N (intent-to-add) so a BRAND-NEW generated file is visible to `git
|
|
# diff`, which otherwise ignores untracked paths entirely — a whole
|
|
# missing *.sql.go would sail through the check below.
|
|
git add -N -- internal/db/dbq
|
|
git --no-pager diff -- internal/db/dbq
|
|
git diff --quiet -- internal/db/dbq
|
|
|
|
test:
|
|
go test -race ./...
|
|
|
|
test-short:
|
|
go test -short -race ./...
|
|
|
|
# Full suite incl. integration tests, against the dedicated minstrel_test
|
|
# DB so a run never truncates the dev `minstrel` DB (Fable #339). Ensures
|
|
# the test DB exists (idempotent — createdb errors if present, ignored).
|
|
test-integration:
|
|
docker compose up -d postgres
|
|
-docker compose exec -T postgres createdb -U minstrel minstrel_test
|
|
# -p 1: integration packages share one test DB and each TRUNCATEs it;
|
|
# concurrent package binaries deadlock on TRUNCATE. Serialize packages.
|
|
MINSTREL_TEST_DATABASE_URL=postgres://minstrel:minstrel@localhost:5432/minstrel_test?sslmode=disable go test -p 1 -race ./...
|
|
|
|
lint:
|
|
golangci-lint run ./...
|
|
|
|
build:
|
|
go build -o bin/minstrel ./cmd/minstrel
|