bvandeusenandClaude Opus 5.5
743b6f5eac
release / govulncheck (push) Successful in 17s
release / web (push) Successful in 1m6s
release / go (push) Successful in 1m29s
release / integration (push) Successful in 4m30s
release / android (push) Successful in 5m18s
release / Build signed APK (releases and dev) (push) Successful in 5m32s
release / Attach APK to the Release (tag releases only) (push) Skipped
release / Build + push container image (push) Successful in 25s
release / Verify release artifacts (tag releases only) (push) Skipped
Raw error red fails AA as text even with no tint behind it: in dark mode it measures 3.63:1 on obsidian, 3.23 on iron and 2.64 on slate, against 4.5. error-fg (the house formula, 50% toward parchment) measures 5.30 at worst across both modes. - All 19 text-error uses become text-error-fg: the "Couldn't load" messages on the admin pages, the integrations form errors, the flag popover, and the error toast's text. The toast keeps its error border, since a border is a graphic with a 3:1 floor. - check-tint-contrast flags raw error text anywhere (text-error, class:text-error, color: var(--fs-error)) and leaves borders and outlines alone. Run against the files before the swap, it finds all 19. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
76 lines
3.3 KiB
JavaScript
76 lines
3.3 KiB
JavaScript
import { describe, expect, test } from 'vitest';
|
|
import { fileURLToPath } from 'node:url';
|
|
import { dirname, resolve } from 'node:path';
|
|
import { findCss, findRawText, findTailwind, scan } from './check-tint-contrast.js';
|
|
|
|
const web = resolve(dirname(fileURLToPath(import.meta.url)), '..');
|
|
|
|
describe('hue-on-own-tint check (#3150)', () => {
|
|
test('no source paints a hue as text on a tint of itself', () => {
|
|
expect(scan(resolve(web, 'src'), web)).toEqual([]);
|
|
});
|
|
|
|
describe('Tailwind', () => {
|
|
test('finds text-X on bg-X-tint and bg-X/NN in one class string', () => {
|
|
expect(findTailwind(`class="rounded bg-accent-tint px-2 text-accent"`)).toHaveLength(1);
|
|
expect(findTailwind(`'bg-error/15 text-error'`)).toHaveLength(1);
|
|
expect(findTailwind("`bg-moss/10 text-moss`")[0].fix).toBe('text-success-fg');
|
|
});
|
|
|
|
test('a class string spanning lines is one string', () => {
|
|
expect(findTailwind(`class="bg-accent-tint\n text-accent"`)).toHaveLength(1);
|
|
});
|
|
|
|
test('an apostrophe earlier in the file does not hide a pair', () => {
|
|
expect(
|
|
findTailwind(`<p>Couldn't add</p>\n<span class={on ? 'bg-accent-tint text-accent' : ''}>`)
|
|
).toHaveLength(1);
|
|
});
|
|
|
|
test('passes the -fg partner, another hue, and a tint with no hue text', () => {
|
|
expect(findTailwind(`"bg-accent-tint text-accent-fg"`)).toEqual([]);
|
|
expect(findTailwind(`"bg-accent-tint text-error"`)).toEqual([]);
|
|
expect(findTailwind(`"bg-accent-tint text-text-primary"`)).toEqual([]);
|
|
expect(findTailwind(`"text-accent"`)).toEqual([]);
|
|
});
|
|
});
|
|
|
|
describe('raw error text, on any surface', () => {
|
|
test('finds text-error, class:text-error and color: var(--fs-error)', () => {
|
|
expect(findRawText(`<p class="text-sm text-error">x</p>`)).toHaveLength(1);
|
|
expect(findRawText(`<div class:text-error={bad}>`)).toHaveLength(1);
|
|
expect(findRawText(`.msg { color: var(--fs-error); }`)[0].fix).toBe('var(--fs-error-fg)');
|
|
});
|
|
|
|
test('passes error-fg, and error as a border or outline', () => {
|
|
expect(findRawText(`<p class="text-error-fg">x</p>`)).toEqual([]);
|
|
expect(findRawText(`<div class="border-error" class:border-error={bad}>`)).toEqual([]);
|
|
expect(findRawText(`.a { border-color: var(--fs-error); outline-color: var(--fs-error); }`)).toEqual([]);
|
|
});
|
|
});
|
|
|
|
describe('CSS', () => {
|
|
const tinted = (color) =>
|
|
`.pill { background: color-mix(in srgb, var(--fs-warning) 15%, transparent); ${color} }`;
|
|
|
|
test('finds color: var(--fs-X) on a color-mix tint of X', () => {
|
|
expect(findCss(tinted('color: var(--fs-warning);'))).toHaveLength(1);
|
|
expect(findCss(tinted('color: var(--fs-warning);'))[0].fix).toBe('var(--fs-warning-fg)');
|
|
});
|
|
|
|
test('passes the -fg partner and border or outline colours', () => {
|
|
expect(findCss(tinted('color: var(--fs-warning-fg);'))).toEqual([]);
|
|
expect(findCss(tinted('border-color: var(--fs-warning);'))).toEqual([]);
|
|
expect(findCss(tinted('outline-color: var(--fs-warning);'))).toEqual([]);
|
|
});
|
|
|
|
test('a tint and a colour in different rules are not a pair', () => {
|
|
expect(
|
|
findCss(
|
|
`.a { background: color-mix(in srgb, var(--fs-accent) 15%, transparent); }\n.b { color: var(--fs-accent); }`
|
|
)
|
|
).toEqual([]);
|
|
});
|
|
});
|
|
});
|