bvandeusen
58766dbebe
The PR1-T2 admin handler migration replaced bespoke 500-class messages
("lookup failed", "refetch failed", "trigger failed", "bump failed",
"remove failed", "update failed", "schedule row missing", "re-read
failed", "read failed") with apierror.Internal(err), which forces the
wire Message to "internal server error". That violates the PR1
contract that errEnvelope{Code, Message} must remain byte-identical
for existing clients.
Add apierror.InternalMsg(message, cause) — a 500-class constructor
that preserves the call site's user-facing message while keeping the
cause attached for logging and errors.Is. Re-migrate the 12 admin
sites whose pre-1cc7eb6 source had a non-empty bespoke Message so
they restore the original wire string. Sites whose original Message
was empty stay on Internal(err) (humanization to "internal server
error" is a tolerable improvement, not a regression).
admin_smtp.go's send_failed site (line 129) was already preserved
via a raw &apierror.Error literal in 1cc7eb6 and needs no fix.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
26 lines
953 B
Go
26 lines
953 B
Go
package api
|
|
|
|
import (
|
|
"net/http"
|
|
|
|
"git.fabledsword.com/bvandeusen/minstrel/internal/apierror"
|
|
)
|
|
|
|
// handleResearchMissingArt bumps the cover-art version unconditionally
|
|
// so every 'none' row becomes eligible at the next enrichment pass.
|
|
// Operator's escape hatch when adding a Last.fm key, when an upstream
|
|
// provider's catalog has updated, or when verifying a fix without
|
|
// waiting for the next scheduled scan.
|
|
//
|
|
// Existing positively-sourced rows (sidecar/embedded/mbcaa/theaudiodb/
|
|
// deezer/lastfm) are not affected — the version-mismatch eligibility
|
|
// rule only kicks in for 'none'.
|
|
func (h *handlers) handleResearchMissingArt(w http.ResponseWriter, r *http.Request) {
|
|
newVer, err := h.coverSettings.BumpVersion(r.Context())
|
|
if err != nil {
|
|
writeErrWithLog(w, h.logger, "admin: research missing art bump failed", apierror.InternalMsg("bump failed", err))
|
|
return
|
|
}
|
|
writeJSON(w, http.StatusOK, map[string]any{"version": newVer})
|
|
}
|