c4cccea775
The bootstrap-admin-from-env-vars flow was a holdover from before self-registration could create the first admin. Now that handleRegister + CreateUserFirstAdminRace promotes the first user to register on an empty users table (verified shipped in v2026.05.08.2 / #376), the bootstrap path is just a second source of truth that confuses operators (and leaves an "admin" account in the DB that nobody asked for). Removes: - internal/auth/bootstrap.go + its test - The auth.Bootstrap call from cmd/minstrel/main.go - AuthConfig + AdminBootstrapConfig structs from config - MINSTREL_AUTH_ADMIN_USERNAME / _PASSWORD env reads + their test - The auth: block from config.example.yaml - Bootstrap-related comments in docker-compose.yml + README.md The README quickstart now points operators at /register on first start instead of "watch the logs for a one-time password." Existing instances keep their bootstrap-admin row in the DB; operators who want it gone can register a new admin via /register, promote them in /admin/users, then delete the old bootstrap user (last-admin guard will require the new admin to be promoted first). No migration needed. Recovery story for forgotten admin passwords now hinges on Fable #321 (admin password reset CLI) — currently the only path back in if no other admin exists. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
185 lines
4.6 KiB
Go
185 lines
4.6 KiB
Go
package config
|
|
|
|
import (
|
|
"os"
|
|
"path/filepath"
|
|
"testing"
|
|
)
|
|
|
|
func TestDefault(t *testing.T) {
|
|
cfg := Default()
|
|
if cfg.Server.Address != ":4533" {
|
|
t.Errorf("default server address = %q, want :4533", cfg.Server.Address)
|
|
}
|
|
if cfg.Log.Level != "info" {
|
|
t.Errorf("default log level = %q, want info", cfg.Log.Level)
|
|
}
|
|
}
|
|
|
|
func TestLoadYAML(t *testing.T) {
|
|
dir := t.TempDir()
|
|
path := filepath.Join(dir, "config.yaml")
|
|
content := []byte(`server:
|
|
address: ":9000"
|
|
database:
|
|
url: "postgres://example"
|
|
log:
|
|
level: "debug"
|
|
format: "json"
|
|
`)
|
|
if err := os.WriteFile(path, content, 0o644); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
cfg, err := Load(path)
|
|
if err != nil {
|
|
t.Fatalf("Load: %v", err)
|
|
}
|
|
if cfg.Server.Address != ":9000" {
|
|
t.Errorf("server.address = %q", cfg.Server.Address)
|
|
}
|
|
if cfg.Database.URL != "postgres://example" {
|
|
t.Errorf("database.url = %q", cfg.Database.URL)
|
|
}
|
|
if cfg.Log.Level != "debug" || cfg.Log.Format != "json" {
|
|
t.Errorf("log = %+v", cfg.Log)
|
|
}
|
|
}
|
|
|
|
func TestLoadMissingFileReturnsDefaults(t *testing.T) {
|
|
cfg, err := Load(filepath.Join(t.TempDir(), "does-not-exist.yaml"))
|
|
if err != nil {
|
|
t.Fatalf("Load: %v", err)
|
|
}
|
|
if cfg.Server.Address != ":4533" {
|
|
t.Errorf("expected defaults, got %+v", cfg)
|
|
}
|
|
}
|
|
|
|
func TestEnvOverrides(t *testing.T) {
|
|
t.Setenv("MINSTREL_SERVER_ADDRESS", ":8080")
|
|
t.Setenv("MINSTREL_DATABASE_URL", "postgres://env")
|
|
t.Setenv("MINSTREL_LOG_LEVEL", "WARN")
|
|
t.Setenv("MINSTREL_LOG_FORMAT", "JSON")
|
|
|
|
cfg, err := Load("")
|
|
if err != nil {
|
|
t.Fatalf("Load: %v", err)
|
|
}
|
|
if cfg.Server.Address != ":8080" {
|
|
t.Errorf("server.address = %q", cfg.Server.Address)
|
|
}
|
|
if cfg.Database.URL != "postgres://env" {
|
|
t.Errorf("database.url = %q", cfg.Database.URL)
|
|
}
|
|
if cfg.Log.Level != "warn" {
|
|
t.Errorf("log.level = %q, want lowercased warn", cfg.Log.Level)
|
|
}
|
|
if cfg.Log.Format != "json" {
|
|
t.Errorf("log.format = %q, want lowercased json", cfg.Log.Format)
|
|
}
|
|
}
|
|
|
|
func TestLibraryEnvOverrides(t *testing.T) {
|
|
t.Setenv("MINSTREL_LIBRARY_SCAN_PATHS", "/music:/other::/third")
|
|
t.Setenv("MINSTREL_LIBRARY_SCAN_ON_STARTUP", "true")
|
|
|
|
cfg, err := Load("")
|
|
if err != nil {
|
|
t.Fatalf("Load: %v", err)
|
|
}
|
|
want := []string{"/music", "/other", "/third"}
|
|
if len(cfg.Library.ScanPaths) != len(want) {
|
|
t.Fatalf("scan_paths = %v, want %v", cfg.Library.ScanPaths, want)
|
|
}
|
|
for i, p := range want {
|
|
if cfg.Library.ScanPaths[i] != p {
|
|
t.Errorf("scan_paths[%d] = %q, want %q", i, cfg.Library.ScanPaths[i], p)
|
|
}
|
|
}
|
|
if !cfg.Library.ScanOnStartup {
|
|
t.Error("scan_on_startup = false, want true")
|
|
}
|
|
}
|
|
|
|
func TestSubsonicEnvOverride(t *testing.T) {
|
|
t.Setenv("MINSTREL_SUBSONIC_ALLOW_PLAINTEXT_PASSWORD", "true")
|
|
cfg, err := Load("")
|
|
if err != nil {
|
|
t.Fatalf("Load: %v", err)
|
|
}
|
|
if !cfg.Subsonic.AllowPlaintextPassword {
|
|
t.Error("allow_plaintext_password = false, want true")
|
|
}
|
|
}
|
|
|
|
func TestLibraryYAMLLoads(t *testing.T) {
|
|
dir := t.TempDir()
|
|
path := filepath.Join(dir, "config.yaml")
|
|
content := []byte(`library:
|
|
scan_paths:
|
|
- /srv/music
|
|
- /mnt/archive
|
|
scan_on_startup: true
|
|
`)
|
|
if err := os.WriteFile(path, content, 0o644); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
cfg, err := Load(path)
|
|
if err != nil {
|
|
t.Fatalf("Load: %v", err)
|
|
}
|
|
if len(cfg.Library.ScanPaths) != 2 || cfg.Library.ScanPaths[0] != "/srv/music" {
|
|
t.Errorf("scan_paths = %v", cfg.Library.ScanPaths)
|
|
}
|
|
if !cfg.Library.ScanOnStartup {
|
|
t.Error("scan_on_startup = false")
|
|
}
|
|
}
|
|
|
|
func TestBrandingDefaults(t *testing.T) {
|
|
cfg := Default()
|
|
if cfg.Branding.AppName != "Minstrel" {
|
|
t.Errorf("AppName: got %q, want %q", cfg.Branding.AppName, "Minstrel")
|
|
}
|
|
if cfg.Branding.Description == "" {
|
|
t.Errorf("Description: empty after Default(); want default tagline")
|
|
}
|
|
}
|
|
|
|
func TestBrandingYAMLOverride(t *testing.T) {
|
|
dir := t.TempDir()
|
|
path := filepath.Join(dir, "config.yaml")
|
|
content := []byte(`branding:
|
|
app_name: "Family Jukebox"
|
|
description: "Our home library."
|
|
`)
|
|
if err := os.WriteFile(path, content, 0o644); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
cfg, err := Load(path)
|
|
if err != nil {
|
|
t.Fatalf("Load: %v", err)
|
|
}
|
|
if cfg.Branding.AppName != "Family Jukebox" {
|
|
t.Errorf("AppName: got %q", cfg.Branding.AppName)
|
|
}
|
|
if cfg.Branding.Description != "Our home library." {
|
|
t.Errorf("Description: got %q", cfg.Branding.Description)
|
|
}
|
|
}
|
|
|
|
func TestBrandingEnvOverride(t *testing.T) {
|
|
t.Setenv("MINSTREL_BRANDING_APP_NAME", "Office Music")
|
|
t.Setenv("MINSTREL_BRANDING_DESCRIPTION", "Office tunes.")
|
|
cfg, err := Load("")
|
|
if err != nil {
|
|
t.Fatalf("Load: %v", err)
|
|
}
|
|
if cfg.Branding.AppName != "Office Music" {
|
|
t.Errorf("AppName: got %q", cfg.Branding.AppName)
|
|
}
|
|
if cfg.Branding.Description != "Office tunes." {
|
|
t.Errorf("Description: got %q", cfg.Branding.Description)
|
|
}
|
|
}
|