bvandeusen 1cc7eb6cad refactor(server/api): writeErr accepts error; migrate admin handlers (1/3) ...

Rewrite writeErr(w, err) to wrap *apierror.Error via apierror.From,
preserving the existing {"error": {"code", "message"}} wire envelope.
Add writeErrWithLog helper for 500-class errors that need an operator
log line. Migrate all 13 admin_*.go handler files (~76 call sites) to
the new signature; T3 will sweep the remaining api package.

The old 4-arg writeErr is removed, so non-admin call sites in
internal/api will not compile until T3 lands. This is by design — T2
and T3 are paired.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

2026-05-07 19:48:25 -04:00

..

admin_cover_sources_test.go

feat(server/m7-cover-sources): admin cover-sources HTTP handlers

2026-05-06 13:08:45 -04:00

admin_cover_sources.go

refactor(server/api): writeErr accepts error; migrate admin handlers (1/3)

2026-05-07 19:48:25 -04:00

admin_coverage_test.go

chore(server/m7-coverage-gauge): align coverage test with peer style

2026-05-06 10:08:58 -04:00

admin_coverage.go

refactor(server/api): writeErr accepts error; migrate admin handlers (1/3)

2026-05-07 19:48:25 -04:00

admin_coverart_research_test.go

feat(server/web/coverart): manual Re-search missing art button

2026-05-07 07:59:40 -04:00

admin_coverart_research.go

refactor(server/api): writeErr accepts error; migrate admin handlers (1/3)

2026-05-07 19:48:25 -04:00

admin_covers_test.go

fix(server,web/m7-cover-sources): forward-fix CI round 2

2026-05-06 13:55:35 -04:00

admin_covers.go

refactor(server/api): writeErr accepts error; migrate admin handlers (1/3)

2026-05-07 19:48:25 -04:00

admin_invites_test.go

feat(server/m7-user-mgmt): admin endpoints (invites, users, promote/demote)

2026-05-07 12:01:16 -04:00

admin_invites.go

refactor(server/api): writeErr accepts error; migrate admin handlers (1/3)

2026-05-07 19:48:25 -04:00

admin_lidarr_test.go

feat(api): add /api/admin/lidarr/* config + profiles + folders + test

2026-04-29 17:44:54 -04:00

admin_lidarr.go

feat(admin): metadata-profile picker on integrations page

2026-05-02 00:09:13 -04:00

admin_quarantine_test.go

feat(api): /api/quarantine user + admin endpoints + Service wiring

2026-04-30 20:19:39 -04:00

admin_quarantine.go

feat(api): /api/quarantine user + admin endpoints + Service wiring

2026-04-30 20:19:39 -04:00

admin_requests_test.go

feat(api): add /api/admin/requests approval queue

2026-04-29 17:56:25 -04:00

admin_requests.go

feat(requests): show ingest progress while requests are in flight

2026-05-02 13:04:38 -04:00

admin_scan_schedule_test.go

test(server/m7-recurring-scans): TZ-tolerant next-fire assertion

2026-05-06 22:59:23 -04:00

admin_scan_schedule.go

refactor(server/api): writeErr accepts error; migrate admin handlers (1/3)

2026-05-07 19:48:25 -04:00

admin_scan_test.go

feat(server/m7-381): admin scan-status + manual trigger endpoints

2026-05-04 20:13:31 -04:00

admin_scan.go

refactor(server/api): writeErr accepts error; migrate admin handlers (1/3)

2026-05-07 19:48:25 -04:00

admin_smtp_test.go

feat(server/m7-user-mgmt): mailer package + SMTP config endpoints (U3)

2026-05-07 12:43:44 -04:00

admin_smtp.go

refactor(server/api): writeErr accepts error; migrate admin handlers (1/3)

2026-05-07 19:48:25 -04:00

admin_tracks_test.go

feat(server/m7-cover-sources): artist art enricher (thumb + fanart)

2026-05-06 12:59:53 -04:00

admin_tracks.go

refactor(server/api): writeErr accepts error; migrate admin handlers (1/3)

2026-05-07 19:48:25 -04:00

admin_users_test.go

feat(server/m7-user-mgmt): admin user CRUD endpoints (U2)

2026-05-07 12:17:14 -04:00

admin_users.go

refactor(server/api): writeErr accepts error; migrate admin handlers (1/3)

2026-05-07 19:48:25 -04:00

api.go

feat(server/m7-user-mgmt): forgot + reset password endpoints (U3)

2026-05-07 12:49:30 -04:00

auth_forgot_test.go

feat(server/m7-user-mgmt): forgot + reset password endpoints (U3)

2026-05-07 12:49:30 -04:00

auth_forgot.go

feat(server/m7-user-mgmt): forgot + reset password endpoints (U3)

2026-05-07 12:49:30 -04:00

auth_register_test.go

feat(server/m7-user-mgmt): self-registration handler

2026-05-07 11:56:19 -04:00

auth_register.go

feat(server/m7-user-mgmt): self-registration handler

2026-05-07 11:56:19 -04:00

auth_reset_test.go

feat(server/m7-user-mgmt): forgot + reset password endpoints (U3)

2026-05-07 12:49:30 -04:00

auth_reset.go

feat(server/m7-user-mgmt): forgot + reset password endpoints (U3)

2026-05-07 12:49:30 -04:00

auth_test.go

feat(server/m7-user-mgmt): forgot + reset password endpoints (U3)

2026-05-07 12:49:30 -04:00

auth.go

fix(api): trim whitespace from bearer token in logout

2026-04-20 22:32:12 -04:00

convert_test.go

style: gofmt fixes across api package

2026-04-21 23:02:20 -04:00

convert.go

fix(server): forward-fix CI — gofmt convert/types + rename unused r in enricher_test

2026-05-04 17:41:16 -04:00

errors_test.go

refactor(server/api): writeErr accepts error; migrate admin handlers (1/3)

2026-05-07 19:48:25 -04:00

errors.go

refactor(server/api): writeErr accepts error; migrate admin handlers (1/3)

2026-05-07 19:48:25 -04:00

events_test.go

feat(api): add POST /api/events handler

2026-04-26 00:12:06 -04:00

events.go

feat(api): add POST /api/events handler

2026-04-26 00:12:06 -04:00

home_test.go

feat(api): add GET /api/home composite handler

2026-05-01 17:58:59 -04:00

home.go

feat(api): add GET /api/home composite handler

2026-05-01 17:58:59 -04:00

library_albums_test.go

feat(api): add GET /api/library/albums handler

2026-05-01 18:00:59 -04:00

library_albums.go

feat(api): add GET /api/library/albums handler

2026-05-01 18:00:59 -04:00

library_fixtures_test.go

feat(api): add GET/PUT /api/me/listenbrainz endpoints

2026-04-28 09:27:06 -04:00

library_test.go

fix(ci): library_test Mount arg + 4 web test selectors + forgot-pw catch

2026-05-07 18:05:30 -04:00

library.go

feat(api): wire M6a routes; alpha artist list uses covers query

2026-05-01 18:10:04 -04:00

lidarr_test.go

fix(api): gofmt + revive cleanup on lidarr search handler

2026-04-29 17:35:45 -04:00

lidarr.go

fix(api): gofmt + revive cleanup on lidarr search handler

2026-04-29 17:35:45 -04:00

likes_test.go

feat(api): capture contextual_likes on like during open play_event

2026-04-27 11:22:35 -04:00

likes.go

feat(api): capture contextual_likes on like during open play_event

2026-04-27 11:22:35 -04:00

listenbrainz_test.go

feat(api): add GET/PUT /api/me/listenbrainz endpoints

2026-04-28 09:27:06 -04:00

listenbrainz.go

feat(api): add GET/PUT /api/me/listenbrainz endpoints

2026-04-28 09:27:06 -04:00

me_history_test.go

fix(server/m7-365): silence unused-pool-param lint in history test

2026-05-04 07:05:49 -04:00

me_history.go

feat(server/m7-365): GET /api/me/history handler + integration test

2026-05-04 05:52:17 -04:00

me_password_test.go

feat(server/m7-user-mgmt): self-service /me endpoints (U3)

2026-05-07 12:38:48 -04:00

me_password.go

feat(server/m7-user-mgmt): self-service /me endpoints (U3)

2026-05-07 12:38:48 -04:00

me_profile_test.go

feat(server/m7-user-mgmt): self-service /me endpoints (U3)

2026-05-07 12:38:48 -04:00

me_profile.go

feat(server/m7-user-mgmt): self-service /me endpoints (U3)

2026-05-07 12:38:48 -04:00

me_system_playlists_test.go

feat(server/m7-352): GET /api/me/system-playlists-status for home placeholders

2026-05-04 18:13:13 -04:00

me_system_playlists.go

feat(server/m7-352): GET /api/me/system-playlists-status for home placeholders

2026-05-04 18:13:13 -04:00

me_test.go

test: add dbtest.ResetDB helper that preserves admin user

2026-04-29 11:55:06 -04:00

me_token_test.go

feat(server/m7-user-mgmt): self-service /me endpoints (U3)

2026-05-07 12:38:48 -04:00

me_token.go

feat(server/m7-user-mgmt): self-service /me endpoints (U3)

2026-05-07 12:38:48 -04:00

me.go

feat(api): GET /api/me

2026-04-20 22:11:02 -04:00

media_test.go

fix(server,web/m7-353): post-review fixes (test compilation, AlbumRef field, bulk handler, design system)

2026-05-04 15:21:24 -04:00

media.go

refactor(server/m7-353): consolidate findSidecarCover into coverart package

2026-05-04 14:46:28 -04:00

playlists_discover_refresh_test.go

feat(server/playlists): manual Discover refresh endpoint

2026-05-07 08:39:26 -04:00

playlists_discover_refresh.go

feat(server/playlists): manual Discover refresh endpoint

2026-05-07 08:39:26 -04:00

playlists_foryou_refresh_test.go

feat(server/playlists): manual For-You refresh endpoint

2026-05-07 10:37:12 -04:00

playlists_foryou_refresh.go

feat(server/playlists): manual For-You refresh endpoint

2026-05-07 10:37:12 -04:00

playlists_test.go

feat(server/m7-352): 403 system_playlist_readonly on playlist edit endpoints

2026-05-04 09:29:37 -04:00

playlists.go

feat(server/playlists): generate cover collages for system playlists

2026-05-07 08:14:13 -04:00

quarantine_test.go

feat(api): /api/quarantine user + admin endpoints + Service wiring

2026-04-30 20:19:39 -04:00

quarantine.go

feat(api): /api/quarantine user + admin endpoints + Service wiring

2026-04-30 20:19:39 -04:00

radio_test.go

feat(api): radio uses similarity pool with exclude param + M3 fallback

2026-04-29 08:47:31 -04:00

radio.go

feat(api): radio uses similarity pool with exclude param + M3 fallback

2026-04-29 08:47:31 -04:00

requests_test.go

feat(server/m7-user-mgmt): U2.5 auto-approve handler wiring

2026-05-07 18:46:01 -04:00

requests.go

feat(server/m7-user-mgmt): U2.5 auto-approve handler wiring

2026-05-07 18:46:01 -04:00

search_test.go

feat(api): GET /api/search with three paged facets

2026-04-21 08:29:28 -04:00

search.go

feat(api): route track-list reads through user-context quarantine filter

2026-04-30 20:09:04 -04:00

suggestions_test.go

feat(api): /api/discover/suggestions handler

2026-05-01 06:23:08 -04:00

suggestions.go

feat(api): /api/discover/suggestions handler

2026-05-01 06:23:08 -04:00

types.go

fix(server): forward-fix CI — gofmt convert/types + rename unused r in enricher_test

2026-05-04 17:41:16 -04:00