bvandeusen
94727f40bb
- cache_first.dart: backtick-fence List<T> doc comment to dodge unintended_html_in_doc_comment. - library_providers.dart:163: switch single-row insert to insertAllOnConflictUpdate; Batch only exposes the *AllOnConflict* variant. - 5 test files: StreamProvider.overrideWith takes Create<Stream<T>>, not Create<Future<T>>. Wrap data emissions in Stream.value(...). - artist_detail_screen_test: add models/album.dart import for AlbumRef type annotation. - track_actions_sheet_test: drop _StubLiked extends LikedIdsController (notifier no longer exists post-migration); override with Stream.value(LikedIds(...)) instead. - like_button_test: rollback assertion now requires drift writes via LikesController. Skip under _skipDrift until libsqlite3-dev lands on the runner image (Fable #399). Replace stale .notifier reference with likesControllerProvider for completeness. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
86 lines
2.9 KiB
Dart
86 lines
2.9 KiB
Dart
import 'package:flutter/material.dart';
|
|
import 'package:flutter_riverpod/flutter_riverpod.dart';
|
|
import 'package:flutter_test/flutter_test.dart';
|
|
|
|
import 'package:minstrel/api/endpoints/likes.dart';
|
|
import 'package:minstrel/likes/like_button.dart';
|
|
import 'package:minstrel/likes/likes_provider.dart';
|
|
import 'package:minstrel/models/album.dart';
|
|
import 'package:minstrel/models/artist.dart';
|
|
import 'package:minstrel/models/page.dart';
|
|
import 'package:minstrel/models/track.dart';
|
|
import 'package:minstrel/theme/theme_data.dart';
|
|
|
|
class _ThrowingLikesApi implements LikesApi {
|
|
bool throwOnNext = false;
|
|
|
|
@override
|
|
Future<void> like(LikeKind kind, String id) async {
|
|
if (throwOnNext) throw StateError('boom');
|
|
}
|
|
|
|
@override
|
|
Future<void> unlike(LikeKind kind, String id) async {
|
|
if (throwOnNext) throw StateError('boom');
|
|
}
|
|
|
|
@override
|
|
Future<({Set<String> artists, Set<String> albums, Set<String> tracks})>
|
|
ids() async =>
|
|
(artists: <String>{}, albums: <String>{}, tracks: <String>{});
|
|
|
|
// The list-* methods aren't exercised by this test; return empty pages.
|
|
@override
|
|
Future<Paged<TrackRef>> listTracks({int limit = 50, int offset = 0}) async =>
|
|
const Paged<TrackRef>(items: [], total: 0, limit: 50, offset: 0);
|
|
|
|
@override
|
|
Future<Paged<AlbumRef>> listAlbums({int limit = 50, int offset = 0}) async =>
|
|
const Paged<AlbumRef>(items: [], total: 0, limit: 50, offset: 0);
|
|
|
|
@override
|
|
Future<Paged<ArtistRef>> listArtists({int limit = 50, int offset = 0}) async =>
|
|
const Paged<ArtistRef>(items: [], total: 0, limit: 50, offset: 0);
|
|
}
|
|
|
|
// libsqlite3 missing on flutter-ci runner; the rollback assertion now
|
|
// depends on drift writes via LikesController. Re-enable when the runner
|
|
// image carries libsqlite3-dev (Fable #399).
|
|
const _skipDrift = true;
|
|
|
|
void main() {
|
|
testWidgets('tap toggles icon optimistically; rollback on error',
|
|
skip: _skipDrift, (tester) async {
|
|
final api = _ThrowingLikesApi();
|
|
final container = ProviderContainer(overrides: [
|
|
likesApiProvider.overrideWith((ref) async => api),
|
|
]);
|
|
addTearDown(container.dispose);
|
|
|
|
await tester.pumpWidget(UncontrolledProviderScope(
|
|
container: container,
|
|
child: MaterialApp(
|
|
theme: buildThemeData(),
|
|
home: const Scaffold(
|
|
body: LikeButton(kind: LikeKind.album, id: 'al-1'),
|
|
),
|
|
),
|
|
));
|
|
await tester.pumpAndSettle();
|
|
|
|
// First tap = like; succeeds → icon flips to favorite.
|
|
await tester.tap(find.byType(IconButton));
|
|
await tester.pump();
|
|
expect(find.byIcon(Icons.favorite), findsOneWidget);
|
|
|
|
// Force the next mutation to fail; rollback restores prior state.
|
|
api.throwOnNext = true;
|
|
final controller = container.read(likesControllerProvider);
|
|
try {
|
|
await controller.toggle(LikeKind.album, 'al-1');
|
|
} catch (_) {/* expected */}
|
|
await tester.pump();
|
|
expect(find.byIcon(Icons.favorite), findsOneWidget); // rolled back
|
|
});
|
|
}
|