bvandeusenandClaude Opus 5.5
94a9c8cbe3
Merges Renovate's kit 3 (PR #149) and adapter-static 4 (PR #148) bumps, plus the migration they need. The mechanical part is `sv migrate sveltekit-3`, run one task at a time and reviewed: - svelte.config.js is gone. Its options move into sveltekit() in vite.config.ts, exported as kitOptions so vitest.config.ts runs the same kit setup, including the $test-utils alias the tests import. - $lib becomes #lib through package.json "imports". There is no src/lib/index, so only the "#lib/*" entry is kept. - tsconfig extends $app/tsconfig. - Peer floors raised to kit 3's requirements: svelte ^5.57.1, vite ^8.0.12, svelte-check ^4.7.5. By hand, from the codemod's list of non-automated tasks: - goto's replaceState option is now replace; keepFocus becomes reset: false. For the search typeahead, reset: false also stops the scroll-to-top, which is wanted while typing. - The test setup mocks drop pushState/replaceState and $app/paths base/assets, which kit 3 removed, and mock refreshAll in place of invalidateAll. - The other flagged files only read page.url or goto internal routes, so they needed no change. TypeScript goes to ^6, not the ^7 Renovate offers: kit 3 declares typescript ^6 as a peer and svelte-check 4.7 accepts ^5 || ^6. Move to 7 once both accept it. With Tailwind 4 and kit 3 in, `npm audit` on the whole tree reports 0, so the web lane now audits every dependency rather than only what ships to browsers. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
66 lines
3.0 KiB
TypeScript
66 lines
3.0 KiB
TypeScript
import { afterEach, describe, expect, test, vi } from 'vitest';
|
|
import { render, screen, fireEvent, waitFor } from '@testing-library/svelte';
|
|
|
|
vi.mock('#lib/api/normalization.js', async (importOriginal) => ({
|
|
...(await importOriginal<typeof import('#lib/api/normalization.js')>()),
|
|
getNormalization: vi.fn(),
|
|
putNormalization: vi.fn()
|
|
}));
|
|
vi.mock('#lib/stores/toast.svelte.js', () => ({ pushToast: vi.fn() }));
|
|
|
|
import NormalizationSetting from './NormalizationSetting.svelte';
|
|
import { getNormalization, putNormalization } from '#lib/api/normalization.js';
|
|
import { normalization } from '#lib/stores/normalization.svelte.js';
|
|
import { pushToast } from '#lib/stores/toast.svelte.js';
|
|
|
|
afterEach(() => {
|
|
vi.clearAllMocks();
|
|
localStorage.clear();
|
|
});
|
|
|
|
describe('NormalizationSetting', () => {
|
|
test('shows the server value and saves the whole preference on a change', async () => {
|
|
vi.mocked(getNormalization).mockResolvedValue({ mode: 'track', target_lufs: -16, boost: 'headroom' });
|
|
vi.mocked(putNormalization).mockImplementation(async (p) => p);
|
|
render(NormalizationSetting);
|
|
|
|
await waitFor(() => expect(screen.getByRole('radio', { name: 'Track' })).toBeChecked());
|
|
expect(screen.getByRole('radio', { name: '-16 LUFS' })).toBeChecked();
|
|
|
|
await fireEvent.click(screen.getByRole('radio', { name: 'Album' }));
|
|
await waitFor(() =>
|
|
expect(putNormalization).toHaveBeenCalledWith({ mode: 'album', target_lufs: -16, boost: 'headroom' })
|
|
);
|
|
await fireEvent.click(screen.getByRole('switch', { name: /boost quiet tracks/i }));
|
|
await waitFor(() =>
|
|
expect(putNormalization).toHaveBeenLastCalledWith({ mode: 'album', target_lufs: -16, boost: 'limiter' })
|
|
);
|
|
// The last value seen is cached for the player's first track of a session.
|
|
expect(JSON.parse(localStorage.getItem('minstrel:normalization') ?? 'null')).toEqual({
|
|
mode: 'album',
|
|
target_lufs: -16,
|
|
boost: 'limiter'
|
|
});
|
|
});
|
|
|
|
test('a failed save puts the previous choice back and says so', async () => {
|
|
vi.mocked(getNormalization).mockResolvedValue({ mode: 'auto', target_lufs: -18, boost: 'headroom' });
|
|
vi.mocked(putNormalization).mockRejectedValue(new Error('offline'));
|
|
render(NormalizationSetting);
|
|
await waitFor(() => expect(screen.getByRole('radio', { name: 'Auto' })).toBeChecked());
|
|
|
|
await fireEvent.click(screen.getByRole('radio', { name: 'Off' }));
|
|
await waitFor(() => expect(pushToast).toHaveBeenCalledWith('Could not save volume leveling.', 'error'));
|
|
expect(normalization.value.mode).toBe('auto');
|
|
expect(screen.getByRole('radio', { name: 'Auto' })).toBeChecked();
|
|
});
|
|
|
|
test('off hides the target and boost controls', async () => {
|
|
vi.mocked(getNormalization).mockResolvedValue({ mode: 'off', target_lufs: -18, boost: 'headroom' });
|
|
render(NormalizationSetting);
|
|
await waitFor(() => expect(screen.getByRole('radio', { name: 'Off' })).toBeChecked());
|
|
expect(screen.queryByRole('radio', { name: '-18 LUFS' })).toBeNull();
|
|
expect(screen.queryByRole('switch')).toBeNull();
|
|
});
|
|
});
|