bvandeusen
3f61079c02
Replaces the single 5GB capBytes with independent Liked + Rolling budgets (5GB each default). Bucket = liked-ness, NOT CacheSource: a cached track currently in the liked set is charged to / evicted under Liked; everything else is Rolling. Storage-only dedup — it never filters playback (S4's offline lists query the whole index). - db.dart: schema 8→9, AudioCacheIndex.lastPlayedAt (real play recency for S4 + rolling LRU; migration backfills to cachedAt). drift codegen run. - cache_settings: likedCapBytes + rollingCapBytes (+ setters); old cache_cap_bytes key dropped, defaults reapply (not data loss). - audio_cache_manager: touch(); bucketUsage() counts orphan partials (LockCaching files never indexed) as Rolling so the cap truly bounds disk; evictBuckets() drains non-liked LRU then sweeps orphans, Liked only by its own (large) cap — normal use never evicts the user's liked library. - prefetcher → evictBuckets with the cached liked set. - storage_section: two cap selectors + per-bucket usage (folds in S3 to avoid a broken intermediate). - Explicit Download dropped: removed album + playlist Download buttons, autoPlaylist pins, now-unused imports. - Tests updated/compiled (drift-cohort tests are CI-skipped). High blast radius (eviction deletes files) — liked-protective by design; needs operator device-check before "done". Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
79 lines
2.8 KiB
Dart
79 lines
2.8 KiB
Dart
import 'package:flutter_riverpod/flutter_riverpod.dart';
|
|
import 'package:flutter_secure_storage/flutter_secure_storage.dart';
|
|
import 'package:flutter_test/flutter_test.dart';
|
|
import 'package:mocktail/mocktail.dart';
|
|
|
|
import 'package:minstrel/auth/auth_provider.dart';
|
|
import 'package:minstrel/cache/cache_settings_provider.dart';
|
|
|
|
class _MockStorage extends Mock implements FlutterSecureStorage {}
|
|
|
|
void main() {
|
|
setUpAll(() {
|
|
registerFallbackValue('');
|
|
});
|
|
|
|
test('returns defaults when storage is empty', () async {
|
|
final storage = _MockStorage();
|
|
when(() => storage.read(key: any(named: 'key')))
|
|
.thenAnswer((_) async => null);
|
|
when(() => storage.write(
|
|
key: any(named: 'key'), value: any(named: 'value')))
|
|
.thenAnswer((_) async {});
|
|
|
|
final container = ProviderContainer(overrides: [
|
|
secureStorageProvider.overrideWithValue(storage),
|
|
]);
|
|
addTearDown(container.dispose);
|
|
|
|
final s = await container.read(cacheSettingsProvider.future);
|
|
expect(s.likedCapBytes, CacheSettings.defaults.likedCapBytes);
|
|
expect(s.rollingCapBytes, CacheSettings.defaults.rollingCapBytes);
|
|
expect(s.likedCapBytes, 5 * 1024 * 1024 * 1024);
|
|
expect(s.prefetchWindow, 5);
|
|
expect(s.cacheLikedTracks, true);
|
|
});
|
|
|
|
test('setPrefetchWindow clamps to 1..10', () async {
|
|
final storage = _MockStorage();
|
|
when(() => storage.read(key: any(named: 'key')))
|
|
.thenAnswer((_) async => null);
|
|
when(() => storage.write(
|
|
key: any(named: 'key'), value: any(named: 'value')))
|
|
.thenAnswer((_) async {});
|
|
|
|
final container = ProviderContainer(overrides: [
|
|
secureStorageProvider.overrideWithValue(storage),
|
|
]);
|
|
addTearDown(container.dispose);
|
|
|
|
await container.read(cacheSettingsProvider.future);
|
|
final ctrl = container.read(cacheSettingsProvider.notifier);
|
|
await ctrl.setPrefetchWindow(99);
|
|
expect(container.read(cacheSettingsProvider).value!.prefetchWindow, 10);
|
|
await ctrl.setPrefetchWindow(0);
|
|
expect(container.read(cacheSettingsProvider).value!.prefetchWindow, 1);
|
|
});
|
|
|
|
test('setCacheLikedTracks toggles persisted', () async {
|
|
final storage = _MockStorage();
|
|
when(() => storage.read(key: any(named: 'key')))
|
|
.thenAnswer((_) async => null);
|
|
when(() => storage.write(
|
|
key: any(named: 'key'), value: any(named: 'value')))
|
|
.thenAnswer((_) async {});
|
|
|
|
final container = ProviderContainer(overrides: [
|
|
secureStorageProvider.overrideWithValue(storage),
|
|
]);
|
|
addTearDown(container.dispose);
|
|
|
|
await container.read(cacheSettingsProvider.future);
|
|
await container.read(cacheSettingsProvider.notifier).setCacheLikedTracks(false);
|
|
expect(
|
|
container.read(cacheSettingsProvider).value!.cacheLikedTracks, false);
|
|
verify(() => storage.write(key: 'cache_liked_tracks', value: 'false'))
|
|
.called(1);
|
|
});
|
|
}
|