Drift audit 2026-06-02 — 26 findings shipped #75

Merged
bvandeusen merged 11 commits from dev into main 2026-06-02 19:21:53 -04:00
Showing only changes of commit 305d4780ac - Show all commits
+6 -8
View File
@@ -66,15 +66,13 @@ func TestGcCloseStalePlayEvents_ClosesOnly24hOldRows(t *testing.T) {
// Need a track + session to satisfy FKs on play_events.
var trackID pgtype.UUID
if err := pool.QueryRow(ctx, `
INSERT INTO artists (name) VALUES ('A') RETURNING id
`).Scan(new(pgtype.UUID)); err != nil {
t.Fatalf("seed artist row: %v", err)
}
// Get the just-inserted artist id.
var artistID pgtype.UUID
if err := pool.QueryRow(ctx, `SELECT id FROM artists WHERE name = 'A'`).Scan(&artistID); err != nil {
t.Fatalf("read artist: %v", err)
// `artists` has sort_name NOT NULL; mirror the title in sort_name
// like every real insert site does (see api.search / library scan).
if err := pool.QueryRow(ctx, `
INSERT INTO artists (name, sort_name) VALUES ('A', 'A') RETURNING id
`).Scan(&artistID); err != nil {
t.Fatalf("seed artist row: %v", err)
}
var albumID pgtype.UUID
if err := pool.QueryRow(ctx, `