From f080afc38c60a04636d66db177146b7368b9c53e Mon Sep 17 00:00:00 2001
From: Bryan Van Deusen <bryan.vandeusen@fabledsword.com>
Date: Mon, 1 Jun 2026 16:55:29 -0400
Subject: [PATCH] fix(android): remove WorkManager auto-initializer
 (lintVitalRelease)

The android.yml release build (run 110, job 282) failed at
lintVitalRelease with:

  AndroidManifest.xml:13: Error: Remove androidx.work.WorkManagerInitializer
  from your AndroidManifest.xml when using on-demand initialization.
  [RemoveWorkManagerInitializer from androidx.work]

MinstrelApplication implements androidx.work.Configuration.Provider
and supplies the HiltWorkerFactory, so WorkManager initializes
on-demand at first WorkManager.getInstance(...) call. The androidx-
startup InitializationProvider that ships with the work-runtime
library still auto-registers WorkManagerInitializer, racing the
on-demand path. Lint catches this as a release blocker.

Fix: merge the InitializationProvider entry and remove the nested
WorkManagerInitializer meta-data with tools:node='remove'. This is
the AOSP-recommended fix when an Application is its own
Configuration.Provider.
---
 android/app/src/main/AndroidManifest.xml | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/android/app/src/main/AndroidManifest.xml b/android/app/src/main/AndroidManifest.xml
index fec18bc4..67f4e408 100644
--- a/android/app/src/main/AndroidManifest.xml
+++ b/android/app/src/main/AndroidManifest.xml
@@ -50,5 +50,21 @@
                 android:name="android.support.FILE_PROVIDER_PATHS"
                 android:resource="@xml/file_paths" />
         </provider>
+
+        <!-- On-demand WorkManager initialization: MinstrelApplication
+             implements Configuration.Provider and supplies the
+             HiltWorkerFactory. Remove the default startup-driven
+             initializer so WorkManager picks up our config instead of
+             auto-initializing with the wrong factory. lintVitalRelease
+             flags this as a fatal error if left in place. -->
+        <provider
+            android:name="androidx.startup.InitializationProvider"
+            android:authorities="${applicationId}.androidx-startup"
+            tools:node="merge">
+            <meta-data
+                android:name="androidx.work.WorkManagerInitializer"
+                android:value="androidx.startup"
+                tools:node="remove" />
+        </provider>
     </application>
 </manifest>
-- 
2.52.0