bvandeusen/minstrel
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 38 Wiki Activity

fix(docker): bump builder to go 1.25 to match go.mod #60

Merged
bvandeusen merged 1 commits from dev into main 2026-06-01 16:13:43 -04:00
Conversation 0 Commits 1 Files Changed 1
+1 -1
bvandeusen commented 2026-06-01 16:13:37 -04:00
Owner
Copy Link
Copy Source

Fast-follow on PR #59. The merge to main triggered release.yml run 107 which failed at go mod download with:

go: go.mod requires go >= 1.25.0 (running go 1.23.12; GOTOOLCHAIN=local)

The M7/M8 batch bumped go.mod to go 1.25.0 but the Dockerfile's builder stage still pinned golang:1.23-bookworm. Bumping to golang:1.25-bookworm matches.

No CI paths trigger on Dockerfile changes (correctly — the Dockerfile only matters at image build time), so this PR will go in unverified at the lint/test level; the verification is the next release.yml run on main going green.

After merge I'll force-move v2026.06.01 to the new main HEAD so the image tag rebuilds cleanly.

Fast-follow on PR #59. The merge to main triggered `release.yml` run 107 which failed at `go mod download` with: ``` go: go.mod requires go >= 1.25.0 (running go 1.23.12; GOTOOLCHAIN=local) ``` The M7/M8 batch bumped `go.mod` to `go 1.25.0` but the Dockerfile's builder stage still pinned `golang:1.23-bookworm`. Bumping to `golang:1.25-bookworm` matches. No CI paths trigger on Dockerfile changes (correctly — the Dockerfile only matters at image build time), so this PR will go in unverified at the lint/test level; the verification is the next `release.yml` run on main going green. After merge I'll force-move `v2026.06.01` to the new main HEAD so the image tag rebuilds cleanly.
bvandeusen added 1 commit 2026-06-01 16:13:37 -04:00
fix(docker): bump builder from go 1.23 to 1.25 (matches go.mod) 3bcc7f3eb3 
The release.yml build on main HEAD c0185357 failed with:
  go: go.mod requires go >= 1.25.0 (running go 1.23.12; GOTOOLCHAIN=local)

go.mod was bumped to 1.25.0 during the M7/M8 batch but the
Dockerfile's builder stage still pinned golang:1.23-bookworm. Bump
to golang:1.25-bookworm to match.
bvandeusen merged commit 9ff1b30e3f into main 2026-06-01 16:13:43 -04:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
deps
Dependency update (Renovate)
 deps:major
Major dependency bump — held for manual review
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
bvandeusen
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: bvandeusen/minstrel#60
Delete Branch "dev"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?