Queue row gestures: album art as grab surface + swipe-to-remove #118
No Assignees
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: bvandeusen/minstrel#118
Reference in New Issue
Block a user
Android queue row gesture work. Web is untouched by design.
#2395 — album art is the grab surface
6dea45a6The reorder grip no longer occupies its own column. On Android it's gone entirely (long-press-drag the row); on web it sits over the album art, so it costs no horizontal space while staying visible at rest as the only affordance signalling the list is reorderable.a92a9f21Extracted the reorder accessibility actions to clear detektLongMethod.#2435 — swipe left to remove
1910a5ceReplaces the Android X button withSwipeToDismissBox. End-to-start only (enableDismissFromStartToEnd = false) — a right-swipe has no meaning here and leaving it live would delete tracks on a gesture aimed either way. The revealed background is oxblood (LocalActionColors.destructive, notcolorScheme.error— the design system keeps "a failure that happened" apart from "an action about to happen") with a trash glyph and the word "Remove".CustomAccessibilityAction("Remove from queue"). Both of the row's gestures are now touch-only, and each replaced a control TalkBack could find; without this, dropping the X would have quietly removed remove-from-queue for anyone not using touch.8b630e71detektTooManyFunctions(12 vs 11) forced a split —QueueRow.kttakes the row and its helpers,QueueScreen.ktkeeps screen/list/pill/summary. No behaviour change. Split rather than suppressed because the count was reporting something true: the file held a screen and a heavier row.Web keeps its X button per operator call — there's enough horizontal room there that the space argument doesn't apply.
Verification
CI green on
dev(run 3379: ktlint, detekt, unit tests). No instrumentation lane exists in this module, so the gestures themselves are operator on-device verification — see #2436 for the untested drag math.The grip icon took a column out of every queue row, competing with the title for space — worst on Android, where the row is narrowest and the icon plus its 12dp gap cost roughly 36dp. Operator pre-approved dropping the icon and making the album art the drag surface; that's what this does. ## Android: the gesture change is the load-bearing part Moved the drag from the grip onto the thumbnail AND switched detectDragGestures → detectDragGesturesAfterLongPress. That second half is not cosmetic. The grip was a small target, so a plain drag detector on it never competed with anything; a 48dp thumbnail is a large chunk of every row, and with a plain detector any vertical pan starting on artwork would be swallowed as a reorder instead of scrolling the queue. The list would have felt broken exactly where it's easiest to touch. Long-press-then-drag separates the three gestures: pan scrolls, long-press reorders, tap still plays (the detector doesn't consume a plain tap, so it reaches the row's clickable). Dropping the grip also removed its contentDescription ("Reorder track"), which was the ONLY thing telling a screen reader this list could be reordered — and a long-press drag isn't operable with TalkBack regardless. Added "Move up"/"Move down" custom accessibility actions on the row, the Android counterpart to the web row's ArrowUp/ArrowDown. Without them this change would have quietly removed reordering for anyone not using touch. ## Web: the grip was never the drag surface `use:draggable` is on the row, not the handle, so dragging already worked from anywhere — the grip's only unique jobs were being the visual cue and the keyboard target. It now sits OVER the art, costing zero horizontal space, and keeps both jobs. Deliberately still VISIBLE at rest, just quiet, with the scrim appearing only on hover/focus. Overlaying already solved the space complaint, so hiding it buys nothing and would cost the only cue that the queue is reorderable — on touch especially, which has no hover. ## Scope walked back Also considered the web PlaylistTrackRow, which carries an identical grip. Left alone: it has no album art, so the approved direction doesn't apply, and its handle is already the smallest of the three at 14px. Forcing consistency would have meant inventing a third treatment for a surface nobody complained about. (Android has no playlist reorder at all — that parity gap is pre-existing and out of scope here.) Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>