bvandeusen/minstrel
1
0
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases 41 Wiki Activity

Queue fix + cross-client queue enhancements #112

Merged
bvandeusen merged 9 commits from dev into main 2026-07-23 08:31:34 -04:00
Conversation 0 Commits 9 Files Changed 10
+414 -52
bvandeusen commented 2026-07-23 08:31:20 -04:00
Owner
Copy Link
Copy Source

Merges the queue fix + enhancement batch to main. All CI-green on dev (web run #535, Android run #537).

Fix

  • Web: clicking play did nothing (#1928) — QueueDrawer was rendered outside QueryClientProvider, so the queue LikeButton (added in #1596) threw "No QueryClient was found" the moment the queue populated on first play, aborting the reactive flush that starts playback. Moved the drawer inside the provider.

Queue enhancements (web + Android)

  • Queue opens scrolled to the now-playing track (#1929 Android, #1931 web).
  • Auto-follow the now-playing track as it auto-advances, with a "Jump to current" pill when the user has scrolled away.
  • Album-art thumbnails in queue rows.
  • Clear-queue action.
  • Android drag-to-reorder + per-row remove (closing the functional gap with web), plus a header count + total-time summary.

Heavy survey items (Up-Next sectioning, save-queue-as-playlist, multi-select) were intentionally scoped out.

🤖 Generated with Claude Code

Merges the queue fix + enhancement batch to `main`. All CI-green on `dev` (web run #535, Android run #537). ## Fix - **Web: clicking play did nothing** (#1928) — `QueueDrawer` was rendered outside `QueryClientProvider`, so the queue `LikeButton` (added in #1596) threw "No QueryClient was found" the moment the queue populated on first play, aborting the reactive flush that starts playback. Moved the drawer inside the provider. ## Queue enhancements (web + Android) - Queue opens scrolled to the now-playing track (#1929 Android, #1931 web). - **Auto-follow** the now-playing track as it auto-advances, with a **"Jump to current"** pill when the user has scrolled away. - **Album-art thumbnails** in queue rows. - **Clear-queue** action. - **Android drag-to-reorder + per-row remove** (closing the functional gap with web), plus a header count + total-time summary. Heavy survey items (Up-Next sectioning, save-queue-as-playlist, multi-select) were intentionally scoped out. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
bvandeusen added 9 commits 2026-07-23 08:31:21 -04:00
fix(player): render QueueDrawer inside QueryClientProvider so queue LikeButtons resolve — #1928
test-web / test (push) Successful in 40s
Details
f2dcf2596d 
The queue drawer's <aside> is always mounted, so QueueTrackRow's LikeButton
(added in #1596) instantiates the moment the queue populates on first play.
LikeButton calls useQueryClient() at init; with the drawer outside the
provider it threw 'No QueryClient was found in Svelte context', aborting the
reactive flush that starts playback — so play appeared to do nothing.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
fix(player): open Android queue scrolled to now-playing track — #1929
android / Build + lint + test (push) Successful in 4m8s
Details
41ebf1405b 
QueueList used a plain LazyColumn with no hoisted state, so the queue always
opened at the top and the current track could be off-screen. Seed a
rememberLazyListState with the current index (coerced into bounds) so the list
renders already positioned on the now-playing row — no post-layout scroll flash.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
feat(player): scroll web queue to now-playing track on open (Android parity) — #1931
test-web / test (push) Failing after 38s
Details
723293110d 
QueueList gains an `active` prop; when it flips true (drawer opens) or on mount
(now-playing panel) it centers the current row in view. Index/length are read
untracked so it positions once per open rather than following auto-advance,
matching the Android queue. QueueDrawer passes active={queueDrawerOpen} since
its aside is always mounted.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
test(web): no-op scrollIntoView in vitest setup (jsdom lacks it) — #1931
test-web / test (push) Successful in 33s
Details
2038028d42 
The queue auto-scroll $effect calls scrollIntoView on render, and jsdom
doesn't implement it, so QueueDrawer.test.ts threw an unhandled TypeError that
failed the run even though every assertion passed. Polyfill it as a no-op in
the shared setup; tests never assert on scroll position.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
feat(player): album-art thumbnails in web queue rows — #1944 0efbf5fcaa 
Adds a 40px cover thumbnail (coverUrl(album_id), FALLBACK_COVER on error) to
each queue row, matching the artwork every comparable player shows in its
up-next list.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
feat(player): web queue auto-follow + jump-to-current pill + clear-queue — #1944
test-web / test (push) Successful in 40s
Details
cde74b5965 
QueueList now follows the now-playing row as the track auto-advances (only
while it's in view), centers it on open, and surfaces a 'Jump to current' pill
once the user scrolls it off-screen. Header gains a clear-queue action backed
by a new store clearQueue() that empties the queue and stops playback.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
feat(player): queue move/remove/clear on PlayerController + VM — #1944 dc7b9b78fa 
Adds moveInQueue/removeFromQueue/clearQueue, each keeping the domain queueRefs
snapshot in lock-step with the Media3 timeline (mirrors playNext/enqueue). Media3
onEvents rebuilds uiState so the queue view reflects reorder/removal/clear.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
feat(player): Android queue — reorder, remove, art, auto-follow, clear — #1944
android / Build + lint + test (push) Failing after 1m26s
Details
509cbe79b2 
Queue screen gains: album-art thumbnails (ServerImage), drag-to-reorder via a
grip handle (offset->delta on release, mirroring the web), a remove button per
row, auto-follow of the now-playing track with a 'Jump to current' pill when
scrolled away, a clear-queue action, and a header count + total-time summary.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
fix(player): suppress TooManyFunctions on PlayerViewModel facade — #1944
android / Build + lint + test (push) Successful in 3m43s
Details
0774f5f55f 
Adding the queue move/remove/clear pass-throughs pushed the VM to 12 functions
(detekt cap 11). It's a thin transport facade forwarding to PlayerController, so
suppress with a rationale rather than splitting the delegating surface.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
bvandeusen merged commit a26ef4e93c into main 2026-07-23 08:31:34 -04:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
deps
Dependency update (Renovate)
 deps:major
Major dependency bump — held for manual review
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
renovate-bot bvandeusen
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: bvandeusen/minstrel#112
Delete Branch "dev"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?