8 Commits

Include renames

Author	SHA1	Message	Date
bvandeusenandClaude Opus 5	18a61f1065	fix(discover): complete the page-test mock + drop a return from returnsIn — #2375 ... Two CI failures from 6e39471a, both mechanical. web: src/routes/discover/discover.test.ts mocks $lib/api/suggestions with a factory, and SuggestionFeed now imports createSnoozesQuery from it. A factory-shaped module mock must export everything the component tree imports or rendering throws before any assertion runs — so all 12 of that suite's tests failed on a surface they don't even exercise. Stubbed the three new exports and defaulted the snooze query to empty, which keeps the feed's empty-state copy on the "no signal yet" branch those tests assert. (Same shape as Scribe #2109: when a shared component grows a dependency, the break is in unrelated fixtures, not assertions.) android: detekt ReturnCount — returnsIn had 3 returns against a limit of 2. Folded the two "nothing to state" guards into one by computing the remaining duration as a nullable up front. The Android compile and unit tests never ran on the last push: detekt gates them, so Lucide.Clock is still unproven. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>	2026-08-02 19:09:24 -04:00
bvandeusen	8f29cc7414	feat: poll in-flight requests on native + refresh after submit (#369) ... Native RequestsViewModel gains poll-while-approved (silent reloads, paused when nothing in-flight) for parity with the web auto-poll, and the SSE collector now reloads silently instead of flashing the loading spinner. Web discover submit invalidates qk.myRequests() so a new request appears on /requests immediately.	2026-06-06 23:18:44 -04:00
bvandeusenandClaude Opus 4.7	bb1ab3a2e3	test(web): un-skip discover/requests route tests — mock $app (#374) ... Root cause: discover.test.ts and requests.test.ts were the only route page tests NOT mocking $app/state (+ $app/navigation), so rendering the +page.svelte pulled in SvelteKit's client runtime and threw `TypeError: notifiable_store is not a function` at module load. They'd been describe.skip'd AND hard-excluded in vitest.config.ts. Fix mirrors every other route test: vi.hoisted pageState + vi.mock('$app/state', () => pageUrlModule(state)) + vi.mock('$app/navigation', () => ({ goto: vi.fn() })). Un-skip both describe blocks; drop the vitest.config exclude. The web test job now runs both suites again. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-05-19 15:42:11 -04:00
bvandeusenandClaude Opus 4.7	9acad5461e	refactor(web): extract emptyPlaylistsMock + apiClientMock test helpers ... The DRY pass audit (#375) found two inline mock patterns repeated across the vitest suite: a default empty-playlists mock for $lib/api/playlists (4 exact copies in menu/card tests) and an api-client spy mock for $lib/api/client (9 callers split between get-only and full-RESTy shapes — unified into one helper that always returns all four verb spies). Mirrors the existing test-utils/mocks/likes.ts and test-utils/mocks/quarantine.ts convention. Tests with intentionally divergent shapes (AddToPlaylistMenu's richer createPlaylist payload, PlaylistCard's getPlaylist, route-specific mocks, events.svelte's specific resolved value) stay inline. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>	2026-05-12 12:45:15 -04:00
bvandeusen	3e34f1f7b3	refactor(web/test): default svelte-query mock in vitest.setup; remove from 34 files (B3)	2026-05-08 11:08:41 -04:00
bvandeusen	40db918bfc	fix(web): RemoveTrackPopover async test waits + skip 2 SvelteKit-broken suites ... Three CI failures from the dev-push test-web.yml run. Two categories: 1. RemoveTrackPopover.test.ts — `confirm()` chains 5+ awaited invalidateQueries before onClose; the test's two `await Promise.resolve()` only flushed two microtasks. Switch to waitFor() so the assertion polls until the side effects land. Same fix on the success-cascade invalidation count test. 2. discover.test.ts + requests.test.ts — both fail at module-load with `TypeError: notifiable_store is not a function` deep in @sveltejs/kit's client.js. Surfaced only on the new dev-push workflow; PR-to-main runs were green. describe.skip with a FIXME pointing at the new triage task M7 #374. The pages themselves aren't broken — the test harness is.	2026-05-03 00:00:26 -04:00
bvandeusen	2f3326aee6	feat(web): suggestion feed on /discover (search-empty default)	2026-05-01 06:51:41 -04:00
bvandeusenandClaude Opus 4.7	8a12b8c571	feat(web): add /discover route with search + request flow ... Local-input + 250ms debounce drives Lidarr search; tab switch refetches with new kind. Track-kind Request opens a confirm modal explaining the album that will be added; Confirm fires createRequest, Cancel is a no-op. Successful requests flip the card to 'requested' optimistically. Shell nav now exposes /discover between Search and Playlists. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>	2026-04-29 22:15:52 -04:00