4 Commits

Include renames

Author	SHA1	Message	Date
bvandeusenandClaude Opus 5.5	08a2c06b85	docs: api comments say what the endpoints do, not how they came to be (#6277) ... Rewrites the internal/api comment blocks to rule 32: task, milestone and rule ids gone, the stories behind them restated as the constraint they left, stale references corrected (the stream secret is wired from config, the timezone handler already refreshes the scheduler, the Android app is the native client, the design docs cited are not in the repo). Also rewraps comment lines over 80 columns left by the earlier batches. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-23 12:23:58 -04:00
bvandeusen	47d2f61161	fix: drift audit batch 1 — six small mechanical wins ... Six findings from the 2026-06-02 multi-system drift audit (Scribe parent task #552): - **#553 (web)** Tailwind class fix: web admin playback-errors Delete confirm button was using `bg-action-danger`, an undefined token — swap to `bg-action-destructive` to match every other destructive button. Restored the Oxblood signal that distinguishes Delete from Cancel. - **#555 (web)** Type the `source` field on `play_started` in the EventRequest discriminated union. Server's eventRequest accepts it; web's TS type was missing the slot, so a "drop extra properties" refactor could silently strip the source tag and break system- playlist rotation attribution. - **#556 + #557 (server)** Coverage rollup whitelist was pinned to ('sidecar','embedded','mbcaa','theaudiodb'); migration 0020 added 'deezer' and 'lastfm' as valid cover_art_source values but those never got wired in, so albums with art from those providers silently counted as MISSING in the admin Coverage dashboard. The rollup test was seeding only the pre-0020 sources, masking the gap in CI. Extend the query to include deezer + lastfm; seed the test with one row per valid source (regression-guards future additions). - **#558 (web)** Auth gate was blocking /forgot-password and /reset-password/<token> — both are entered without a session by definition, so the email-link reset flow was bouncing signed-out users to /login. Add /forgot-password to the public set and a /reset-password/ prefix matcher. New tests assert both routes reach their pages without redirect. - **#571 (server)** Library scanner was indexing only .mp3/.m4a/.flac /.ogg while the stream handler (media.go) had been extended to serve .opus, .aac, and .wav. A user with .opus files in their library never saw them in artist/album listings because the scanner skipped indexing — silent data loss. Aligned the scanner to match the media handler. Scribe statuses updated to in_progress; flipping to done after the push since these are mechanical and verified directly against the cited file:lines.	2026-06-02 18:11:25 -04:00
bvandeusen	97cca4411a	chore(server/m7-coverage-gauge): align coverage test with peer style ... Code-review polish on admin_coverage_test.go: - Replace inline artist-seed SQL with the seedArtist helper used across the rest of the api test suite (admin_covers_test.go, likes_test.go, me_history_test.go, admin_quarantine_test.go). - Rename the cover_art_source pointer locals from none/sidecar/mbcaa to sourceNone/sourceSidecar/sourceMbcaa so they don't read like zero-value identifiers.	2026-05-06 10:08:58 -04:00
bvandeusen	a1d295ebac	feat(server/m7-coverage-gauge): GET /api/admin/library/coverage ... New admin handler returns the library-wide cover-art coverage rollup {total, with_art, pending, settled, pending_no_mbid} for the admin dashboard gauge. Always 200; zeros on empty library. Same RequireAdmin middleware as /api/admin/scan/status. Lives under a new /library/ admin sub-namespace, parallel to /scan/ (per-run state) and /covers/ (actions). Tests gated on MINSTREL_TEST_DATABASE_URL: empty library returns all zeros, mixed rows produce correct bucket math (verifying the with_art + pending + settled = total invariant), non-admin returns 403.	2026-05-06 09:54:56 -04:00