2146 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
bvandeusenandClaude Opus 5.5	598abeb8cf	fix: a fresh app install syncs the whole library, not the last 30 days of changes (#6778) ... The change feed dropped every row older than 30 days, and an app syncing from cursor 0 builds its library from the feed, so a fresh install, cleared data or a 410 reset got only what had changed lately. The compactor now keeps each entity's latest change however old. It drops a row once a newer one for the same entity exists, and a delete once it is 30 days old, raising a stored mark (library_changes_trimmed) past it; an app whose cursor is below the mark is sent back to 0, as before. Migration 0101 adds the index the compactor needs, seeds the mark where the old compactor left off, and gives every artist, album and track whose latest row is not an upsert a fresh one, so the rows the old compactor dropped come back. The backup carries the mark with the feed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-11-02 22:07:42 -05:00
bvandeusenandClaude Opus 5.5	ad48d8c8c9	fix: the route-registration test passes Mount its restart hook ... Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-11-02 20:25:39 -05:00
bvandeusenandClaude Opus 5.5	68e1e47534	fix: a new server takes a backup after its first scan, and restarts to load the restored settings (#6786) ... A one-off end-to-end run of the :dev image (scratch Postgres, generated FLAC files, no outbound network) found that the web restore, done the way docs/hosting.md describes, was refused with not_empty: a new server's startup scan fills the library before anyone signs up, and Restore counted tracks as occupied. The command-line restore passed the same run. - Restore now asks only that the instance has no accounts. The library the first scan found is replaced by the backup's (every foreign key into artists/albums/tracks cascades or sets null), and the restore locks the library tables so a running scan waits rather than adding to them. - Settings are read once at boot by about ten services, the library folders among them, so after a web restore the server ran on its defaults until restarted. The restore endpoint now answers, then asks the process to restart in place (syscall.Exec of the same binary, arguments and environment), which needs no container restart policy. The startup scan of the restarted server replaces the scan the endpoint used to start. - The restore form says Minstrel is restarting; the docs say a scanned new server still takes a backup. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-11-02 20:21:00 -05:00
bvandeusenandClaude Opus 5.5	a521326686	fix: the restore form's file picker isn't required, so the form submits once a file is chosen ... The Restore button already waits for a file. A required file input also kept jsdom from submitting after a test picked one. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-11-02 16:16:27 -05:00
bvandeusenandClaude Opus 5.5	29042e4eb2	feat: a new Minstrel restores a backup, from the web app or the command line, then rescans (#6775) ... A new server (no accounts, no library) offers "Restore a backup" beside "Create account". The file goes up as the request body to POST /api/auth/restore with the setup token from the log in X-Setup-Token, since the backup's admins become this server's. It loads in one transaction, then a library scan starts and finds each file at its path. The same load runs offline as `minstrel restore FILE`, which migrates the schema first. That path alone gets a 1 GiB, 15-minute body allowance instead of 4 MiB and 30s, and skips the JSON-only check for cookie writes: a stale cookie from the old server would otherwise refuse the upload, and the custom header already rules out a cross-site form. The library sync answers 410 cursor_ahead to a cursor past the last one the server has handed out, read from the change sequence, so an app synced with the old server after the backup was made starts over instead of skipping the ids the restored server reuses. Restore now leaves each sequence as having issued the restored maximum, so that reading holds; a compacted log still counts its handed-out cursors. backup.Read keeps the underlying error in its chain, so an oversized upload answers 413 rather than "not a backup". The hosting docs say how to put the music back first and what is entered again afterwards. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-11-02 16:10:06 -05:00
bvandeusenandClaude Opus 5.5	5090c89d20	fix: the backup panel test reads the music sizes as formatBytes prints them ... Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-11-02 15:35:58 -05:00
bvandeusenandClaude Opus 5.5	967763f6ce	feat: the backup can include the music, sending each library file once to music/ and again only when it changes (#6774) ... With "Include the music" on, each night's run sends the library files the destination doesn't hold yet, after the database file has landed, for up to six hours; a large library spans several nights the first time. Files keep their path under the library folders' common root, beside database/ in the same folder or bucket. backup_music_files records each file's size and mtime as sent, so a night sends only new and changed files, and a rescan that touches a track but finds the same file sends nothing. A changed file goes to its old name; Minstrel never deletes there. An object the bucket refuses (a locked overwrite) is kept with its answer and goes again once the file changes or the settings are saved; three refusals in a row stop the night's music, since that is a key that may not write under music/. A folder copy is written under a .part name and renamed, keeping the file's time. The panel shows how much of the library is in, the refused files, and each run's music count and note. The verdict still turns on the database file. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-11-02 15:26:20 -05:00
bvandeusenandClaude Opus 5.5	ff5ee755f2	fix: the backup test result says its count through plural(), and the panel tests read the size and folder field as shown ... Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-11-02 15:04:32 -05:00
bvandeusenandClaude Opus 5.5	f7222732e3	fix: the route test passes the backup service, and the backup panel narrows its status inside each column ... Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-11-02 14:56:26 -05:00
bvandeusenandClaude Opus 5.5	9d324ab2d0	feat: Minstrel backs itself up nightly to a folder or an S3 bucket, off until an admin switches it on (#6773) ... Admin › Backups shows a verdict first (off, not set up, waiting, backed up, overdue, failing since when), Back up now, Test destination and the latest runs, with the settings beside them. - backup.Service: one run at a time, bounded at 30 minutes; the schedule ticks every 5 minutes, catches up a slot missed while the server was down, and retries a failure after an hour and then after as long as it has been failing. Runs are recorded in backup_runs, pruned after 90 days; a run cut off by a shutdown is marked failed at the next start. - A folder destination writes database/minstrel-<UTC stamp>.tar and refuses a folder that isn't there. An S3 destination stages the file, hashes it, and uploads it under database/ through a throttled reader (4 MiB/s by default, 0 for no limit). - Test destination checks the form as typed and only lists. - The bucket secret is sealed like every stored credential; backup_settings and backup_runs are left out of the backup itself. - The panel polls only while a run is going, capped at the run limit plus five minutes. The music switch named in the task is left to #6774, so no control ships that does nothing. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-11-02 14:50:55 -05:00
bvandeusenandClaude Opus 5.5	faf19ef67b	test: the file-name test's later backup is later in UTC too ... Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-11-02 14:01:31 -05:00
bvandeusenandClaude Opus 5.5	e11011e977	fix: the backup package checks or explicitly drops every error the linter flags ... Closing a refused S3 response and a test file, and the fake bucket's writes, now say they ignore the error on purpose; handler parameters the tests don't use are named _. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-11-02 13:56:22 -05:00
bvandeusenandClaude Opus 5.5	b6ae205862	feat: Minstrel can put and list objects in a path-style S3 bucket, signed with SigV4 and no SDK (#6771) ... Bucket.Put stores a body under a key, signed over its SHA-256; Bucket.List pages through ListObjectsV2. A backup only adds and lists, so an append-only key is enough. Keys are encoded once, exactly as signed, so music paths with spaces, plus signs and accents reach the bucket intact. A refusal names S3's code in words ("the secret key is wrong"). The signer is pinned to AWS's published GET Object, PUT Object and ListObjects examples. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-11-02 13:51:02 -05:00
bvandeusenandClaude Opus 5.5	8be69b752a	feat: a backup is one uncompressed tar of per-table JSON Lines that stays the same bytes day to day (#6769) ... The file is minstrel-<UTC stamp>.tar: manifest.json first, then tables/<table>.jsonl, rows one per line in primary-key order. The run's time lives only in the manifest and member headers are fixed, so a deduplicating off-site copy stores unchanged tables once. WriteFile writes to a hidden .part file, syncs it and renames it, so a watched folder never shows half a backup. Read refuses anything that isn't a whole backup: another format, a newer format version, a cut-off file, or a member holding fewer rows than the manifest says. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-11-02 13:51:02 -05:00
bvandeusenandClaude Opus 5.5	a67897a6cd	feat: Minstrel can read its irreplaceable data out as JSON Lines and load it back into an empty instance (#6770) ... internal/backup names every table a backup holds, in parent-first order, and every table it leaves out with the reason: what the server computes from the music files, provider caches it fetches again, sign-ins and one-time links, and logs of past runs. The library's identity rows travel because every like, play and playlist entry hangs off a track id, and the sync change feed travels because the apps' first sync reads it. Sealed credentials are left out of the file, and so are the markers that say tag and art enrichment are done, so a restored server asks for the credentials again and redoes that work rather than believing it has it. Snapshot reads one REPEATABLE READ, read-only transaction, each table in primary-key order, keys sorted. Restore refuses an instance with accounts or tracks and a backup from a newer schema, replaces seeded settings, inserts by column intersection in batches, skips generated columns, and carries serial sequences on past the restored ids. Guards: every schema table is backed up or excluded; every backed-up table comes after what it references and references nothing excluded; every omitted column exists; a restore gives back the backup byte for byte. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-11-02 13:43:16 -05:00
bvandeusenandClaude Opus 5.5	a8a2d20307	feat: stored credentials are sealed at rest, so a copy of the database alone reveals none of them (#6767) ... Minstrel keeps credentials it has to read back: indexer, Prowlarr and download-client keys and passwords, the AcoustID key, cover-art and tag provider keys, the SMTP password, and each user's ListenBrainz token and Subsonic password. They were stored in the clear; they are now sealed with AES-256-GCM under a per-column HKDF key derived from the stream secret, each value bound to its row. - internal/secret: Seal/Open/Reveal, and Columns, the one list of sealed columns (a backup will leave them out). Install takes the master key at startup; SealStored seals any value still in the clear, so an existing database is brought over in place on the first boot. - Every write seals and every read opens: acquire (one read path, getService / usableServices), acoustid settings, SMTP, ListenBrainz, Subsonic auth and password generation, cover-art and tag provider settings. - A value that does not open (the stream secret changed) is logged and reads as unset, to be entered again in Settings. docs/security.md says so. - Tests: secret unit tests (wrong owner/purpose/key, malformed, no key), a SealStored integration test over all eight columns plus a schema check that each listed column exists, and the existing tests now assert sealed storage. dbtest installs a test key for integration tests. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-11-02 13:23:19 -05:00
bvandeusenandClaude Opus 5.5	be642cd53f	ci: main builds and bundles its own signed APK, so a merge ships the app without a release (#6465) ... android-release now runs on main as well as dev and tags, and image-release requires its success on every ref. :latest carries the stable APK built from main's own commit instead of the newest release's, so a merged app change reaches stable phones on the next pull. Releases stay as optional bookmarks that attach the APK for download. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-26 12:49:39 -04:00
bvandeusenandClaude Opus 5.5	7d5dcd454e	docs: two comments state the rule rather than its history (#6277) ... Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-26 11:20:17 -04:00
bvandeusenandClaude Opus 5.5	3fa5d9fc3a	fix: an app update is offered only when the app changed; casting no longer sticks on "loading" when the same queue plays again (#6455, #6456) ... ci/version.sh --apk names the APK from android/ alone, and the APK lane calls it. The app offers an update when the server's APK name differs from its own, so a name derived from the whole repo offered every phone a rebuild of the app it already had on each server-only deploy. The image keeps the union set: it bundles the APK under client/. Casting (#6456): - setMediaItems with the tracks already queued (play the queued album from another track) cleared the cast and waited for a resync that the id-keyed collector never ran. It is now a move within the queue: Seek TRACK_NR on a Sonos, start that track on a one-track renderer; the play() goes through. - A queue replaced through setMediaItems could take the Sonos incremental diff, which cleared target without restoring active, so the app thought it was back on the phone while the speaker played on, and the chosen start track was ignored. The diff now runs only while the route is still active; a replaced queue reloads in full at its start index. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-26 10:08:02 -04:00
bvandeusenandClaude Opus 5.5	fa75bd08d7	feat: a newer app is told in a snackbar on Home and installed from a sheet holding Settings' card, fetched ahead on Wi-Fi (#6452) ... Mirrors Librarian (#6446, #6448), after Gallery's update tray (canon #6367). - Home shows "Version X of the app is on your server." / "…is downloaded and ready." with Update / Install; the button opens a bottom sheet holding the same About card Settings shows, so there is one install path. Each build is told at most once a day, kept on disk. - The shell-wide update banner and its in-memory dismissals are gone. - AppUpdates (singleton) holds the offer and the install, so Home and Settings show the same state. Checks run when either screen opens, on every return to the front, every 5 minutes while shown, and on Home's pull to refresh. - UpdateFetchWorker downloads the newer APK ahead on an unmetered network (battery and storage not low, three tries); the download writes a .part file and keeps it under the build's name only once its size and sha256 match, so Install is usually one tap. - Back from allowing installs, the update the listener asked for carries on (kept in SavedStateHandle) instead of asking them to tap again. - An offer needs a higher code AND a different name: the same app built again at a later minute is not offered. - Server: /api/client/version reports the APK's sha256, worked out from the served file and cached by size and mtime. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-26 07:46:01 -04:00
bvandeusenandClaude Opus 5.5	de41169ccb	fix(android): detekt — no four-way destructuring, single-track loader within the function cap (#6451) ... The library-duration fallback rides on the poll outcome instead of being its own member, and the adopt path reads the target's fields by name. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-26 07:46:01 -04:00
bvandeusenandClaude Opus 5.5	b1e55adc14	feat(android): any UPnP/DLNA renderer plays, not only a Sonos (#6451) ... Discovery already listed every MediaRenderer on the LAN, but playback only spoke the Sonos native queue (AddURIToQueue, x-rincon-queue, Seek TRACK_NR, Next/Previous), which a generic renderer faults on, so picking one fell straight back to the phone. A renderer that isn't a Sonos is now fed one track at a time by SingleTrackLoader: SetAVTransportURI + Play for the current track, and SetNextAVTransportURI for the one after it so the renderer moves on by itself without a gap. A renderer without SetNext is advanced by the app when the poll sees it stop (or report NO_MEDIA_PRESENT) at the end of a track; a stop partway is still the stall watchdog's. ActiveUpnp carries the queue mode, picked from the route at select. Skip, previous and queue taps point a one-track renderer at the cursor's track, the poll takes the queue position from the loader instead of the renderer's Track=1, queue changes keep the playing track and re-arm the next, and adopting a running session matches by track id. Sonos keeps its native queue unchanged. DIDL-Lite drops the Rincon metadata for non-Sonos renderers and declares DLNA.ORG_OP=01 so renderers that need it will seek. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-26 07:38:29 -04:00
bvandeusenandClaude Opus 5.5	5dc6aa9c2f	feat(android): Storage shows the Liked songs and Recently played budgets (#6309) ... Two cap selectors, each with its usage, and a "Keep liked songs offline" switch replace the single cache limit and its next-launch caveat; caps apply at once. Docs that said the liked bucket did not exist are restated, and the audio-cache index's unused per-source eviction queries are deleted: eviction follows the liked set, not the index's source column. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-23 15:23:49 -04:00
bvandeusenandClaude Opus 5.5	ec1e59921b	feat(android): liking a track downloads its audio into the Liked budget on Wi-Fi (#6308) ... LikedAudioPinner downloads liked tracks' whole audio when "Keep liked songs offline" is on: most recently liked first, one at a time, only on an unmetered network while the server is reachable, and only while the Liked budget has room for another track at CD bitrate, so it never pushes out liked audio already on the phone. Tracks liked before this ships are covered by the same pass. Any change (a like, an unlike, the switch, the network) restarts the pass and cancels a download in flight. Supporting changes: - ConnectivityObserver.unmetered: the default network's NOT_METERED bit. - Liked track ids are read newest first, and refreshIds stamps the server's newest-first order into likedAt. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-23 15:23:49 -04:00
bvandeusenandClaude Opus 5.5	7ec8a82871	feat(android): the audio cache keeps a Liked songs budget and a Recently played budget (#6307) ... SimpleCache ran one LRU evictor at the rolling cap, so liked audio was dropped like anything else and the offline Liked pool shrank as other music played. TwoBucketCacheEvictor replaces it: - a span counts against Liked when its track is liked, else Recently played; a liked track that is also played is charged to Liked only; - each budget has its own cap (0 = unlimited) and drops its own least-recently-used audio first; - CacheBudgetSync feeds it the signed-in user's liked ids and the Storage caps, so a like, an unlike or a cap change applies at once; - nothing is evicted until the liked set is known, so startup never trims liked audio as Recently played. The decisions live in a Media3-free BucketLedger with unit tests. CacheConfig and PlayerModule, which only snapshotted the caps at launch, are gone. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-23 15:16:36 -04:00
bvandeusenandClaude Opus 5.5	b61474744b	chore(android): delete the unread deprecated FabledSwordTokens alias (#6295) ... UI code reads LocalFabledSwordTheme.current; nothing referenced the dark-bound alias. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-23 14:23:55 -04:00
bvandeusenandClaude Opus 5.5	1aba1a41e6	fix(tracks): removing a track writes a track_remove audit row (#6294) ... RemoveTrack took the admin's id and dropped it, so a merge left an audit trail and the more destructive removal did not. It now reads the track's title, artist, album and file path before the delete and writes them, with whether the album and artist went too, under the new track_remove action. The audit action groups lose their plan-era U1/U2/U3 headings. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-23 14:16:41 -04:00
bvandeusenandClaude Opus 5.5	0d0b04bff0	test(subsonic): album-list fixture users carry distinct api token hashes (#6293) ... users.api_token_hash is unique, so the second seeded user needs its own. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-23 14:05:45 -04:00
bvandeusenandClaude Opus 5.5	f3b124f9b2	feat(subsonic): getAlbumList2 recent and frequent read the caller's play history (#6293) ... type=recent orders the caller's albums by their latest play (skips included); type=frequent orders them by completed plays (skips excluded). Plays of tracks whose file is gone do not count, and both page by size/offset like the other types. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-23 13:58:09 -04:00
bvandeusenandClaude Opus 5.5	09e78962b2	fix(subsonic): getUser answers an admin's lookup with the requested user (#6292) ... An admin asking for another username got their own name and roles back. The handler now looks the user up by exact username and answers with that user's payload; an unknown username is ErrDataNotFound. A non-admin asking about someone else is still ErrNotAuthorized. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-23 13:58:09 -04:00
bvandeusenandClaude Opus 5.5	466912e202	docs: plan-era "v1", "Task N" and "Phase N" wording restated as facts (#6277) ... The marker list behind the earlier server and web passes did not catch "for v1", "Task 5", "Phase 2" or "today: Flutter". Those comments now say what the code does. Corrected: coverart said "both v1 providers" ship on. There are four providers (MBCAA, TheAudioDB, Deezer, Last.fm), and Last.fm, which needs a key, ships off. Non-comment tokens unchanged against HEAD: 10 Go files, 7 TS/Svelte files. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-23 13:05:03 -04:00
bvandeusenandClaude Opus 5.5	c96231106f	docs: setup files and the client, shared and CI docs describe what is (#6277) ... .dockerignore, .gitignore, deploy/initdb, ci-requirements.md, client/README.md, shared/README.md and two web/scripts test names: dates, issue/rule/spike ids and the stories behind each exclusion removed. Corrected: - client/README.md: the dev lane bundles its own APK; :main no longer exists; main bundles the recorded sidecar instead of re-deriving the version name. Its smoke-test step wrote a bare "v0.2.0", which the server rejects as a sidecar that is not JSON; it now writes the JSON shape, which the README documents. - ci-requirements.md: one workflow, not four; the android lane builds no debug APK; main reads the recorded sidecar. - .gitignore: CI fills client/ on every image build, not tag releases only. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-23 13:04:02 -04:00
bvandeusenandClaude Opus 5.5	557887bb07	docs: workflow, Dockerfile and brand-tool comments say what each does (#6277) ... release.yml, the Dockerfile and tools/gen-brand-assets.py keep every constraint their comments explain (the tag map, the gate, immutable tags, the shared-daemon Postgres guard, the version/channel split) and drop the history around them: rule and family-idea numbers, issue and run ids, dates, an operator quote, the "this used to say the opposite" paragraphs and one-runner timings. Corrected: the Dockerfile said client/ is filled on tag pushes only; every build fills it (dev and tag push bundle their own APK, main bundles the latest release's). Only full-line `#` comments changed: non-comment lines are identical to HEAD in all three files, and the three run: scripts whose text changed differ only in shell comment lines. The release guard tests match raw workflow text; none of their required or forbidden strings appear in the new comments. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-23 13:01:39 -04:00
bvandeusenandClaude Opus 5.5	ae7e05c579	docs: Android comments say what the app does, not how it came to be (#6277) ... Every flagged comment block in the Android app, its tests and its XML/TOML config, rewritten with the cited issue in view: the constraint is kept, the story behind it dropped, and issue, milestone, rule, phase and drift ids, dates and operator quotes removed. "Mirrors the Flutter client's X" pointers are gone; that client is no longer in the repo. Comments that no longer matched the code, corrected: - SyncController: a 410 resets the cursor and re-pulls; it never dropped the three local caches. - PlayerFactory, PlayerModule, AudioCacheIndexEntity, CacheConfig, CacheSource: there is no eviction worker and no liked-track bucket; SimpleCache evicts by plain LRU over the rolling cap, and the liked cap is stored but unenforced. - CacheSettings, StorageCard: the prefetcher exists (AudioPrefetcher); pin-on-like still does not. - LibraryApi, LibraryRepository, BrowseViewModel: the cache now carries the missing-file mark; the browse indexes stay server-backed for one source of grouping. - OutputRoute: UPnP routes exist; only CAST and SONOS are reserved. - PlayerFactory, RemotePlayerState, OutputPickerController: a failed transport command does not drop the UPnP route. - LibraryScreen: History, Liked and Hidden are real tabs, not placeholders. - AVTransportClient: the extend loop lives in SonosQueueLoader. - "the operator" meaning the listener now says "the user". Verified with a Kotlin lexer comparing every file's non-comment tokens against HEAD: 394 files, 0 differences. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-23 12:59:07 -04:00
bvandeusenandClaude Opus 5.5	9f588b6d61	docs: the history phrases the id sweep missed, restated as present-tense facts or traps (#6277) ... A wider pass for "previous", "before the fix", "we shipped" and the like. The chi double-subtree, uppercase Vorbis key and stopPropagation comments now describe the trap they guard; commit hashes, CI run numbers and a deleted file name are gone; uuidString's comment says what it returns. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-23 12:43:11 -04:00
bvandeusenandClaude Opus 5.5	10d50dccbd	docs: web comments say what the app does, not how it came to be (#6277) ... Rewrites the web app's comments to rule 32. Task, milestone, rule and spec ids are gone; regression stories are restated as the trap they guard (public auth routes, the menu's stopPropagation, universal loads under adapter-static, metric deltas with their margin). Flutter and Tauri mentions now name the Android app or a native shell, operator quotes and dates are dropped, and one library's counts no longer appear outside test fixtures. Verified with a TypeScript-scanner token comparison (template literals and regex literals re-scanned): only comment text changed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-23 12:42:12 -04:00
bvandeusenandClaude Opus 5.5	6028d78844	docs: migration headers keep the before and after, without ids, quotes or one library's numbers (#6277) ... Applies rule 32's migration exception: each header still says what the schema was, what changes and what it prevents, but task, milestone, decision and rule ids are replaced by the practice they stood for, the operator quotes by the decision, single-install counts are dropped, and pointers to a deleted package and an external design doc are gone. golang-migrate keeps no checksum, so editing applied migrations' comments is safe. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-23 12:34:39 -04:00
bvandeusenandClaude Opus 5.5	1d4ef1a23f	docs: query comments say what each query selects and why, not how it came to be (#6277) ... Rewrites the internal/db/queries comments to rule 32 and regenerates dbq, whose doc comments and embedded SQL carry them. The bugs behind the tiered mixes, the md5 order seed, the score bands and the round-robin arms are restated as the constraint each one enforces; counts from one library and stale cross-references are gone. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-23 12:31:13 -04:00
bvandeusenandClaude Opus 5.5	7e6228c13f	docs: library comments say what the scanner and resolver do, not how they came to be (#6277) ... Rewrites the internal/library comment blocks to rule 32. Task, milestone, decision and rule ids are gone; the incidents behind them are restated as the constraint they left (why a file is deleted before its row, why the missing mark is a mark, why duplicates block on duration). Counts and album names from one library are dropped from production comments; test comments keep the names their fixtures use. The tagReadVersion log keeps each version's before and after, without the measurements. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-23 12:27:34 -04:00
bvandeusenandClaude Opus 5.5	08a2c06b85	docs: api comments say what the endpoints do, not how they came to be (#6277) ... Rewrites the internal/api comment blocks to rule 32: task, milestone and rule ids gone, the stories behind them restated as the constraint they left, stale references corrected (the stream secret is wired from config, the timezone handler already refreshes the scheduler, the Android app is the native client, the design docs cited are not in the repo). Also rewraps comment lines over 80 columns left by the earlier batches. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-23 12:23:58 -04:00
bvandeusenandClaude Opus 5.5	fcf5b7e5a8	docs: wanted, dbtest, recommendation and playlists comments say what the code does (#6277) ... The same rewrite as d191a282, for four packages whose comments carried the most history: tuning stories, quotes from the operator, single-install measurements in library_scale.go, and 'used to' accounts of bugs. The constraint each story protected stays as a present-tense reason (why tier 3 is reduced not removed, why the randomised arms take an order seed, why the seed artist is eligible in Songs-like). Comments naming system_cron.go and config.RecommendationConfig, neither of which holds what they claimed, now name the scheduler and internal/recsettings. Checked: non-comment tokens identical to HEAD; gofmt clean. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-23 12:19:15 -04:00
bvandeusenandClaude Opus 5.5	d191a28217	docs: server comments say what the code does, not how it came to be (#6277) ... Comment blocks in cmd/minstrel and 30 smaller internal packages, rewritten to rule 32's standard with each citation read in context: task, milestone and rule ids go, and so do the stories they were attached to ("used to", "Before #N", measurements from one install, quotes, pointers to Fabled Librarian's records and to docs/superpowers files that are not in the repo). Where a story wrapped a real constraint, the constraint stays as a present-tense fact. Comments that had gone stale are corrected: - taste.Config: the tuned values are overlaid by internal/recsettings; it is no longer "a later follow-up". - StorageConfig: the data dir holds art, caches and the stream secret, not only playlist covers. - the Subsonic album list and getUser comments describe what they do today rather than a milestone that would change it. Checked: the non-comment token stream of every changed file matches HEAD, and gofmt -l is empty. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-23 12:15:05 -04:00
bvandeusenandClaude Opus 5.5	9f9609591d	docs: README in the standard order; setup files say what works today (#6277) ... README: logo header, short summary, a compose quick start with one-line comments, first-run steps, a configuration table, setup pitfalls, updating and backups, then features grouped by what you do. The Specs section (it called the Android client the "Flutter companion app"), the dated tag-history sentence and the Fable pointer are gone. Feature lines were checked against the code: radio seeds from a track only, and the Android app plays from its cache rather than offering downloads. .env.example used the SMARTMUSIC_ prefix, which the config loader has not read for a long time, so copying it set nothing. It now uses MINSTREL_. config.example.yaml is also the config the image bakes in at /etc/smartmusic/config.yaml. It listed five recommendation weights (base_weight, like_boost, recency_weight, skip_penalty, jitter_magnitude) that moved to Admin > Tuning; yaml.Unmarshal ignored them silently. They are removed, and the file parses to exactly Default(), so the running server is unchanged. coverart_from_mbcaa is not listed: nothing reads it. docker-compose.yml, the Makefile and the spec banners lose their task and milestone ids. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-23 12:02:25 -04:00
bvandeusenandClaude Opus 5.5	eac320c8d7	test: the notifications view model is built inside each test, after the test Main dispatcher is set (#6275) ... Built as a property initializer it ran at class construction, before MainDispatcherExtension's beforeEach, so viewModelScope.launch in init hit the missing Main dispatcher. Its uncaught exceptions also failed the next coroutine test in the JVM (RetryTransientIoTest). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-23 09:49:22 -04:00
bvandeusenandClaude Opus 5.5	f381622d20	feat: opening the notifications inbox marks what it shows as read (#6275) ... The web panel and the Android Notifications screen now mark every unread notice they show as read the moment they appear, so the badge clears on a look instead of a dismissal. Rows that were unread keep looking new until the inbox closes. The read goes through read-all with a cutoff of the newest notice shown plus 1 ms, so one that arrived unseen stays unread. 'Mark all read' is gone; opening the inbox does its job. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-23 09:41:37 -04:00
bvandeusenandClaude Opus 5.5	4756e957ce	docs: the shutdown comments say what happens, without the task number ... Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-23 09:41:37 -04:00
bvandeusenandClaude Opus 5.5	79b90bda03	fix: shutdown ends the live-event streams so a redeploy drains instead of waiting out its deadline (#5293) ... http.Server.Shutdown waits for in-flight requests but never cancels them, and an SSE stream only ends when its client leaves, so any open tab or signed-in phone held every redeploy for the full 10s and the old task exited 1. With the swarm's stop-first update that was ~10s of downtime per deploy. The bus now closes on shutdown, ending each stream; clients reconnect to the next instance. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-23 06:46:18 -04:00
bvandeusenandClaude Opus 5.5	fefc51439e	fix: Android's admin requests names who asked from the request itself (#6267) ... The admin requests list now sends each requester's username (#6265), so the Android queue reads it off the row instead of fetching the whole admin users list alongside and mapping ids to names. The short id stays as the fallback for a row that comes back without a name. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-22 21:10:17 -04:00
bvandeusenandClaude Opus 5.5	687a7cf3ee	test: the admin requests list test names the requester by their seeded username (#6265) ... seedUser stores users as test-<name>, so the assertion compares against alice.Username rather than the literal "alice". Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-22 20:49:54 -04:00
bvandeusenandClaude Opus 5.5	c98bd359f7	fix: the admin requests list names who asked, not a cut-off user id (#6265) ... /admin/requests showed "by user f7e1ec86" — the first eight characters of the requester's id, a placeholder from the first build. The admin list now sends each requester's username, looked up for the whole page in one query, and the row reads "by <username>". The id stays as the fallback for a list that comes back without names. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-22 20:43:18 -04:00