16 Commits

Include renames

Author	SHA1	Message	Date
bvandeusenandClaude Opus 5.5	b9684e6d12	fix: a group of one recording in several slots is settled by getting the album again, not merged (#6184) ... The duplicates review offered only Merge for a wrong-slot group. A merge keeps one copy's title whether or not it is the audio's, and neither sets the release aside nor wants the missing song back. For class mismatch the page now asks which song the recording is. "Get it again" (the operator can't tell) removes every copy; "Keep <title>" keeps that copy and removes the ones under other titles. Either way it runs the resolver's own path: the release the files came from is set aside, the removed copies' tracks stay marked missing and emptied, and the album is wanted again. - library.SettleWrongSlot, POST /api/admin/library/duplicates/{id}/refetch - ListDuplicateGroupsForResolve takes an optional group_id - removeWrongSlots takes the acting operator (manual: not automatic, actor in the audit row) and removes files through removeTrackFileOnDisk, so a read-only library answers library_not_writable Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-21 13:47:43 -04:00
bvandeusenandClaude Opus 5.5	f32abc974f	fix: a duplicate fold never deletes a lossless copy for a lossy one, nor folds two versions (M498) ... The first album-copy fold pass on 2026-10-20 removed five FLACs (Måneskin Rush!, Weezer 2016) in favour of mp3s whose only edge was a recording MBID, and an explicit "Suite-Pee" for its clean version. ProposeSurvivor now ranks lossless before tag fit; tag fit still outranks file size, which is what the Humanz rips needed. The fold keys copies by their version words (title and file name), so a clean, live or instrumental copy holding the same title tag is linked, not folded. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-20 12:36:55 -04:00
bvandeusenandClaude Opus 5.5	09e74a57a2	feat: an album holding a song twice beside its single keeps one copy (#5401) ... A cross-release group was only ever linked, never merged, so an album that held the song twice among the releases kept both: Humanz has Saturnz Barz, Andromeda, We Got the Power and Garage Palace as its FLAC and a YouTube mp3, each beside the single. The resolver now merges an album's extra copies into its best (the one that is not a video rip, else ProposeSurvivor: lossless first) with ReplaceTrack, history and all, then links what is left as one song. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-20 11:55:23 -04:00
bvandeusenandClaude Opus 5.5	42e48efb79	fix: the duplicate resolver waits for a running scan, so a copy it removes is not marked present again (#6169) ... At boot the scan lists the library, the resolver removes wrong-slot copies and marks their tracks missing, then the scan reconciles from its list and marks them present: 7 of the 13 removed on 2026-10-20 15:00 read as present with no file, and would not be wanted back until a later scan. A pass now waits while a scan younger than StuckScanThreshold is in flight and tries again a minute later; a stuck run does not hold it up. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-20 11:04:46 -04:00
bvandeusenandClaude Opus 5.5	18d31e9cdd	feat: one recording cut to several songs' lengths is named by AcoustID; the copy in its slot stays, the rest go, and the release is set aside (#6169) ... Savant's Mortals held one recording as 16 of its 50 tracks, each trimmed to its own slot's MusicBrainz length, so the lengths could not say which slot was its own and every group waited for the operator. When a one-album mismatch is the same audio (identical, or fingerprints within 0.02) and every copy fits its own slot, the resolver asks what the recording is: the copies' own AcoustID lookups, or a fresh lookup of one copy (five a pass). The track list names each slot's recording; the copy in that slot is kept and the others removed, or every copy when the recording is in none of their slots or AcoustID knows none. AcoustID unreachable or answers in several copies' slots: the group waits. Whenever wrong-slot copies are removed, the download the files were imported from is set aside, so the album fetched again is not the same files. Albums imported before Minstrel downloaded anything have none. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-20 10:33:55 -04:00
bvandeusenandClaude Opus 5.5	c8e855ae4a	feat: the duplicate resolver fetches a missing album track list from MusicBrainz to decide a wrong slot, five albums a pass (M498) ... 20 of the 34 groups left for review had no cached track list for their album: the catalogue only reads one when the wanted list or the importer needs it. The resolver now asks catalogue.RefreshReleaseGroup for an album it must decide and the catalogue has never read, through the shared MusicBrainz pacer, at most five a pass (hourly). An unreachable MusicBrainz stops the pass's fetching; a group read and found empty is not asked about again. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-20 09:02:53 -04:00
bvandeusenandClaude Opus 5.5	0f58ebcd6c	feat: duplicates settle themselves: retitled copies across releases link, alike versions on one album are dismissed, and a file in another song's slot is removed so the album is fetched again (M498 #6159-#6162) ... The operator's library had 536 groups waiting for review, 2026-10-19. A sample showed most were one recording under two titles on two releases. - The headline and the Duplicates count leave out cross-release groups, which the resolver keeps and links: the headline read 3,479 when 536 needed review. - Any group spanning albums is cross_release and is linked as one song, whatever its titles say. Nothing is deleted. - One album, two versions named as such ("Lovesick (Instrumental)") and not byte-identical: a new class, distinct, dismissed by the resolver. - One album, one recording under different song titles (mismatch): the album's cached MusicBrainz track list decides. When exactly one slot's song is as long as the file and every other slot's song is clearly not, the other copies are removed and their tracks marked missing, so the reacquisition sweeper wants the album back. Otherwise the group stays for review. - The duplicates_found notice moves from the sweep to the resolver: it names only groups a pass first left for review. - Resolved automatically lists dismissals and wrong-slot removals beside merges. Migration 0094 adds 'distinct' to the class CHECK (rule 36). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-19 23:22:38 -04:00
bvandeusenandClaude Opus 5.5	854c307834	feat: notifications say what changed and alert once: a grouped notice names the tracks, grows without re-alerting, and a phone pile lists its titles (M542 #6146-#6151) ... - An update to a grouped notice keeps its arrival time and email state, so the phone and the email no longer go off again each time it grows. - Notices carry the names of what changed (newest ten), shown as three and "and N more": tracks still missing after the scan's move/replacement fold, duplicate groups new to a sweep, songs merged automatically, and the track and listener a playback error was for. - Duplicates found counts only the groups new to that sweep; playback errors count reports, not the unresolved total. - A scan failure says what stopped and links to Admin > Library. - Android: a pile of more than three alerts lists the newest five titles. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-19 22:44:19 -04:00
bvandeusenandClaude Opus 5.5	db15713798	refactor: the server says a count one way, words.Count, for notifications, a wanted match's reason and the duplicate resolver's activity line (M505 #5643) ... Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-11 16:18:50 -04:00
bvandeusenandClaude Opus 5.5	3a16732883	feat: Minstrel no longer talks to Lidarr: its connection, Delete via Lidarr and the unmonitor options are gone, and the track reports are plain quarantine (M502 #5525) ... Migration 0091 drops lidarr_config and renames the quarantine tables, types, indexes and the history column off the Lidarr name. The Integrations Lidarr card, the Reports "Delete via Lidarr" action, the merge and remove-track unmonitor options, the Lidarr audit actions and error codes go, on the server, web and Android. The README describes acquisition as it is now. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-11 13:48:20 -04:00
bvandeusenandClaude Opus 5.5	5306a261c1	feat: duplicates resolve themselves without Lidarr (M502 #5517) ... Lidarr is off, and with it the resolver had stopped merging: it only merged when Lidarr had said which copies it mapped. Minstrel is now the only program writing the library, so the rule is about the copies: - A song held twice on one album: the extra copies merge into the one whose tags fit best (then lossless, larger, older). - Across releases or under another title: when every copy but one is a video rip (held back, or named like one and not marked fine), the rips merge into the one that is not. - Clean copies on different releases are linked as one song, as before. - Anything else waits for the operator. Gone with Lidarr: release switches and their settle window, the unmapped-file read, the rip search, the merge guard and its 409/503, lidarr.Client's release methods, and duplicate_group_members.lidarr_state (migration 0078). The duplicates page drops the per-copy Lidarr badge and the blocked-merge notice; past release changes stay in its history. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-09 20:12:49 -04:00
bvandeusenandClaude Opus 5.5	e1ad1c9ba2	fix: a release change Lidarr applied but did not answer is recorded (M498) ... On the first deploy pass Lidarr took longer than the client's 30s timeout to answer the release change for Cracker Island: its album update unlinks the files and queues the rescan before it replies. The change may well have landed, but the resolver logged a failure and wrote no audit row, so the album had no settle window and the report did not show it. An unanswered PUT (ErrUnreachable) is now read back: when the album's monitored release is the chosen one, the change is recorded as made. Any other error, or a read-back that disagrees, stands as before. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-08 22:42:50 -04:00
bvandeusenandClaude Opus 5.5	e17556dce9	feat: Lidarr searches for a better copy of a rip that has none (M498 #5447) ... The operator chose option 2: an album holding a video rip that is the only copy of its song is searched in Lidarr (AlbumSearch), at most once a week and ten albums a pass. Lidarr grabs only when the quality profile allows an upgrade, so nothing is removed and the rip stays held back either way. - lidarr.Client.SearchAlbums posts the AlbumSearch command. - ListAlbumsWithSoleCopyRips finds the albums: a held-back rip with no present clean copy sharing its song or its pending group, and not searched in the last week (audit action lidarr_rip_search). - Suspect sources shows when Lidarr last searched the track's album. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-08 22:32:30 -04:00
bvandeusenandClaude Opus 5.5	53eb954c86	feat: video rips and stray copies handle themselves (M498 #5439) ... - The resolver also merges cross-release and mismatch groups where Lidarr maps exactly one copy: the others fulfil nothing, so removing them opens no hole (D-a rule 1). That covers a rip beside the clean copy on another release and a wrong-file import Lidarr holds unmapped. With two or more mapped copies each fulfils its own release and nothing is removed. - A track whose file name carries a video-rip marker is held back from radio and the system mixes (tracks.source_verdict, migration 0077). It still plays when chosen. A renamed file is released; the operator's "fine" sticks. - Suspect sources shows what was done to each track, with "This one is fine" and "Hold back again" (PUT /api/admin/library/suspect-sources/{id}). - The Liked list prefers a copy that is not held back. Replacing a rip that has no clean copy is left for the operator to decide. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-08 22:13:37 -04:00
bvandeusenandClaude Opus 5.5	5b372f61d7	feat: the same song on several releases counts as one song (M498 #5438) ... A single and the album it is on stay two files, since each fulfils its own release in Lidarr, but they are one song to the listener. - tracks.song_id links copies; the generated song_key (song_id, else the track's own id) is what they share (migration 0076). - The resolver links each cross-release group every pass (idempotent; only with auto-resolve on) and, when a link is new, shares existing likes across the song and logs them for sync. - A like or unlike (web and Subsonic) reaches every copy; each change is logged and published so clients update every heart. - The Liked list and its count show the song once; Shuffle and the mix writer take one copy per song. - A merge keeps the removed copy's song link; "Not the same song" on the Across releases tab dismisses the group and undoes the link. Shared plays ("heard via another copy") are left for a later step. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-08 22:07:55 -04:00
bvandeusenandClaude Opus 5.5	4ecff52f19	feat: duplicates resolve themselves where Lidarr says it is safe (M498) ... The duplicate sweep proposed 4,197 groups and every one waited for the operator. Most are safe to settle, and Lidarr defines what safe means: it maps one file to each track of the release it monitors and downloads any mapped file that disappears. Deleting a mapped copy opens exactly the hole the operator saw Lidarr fill. Classify (#5435) - Migration 0075: duplicate_groups.class (same_release, cross_release, mismatch, review), resolve_note, resolved_automatically; duplicate_group_members.lidarr_state (tracked, unmapped); fingerprint_settings.auto_resolve; notification kind duplicates_resolved with both kind CHECKs swapped (rule 36). - library.ClassifyDuplicateGroup, with MatchTitleKey dropping featuring credits, remaster notes and video-rip markers, and keeping live, demo, remix and instrumental. The rip markers move from api to library. Choose the copy to keep (#5436) - ProposeSurvivor ranks the copy Lidarr maps first, then tag fit (a clash-free track number, no rip marker in the name, an MBID), then the quality rules. File size picked the wrong Humanz copy in 6 of 21 groups. Act (#5437) - An hourly resolver pass reads Lidarr's unmapped files, matched by the last three path components, and records each copy's state. - Same album, with at most one copy mapped: merged into the mapped copy. The merge is guarded, so a mapped copy can never be removed (MergeDuplicateGroupGuarded, ErrCopyTrackedByLidarr). - Same album, every copy mapped: the monitored release lists the song twice (Humanz's 14x12" box set). The pass moves Lidarr to the release that lists each song once and best covers what is on disk. It never picks one covering less, and is capped at 10 albums per pass. - Fixed point (lesson #4183): the chosen release no longer repeats. - The album is left alone for 24h while Lidarr rescans, so "every copy unmapped" mid-rescan is never read as licence to merge. - Both actions are audited with no actor and summarised to admins. The operator can switch them off in the Fingerprinting card (rule 25). - Manual merges use the same guard: 409 copy_tracked_by_lidarr, or 503 lidarr_unavailable when Lidarr cannot say. Web - Duplicates gets tabs: Needs review, Across releases, Resolved automatically. Each loads as you scroll (rule 172), replacing the pager. - Each copy says whether Lidarr uses it. - The resolver's note shows on each group. - The merge confirm blocks, before sending, a merge that would remove the copy Lidarr uses. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>	2026-10-08 21:49:37 -04:00