bvandeusen/minstrel
1
0
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases 40 Wiki Activity

docs(plan): correct login test filename to avoid route walker collision

Browse Source 
Renamed references from +page.test.ts to login.test.ts throughout,
matching the fix in 8896159. Keeps the plan accurate for re-runs.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This commit is contained in:
Bryan Van Deusen
2026-04-23 06:10:29 -04:00
parent 88961596b1
commit fe410f14eb
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
docs/superpowers/plans/2026-04-22-web-ui-auth.md
+4 -4
View File
@@ -27,7 +27,7 @@
| `src/lib/components/Shell.test.ts` | Shell component tests | | `src/lib/components/Shell.test.ts` | Shell component tests |
| `src/routes/+layout.ts` | `load()` → `await bootstrap()` | | `src/routes/+layout.ts` | `load()` → `await bootstrap()` |
| `src/routes/login/+page.svelte` | Login form UI + behavior | | `src/routes/login/+page.svelte` | Login form UI + behavior |
| `src/routes/login/+page.test.ts` | Login page tests | | `src/routes/login/login.test.ts` | Login page tests (note: NOT `+page.test.ts` — the `+` prefix would trigger SvelteKit's route walker) |
| `src/routes/search/+page.svelte` | "Coming soon" placeholder | | `src/routes/search/+page.svelte` | "Coming soon" placeholder |
| `src/routes/playlists/+page.svelte` | "Coming soon" placeholder | | `src/routes/playlists/+page.svelte` | "Coming soon" placeholder |
| `vitest.setup.ts` | jest-dom matcher registration | | `vitest.setup.ts` | jest-dom matcher registration |
@@ -830,11 +830,11 @@ so the Shell's sidebar nav works end-to-end before the real features land."
**Files:** **Files:**
- Create: `web/src/routes/login/+page.svelte` - Create: `web/src/routes/login/+page.svelte`
- Create: `web/src/routes/login/+page.test.ts` - Create: `web/src/routes/login/login.test.ts`
- [ ] **Step 1: Write the failing test** - [ ] **Step 1: Write the failing test**
Create `web/src/routes/login/+page.test.ts`: Create `web/src/routes/login/login.test.ts`:
```ts ```ts
import { afterEach, describe, expect, test, vi } from 'vitest'; import { afterEach, describe, expect, test, vi } from 'vitest';
@@ -1060,7 +1060,7 @@ Expected: PASS — 10 tests (6 `test(...)` blocks + 4 from `test.each` with 4 ro
- [ ] **Step 5: Commit** - [ ] **Step 5: Commit**
```bash ```bash
git add web/src/routes/login/+page.svelte web/src/routes/login/+page.test.ts git add web/src/routes/login/+page.svelte web/src/routes/login/login.test.ts
git commit -m "feat(web): add login page with returnTo support and typed error UX git commit -m "feat(web): add login page with returnTo support and typed error UX
Inline errors for invalid creds vs. server-side failures. Validates Inline errors for invalid creds vs. server-side failures. Validates