bvandeusen/minstrel
1
0
Fork 0
Code Issues 2 Pull Requests Actions Packages Projects Releases 52 Wiki Activity

fix: a duplicate fold never deletes a lossless copy for a lossy one, nor folds two versions (M498)
release / govulncheck (push) Successful in 14s
Details
release / web (push) Successful in 1m21s
Details
release / go (push) Successful in 1m31s
Details
release / android (push) Successful in 4m58s
Details
release / integration (push) Successful in 5m0s
Details
release / Build signed APK (releases and dev) (push) Successful in 5m7s
Details
release / Attach APK to the Release (tag releases only) (push) Skipped
Details
release / Build + push container image (push) Successful in 15s
Details
release / Verify release artifacts (tag releases only) (push) Skipped
Details

Browse Source 
The first album-copy fold pass on 2026-10-20 removed five FLACs (Måneskin
Rush!, Weezer 2016) in favour of mp3s whose only edge was a recording MBID,
and an explicit "Suite-Pee" for its clean version. ProposeSurvivor now ranks
lossless before tag fit; tag fit still outranks file size, which is what the
Humanz rips needed. The fold keys copies by their version words (title and
file name), so a clean, live or instrumental copy holding the same title tag
is linked, not folded.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
bvandeusen
2026-10-20 12:36:55 -04:00
co-authored by Claude Opus 5.5
parent 16a152b862
commit f32abc974f
6 changed files with 102 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files
internal/library/duplicate_classify_test.go
+34
View File
@@ -73,6 +73,40 @@ func TestMatchTitleKey(t *testing.T) {
}
}
// Copies the fold of 2026-10-20 merged although their file names said they
// were different versions; each pair must disagree. And copies of one version
// named differently must agree.
func TestVersionWords(t *testing.T) {
differ := [][2][2]string{
{{"Suite-Pee", "/m/SOAD/Sugar/System of a Down - Sugar - 02 - Suite-Pee.mp3"},
{"Suite-Pee", "/m/SOAD/Sugar/System of a Down - Sugar - 02 - Suite-Pee (Clean Version).mp3"}},
{{"Luv (sic) Grand Finale", "/m/Nujabes/Hexalogy/Nujabes - Luv(sic) Hexalogy - 06 - Luv (sic) Grand Finale Instrumentals.mp3"},
{"Luv (sic) Grand Finale", "/m/Nujabes/Hexalogy/0106 - Luvsic Grand Finale.m4a"}},
{{"Charger", "/m/Gorillaz/Humanz/Gorillaz - Humanz - 08 - Charger - live in Cologne 2017.mp3"},
{"Charger", "/m/Gorillaz/Humanz/CD 01/08 Charger.flac"}},
}
for _, p := range differ {
a, b := versionWords(p[0][0], p[0][1]), versionWords(p[1][0], p[1][1])
if a == b {
t.Errorf("versionWords agree (%q) on %s and %s", a, p[0][1], p[1][1])
}
}
agree := [][2][2]string{
{{"Heat Waves (Shakur Ahmad Remix)", "/m/GA/Glass Animals - Dreamland Deluxe - 02 - Heat Waves (Shakur Ahmad Remix).mp3"},
{"Heat Waves (Shakur Ahmad Remix)", "/m/GA/02. Heat Waves (Shakur Ahmad Remix).flac"}},
{{"Luv (sic) Instrumentals", "/m/Nujabes/0201 - Luvsic instrumentals.m4a"},
{"Luv (sic) Instrumentals", "/m/Nujabes/Nujabes - Luv(sic) Hexalogy - 01 - Luv (sic) Instrumentals.mp3"}},
{{"Henrietta", "/m/The Fratellis - Costello Music - 01 - Henrietta.mp3"},
{"Henrietta", "/m/The Fratellis - Costello Music - 01 - Henrietta.flac"}},
}
for _, p := range agree {
a, b := versionWords(p[0][0], p[0][1]), versionWords(p[1][0], p[1][1])
if a != b {
t.Errorf("versionWords %q vs %q on copies of one version: %s, %s", a, b, p[0][1], p[1][1])
}
}
}
func TestWrongSlots(t *testing.T) {
track := func(title string, ms int32) dbq.MbReleaseTrack { return dbq.MbReleaseTrack{Title: title, LengthMs: ms} }
copies := func(titles ...string) []slotCopy {