fix(discover): "in about a month" was unreachable in both clients — #2375

The days→months threshold (45) sat above the divisor (30), so a rounded month count of 1 — which needs 15..44 days — could never be reached: every one of those day counts hit the `in N days` branch first. The singular branch was dead code on Android AND web. Lowered the threshold to 30 in both clients, which makes 30..44 days read "in about a month" instead of "in 44 days", and documented the invariant (threshold must not exceed the divisor) next to each constant so the two can't drift apart again. Found by the unit test written for that branch, which is the whole reason to assert on copy that looks obviously correct. Both suites now pin the seam from both sides — 29 days and 30 days — so the branch can't go dead again silently. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
2026-08-02 19:19:05 -04:00
parent 18a61f1065
commit f17356560d
4 changed files with 45 additions and 2 deletions
@@ -66,7 +66,12 @@
    const days = Math.round(ms / 86_400_000);
    if (days < 1) return 'today';
    if (days === 1) return 'tomorrow';
-    if (days < 45) return `in ${days} days`;
+    // The 30 must not exceed the divisor below, or the singular "in about a
+    // month" is unreachable — a rounded month count of 1 needs 15..44 days,
+    // and any higher threshold sends all of those down the days branch. This
+    // read 45 and the singular case was dead code (caught by the Android
+    // unit test for the same logic).
+    if (days < 30) return `in ${days} days`;
    const months = Math.round(days / 30);
    return months === 1 ? 'in about a month' : `in about ${months} months`;
  }