fix(web): AcoustID card's loading line names itself (M401 #3922)
release / govulncheck (push) Successful in 28s
release / web (push) Successful in 1m21s
release / go (push) Successful in 1m41s
release / integration (push) Successful in 6m4s
release / android (push) Successful in 8m1s
release / Build signed APK (releases and dev) (push) Successful in 8m22s
release / Attach APK to the Release (tag releases only) (push) Skipped
release / Build + push container image (push) Successful in 1m31s
release / Verify release artifacts (tag releases only) (push) Skipped

Its bare "Loading…" made the Integrations page's cover-providers test find
two matches for /loading…/i (Vitest, run 8487). "Loading AcoustID
settings…" also says which card is loading.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
2026-10-06 23:47:14 -04:00
co-authored by Claude Opus 5.5
parent 03e07e7c66
commit e8eee55325
2 changed files with 4 additions and 3 deletions
+2 -2
View File
@@ -162,7 +162,7 @@
<button type="button" class="underline hover:no-underline" onclick={load}>Try again</button> <button type="button" class="underline hover:no-underline" onclick={load}>Try again</button>
</p> </p>
{:else if overview === null} {:else if overview === null}
<p class="text-sm text-text-secondary">Loading…</p> <p class="text-sm text-text-secondary">Loading AcoustID settings…</p>
{:else} {:else}
{#if overview.status.problem} {#if overview.status.problem}
<p class="text-sm text-action-destructive" data-testid="acoustid-problem"> <p class="text-sm text-action-destructive" data-testid="acoustid-problem">
@@ -312,7 +312,7 @@
).toLocaleString()}) ).toLocaleString()})
</summary> </summary>
{#if unsettled === null} {#if unsettled === null}
<p class="mt-2 text-sm text-text-secondary">Loading…</p> <p class="mt-2 text-sm text-text-secondary">Loading tracks…</p>
{:else} {:else}
<ul class="mt-2 divide-y divide-border text-sm" data-testid="acoustid-unsettled"> <ul class="mt-2 divide-y divide-border text-sm" data-testid="acoustid-unsettled">
{#each unsettled as t (t.track_id)} {#each unsettled as t (t.track_id)}
@@ -29,7 +29,8 @@ vi.mock('$lib/api/admin', () => ({
createSMTPConfigQuery: vi.fn(), createSMTPConfigQuery: vi.fn(),
updateSMTPConfig: vi.fn(), updateSMTPConfig: vi.fn(),
testSMTPConfig: vi.fn(), testSMTPConfig: vi.fn(),
// AcoustIDCard loads on mount; a never-settling read leaves it on "Loading…". // AcoustIDCard loads on mount; a never-settling read leaves it on its own
// "Loading AcoustID settings…", which the page's /loading…/i queries skip.
getAcoustID: vi.fn(() => new Promise(() => {})), getAcoustID: vi.fn(() => new Promise(() => {})),
updateAcoustIDSettings: vi.fn(), updateAcoustIDSettings: vi.fn(),
runAcoustIDLookup: vi.fn(), runAcoustIDLookup: vi.fn(),