From e8a7e48bd548e468f711cfda5c7da18f0fa53452 Mon Sep 17 00:00:00 2001 From: Bryan Van Deusen Date: Wed, 27 May 2026 19:52:42 -0400 Subject: [PATCH] fix(android): Settings column wasn't scrolling Adding the new Profile / Password / ListenBrainz / Update-check cards pushed AppearanceCard / StorageCard / AboutCard / Sign-out button off the bottom of the viewport on any normal phone. The column was fillMaxSize without verticalScroll, so they were unreachable. User reported: 'I can't find the light/dark theme controls anymore. The settings menu looks like it should scroll but doesn't.' AppearanceCard is at position ~9 in the column, well past the fold on a typical device. Single-line fix: add verticalScroll(rememberScrollState()) to the column's modifier chain. Co-Authored-By: Claude Opus 4.7 (1M context) --- .../com/fabledsword/minstrel/settings/ui/SettingsScreen.kt | 3 +++ 1 file changed, 3 insertions(+) diff --git a/android/app/src/main/java/com/fabledsword/minstrel/settings/ui/SettingsScreen.kt b/android/app/src/main/java/com/fabledsword/minstrel/settings/ui/SettingsScreen.kt index 4b1da639..e2bac10c 100644 --- a/android/app/src/main/java/com/fabledsword/minstrel/settings/ui/SettingsScreen.kt +++ b/android/app/src/main/java/com/fabledsword/minstrel/settings/ui/SettingsScreen.kt @@ -1,6 +1,8 @@ package com.fabledsword.minstrel.settings.ui import androidx.compose.foundation.clickable +import androidx.compose.foundation.rememberScrollState +import androidx.compose.foundation.verticalScroll import androidx.compose.foundation.layout.Arrangement import androidx.compose.foundation.layout.Box import androidx.compose.foundation.layout.Column @@ -87,6 +89,7 @@ fun SettingsScreen( modifier = Modifier .fillMaxSize() .padding(inner) + .verticalScroll(rememberScrollState()) .padding(16.dp), verticalArrangement = Arrangement.spacedBy(16.dp), ) {