bvandeusen/minstrel
1
0
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases 39 Wiki Activity

fix(web): read snake_case keys in MobileAppDownload (#397)

Browse Source 
Server's clientVersionResponse marshals to {version, apk_url,
size_bytes} but the component was reading body.apkUrl / body.sizeBytes
(camelCase). The !body.apkUrl guard was always true → early return →
download button never rendered even when /api/client/version returned
200 with valid data.

Verified directly: /api/client/version returns
  {"version":"v2026.05.10.1","apk_url":"/api/client/apk","size_bytes":65301242}
on the deployed v2026.05.10.1 image; the UI just wasn't reading those
keys.

Map wire (snake_case) → component (camelCase) explicitly via a
WireInfo type so the boundary is auditable.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
Bryan Van Deusen
2026-05-10 23:10:22 -04:00
parent 5054c46385
commit e16bdd9546
1 changed files with 8 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
web/src/lib/components/MobileAppDownload.svelte
+8 -4
View File
@@ -11,6 +11,10 @@
// bandwidth abuse on the APK stream, so this component only shows // bandwidth abuse on the APK stream, so this component only shows
// for logged-in users. Mount in Settings, never in pre-auth surfaces. // for logged-in users. Mount in Settings, never in pre-auth surfaces.
// Server returns snake_case (clientVersionResponse in
// internal/api/client_assets.go). Map to a camelCase struct for
// the rest of the component.
type WireInfo = { version: string; apk_url: string; size_bytes: number };
type Info = { version: string; apkUrl: string; sizeBytes: number }; type Info = { version: string; apkUrl: string; sizeBytes: number };
let info = $state<Info | null>(null); let info = $state<Info | null>(null);
@@ -22,12 +26,12 @@
onMount(async () => { onMount(async () => {
try { try {
const body = await api.get<Partial<Info>>('/api/client/version'); const body = await api.get<Partial<WireInfo>>('/api/client/version');
if (!body.version || !body.apkUrl) return; if (!body.version || !body.apk_url) return;
info = { info = {
version: body.version, version: body.version,
apkUrl: body.apkUrl, apkUrl: body.apk_url,
sizeBytes: body.sizeBytes ?? 0 sizeBytes: body.size_bytes ?? 0
}; };
} catch { } catch {
// 404 (no APK), 401 (somehow unauthed), network error — silent. // 404 (no APK), 401 (somehow unauthed), network error — silent.