fix(flutter): clear analyze --fatal-infos errors from admin parity slice

CI caught six issues against the new admin slice:

- AsyncValue<T> in this Riverpod 3.3.1 codebase exposes `.value`
  (returns T?), not `.valueOrNull`. Switched the three admin readers
  to match the established convention (player_bar, queue_screen,
  now_playing_screen all use `.value`).
- home_screen.dart still has ctx.push calls in _albumsRow / _artistsRow
  (carousel tap handlers) — restored the go_router import that
  Task 2 over-eagerly removed.
- admin_user_edit_sheet.dart had a single-line `if (!await ...) return;`
  that violated curly_braces_in_flow_control_structures. Wrapped in
  braces.
- admin_quarantine_item.dart doc comment had `<top>` placeholders that
  the analyzer flagged as unintended HTML. Rephrased without angle
  brackets.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
2026-05-08 22:02:14 -04:00
parent 9f6ceb1731
commit d5c8d316c5
6 changed files with 10 additions and 7 deletions
@@ -151,7 +151,9 @@ class AdminUserEditSheet extends ConsumerWidget {
message:
'Permanently delete user "${user.username}" and all their data. '
'Cannot be undone.',
)) return;
)) {
return;
}
try {
await users.delete(user.id);
if (context.mounted) Navigator.pop(context);