fix(android): single break in extend loop for detekt LoopWithTooManyJumpStatements

2026-06-04 01:07:57 -04:00
parent 3085d6f409
commit d5437d517e
1 changed files with 28 additions and 25 deletions
@@ -353,36 +353,39 @@ class OutputPickerController @Inject constructor(
        )
        var consecutiveFailures = 0
        var succeeded = 0
+        var aborted = false
        for ((i, ref) in tracks.withIndex()) {
+            if (aborted) break
            if (activeUpnpHolder.active.value?.routeId != route.id) {
                Timber.w("UPnP extend: cancelled at offset %d (route changed)", i)
-                break
-            }
-            val outcome = runCatching {
-                val token = streamTokens.mint(ref.id)
-                transport.addURIToQueue(
-                    uri = token.url,
-                    mime = token.mime,
-                    title = token.title,
-                    enqueuedURIPosition = startPosition + i + 1,
-                )
-            }
-            if (outcome.isSuccess) {
-                consecutiveFailures = 0
-                succeeded += 1
+                aborted = true
            } else {
-                consecutiveFailures += 1
-                val e = outcome.exceptionOrNull()
-                val detail = (e as? SoapFaultException)?.let {
-                    "code=${it.code} desc=${it.description}"
-                } ?: e?.message
-                Timber.w(e, "UPnP extend: append failed at offset %d -- %s", i, detail)
-                if (consecutiveFailures >= EXTEND_ABORT_AFTER_FAILURES) {
-                    Timber.w(
-                        "UPnP extend: aborting after %d consecutive failures",
-                        consecutiveFailures,
+                val outcome = runCatching {
+                    val token = streamTokens.mint(ref.id)
+                    transport.addURIToQueue(
+                        uri = token.url,
+                        mime = token.mime,
+                        title = token.title,
+                        enqueuedURIPosition = startPosition + i + 1,
                    )
-                    break
+                }
+                if (outcome.isSuccess) {
+                    consecutiveFailures = 0
+                    succeeded += 1
+                } else {
+                    consecutiveFailures += 1
+                    val e = outcome.exceptionOrNull()
+                    val detail = (e as? SoapFaultException)?.let {
+                        "code=${it.code} desc=${it.description}"
+                    } ?: e?.message
+                    Timber.w(e, "UPnP extend: append failed at offset %d -- %s", i, detail)
+                    if (consecutiveFailures >= EXTEND_ABORT_AFTER_FAILURES) {
+                        Timber.w(
+                            "UPnP extend: aborting after %d consecutive failures",
+                            consecutiveFailures,
+                        )
+                        aborted = true
+                    }
                }
            }
        }