docs: server comments say what the code does, not how it came to be (#6277)
Comment blocks in cmd/minstrel and 30 smaller internal packages, rewritten
to rule 32's standard with each citation read in context: task, milestone
and rule ids go, and so do the stories they were attached to ("used to",
"Before #N", measurements from one install, quotes, pointers to Fabled
Librarian's records and to docs/superpowers files that are not in the
repo). Where a story wrapped a real constraint, the constraint stays as a
present-tense fact.
Comments that had gone stale are corrected:
- taste.Config: the tuned values are overlaid by internal/recsettings;
it is no longer "a later follow-up".
- StorageConfig: the data dir holds art, caches and the stream secret,
not only playlist covers.
- the Subsonic album list and getUser comments describe what they do
today rather than a milestone that would change it.
Checked: the non-comment token stream of every changed file matches
HEAD, and gofmt -l is empty.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
@@ -1,13 +1,11 @@
|
||||
// Package importer checks a finished download against the album it was
|
||||
// grabbed for and files it into the library (M502 #5522). Nothing reaches
|
||||
// grabbed for and files it into the library. Nothing reaches
|
||||
// the library before the check says the files are the album: a wrong album,
|
||||
// another version of it, a video rip or an incomplete copy is refused, its
|
||||
// release is blocked and the album is searched for again.
|
||||
//
|
||||
// Ported from Fabled Librarian's importer and relocate packages, with the
|
||||
// check rewritten for music: the files are matched to one of the album's
|
||||
// MusicBrainz editions by AcoustID fingerprints, track lengths, titles and
|
||||
// the tags they carry.
|
||||
// The files are matched to one of the album's MusicBrainz editions by
|
||||
// AcoustID fingerprints, track lengths, titles and the tags they carry.
|
||||
package importer
|
||||
|
||||
import (
|
||||
@@ -67,7 +65,7 @@ type File struct {
|
||||
RecordingMBID string
|
||||
LengthMs int
|
||||
// Recordings are the MusicBrainz recordings AcoustID says the audio is,
|
||||
// at or above the operator's minimum score.
|
||||
// at or above the configured minimum score.
|
||||
Recordings []string
|
||||
// Video: the file name says it is a music video, a lyric video or the
|
||||
// like (library.SourceMarkersFor).
|
||||
@@ -113,7 +111,7 @@ type Want struct {
|
||||
Year int
|
||||
PrimaryType string
|
||||
SecondaryTypes []string
|
||||
// Upgrade: a held album wanted for a better copy (#5524), quality or
|
||||
// Upgrade: a held album wanted for a better copy, quality or
|
||||
// rip; AlbumID is the library album it holds, whose tracks the import
|
||||
// replaces.
|
||||
Upgrade string
|
||||
|
||||
Reference in New Issue
Block a user