docs: server comments say what the code does, not how it came to be (#6277)
Comment blocks in cmd/minstrel and 30 smaller internal packages, rewritten
to rule 32's standard with each citation read in context: task, milestone
and rule ids go, and so do the stories they were attached to ("used to",
"Before #N", measurements from one install, quotes, pointers to Fabled
Librarian's records and to docs/superpowers files that are not in the
repo). Where a story wrapped a real constraint, the constraint stays as a
present-tense fact.
Comments that had gone stale are corrected:
- taste.Config: the tuned values are overlaid by internal/recsettings;
it is no longer "a later follow-up".
- StorageConfig: the data dir holds art, caches and the stream secret,
not only playlist covers.
- the Subsonic album list and getUser comments describe what they do
today rather than a milestone that would change it.
Checked: the non-comment token stream of every changed file matches
HEAD, and gofmt -l is empty.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
@@ -40,9 +40,9 @@ type Tags struct {
|
||||
// gets the plain names only.
|
||||
//
|
||||
// A Vorbis track or disc number is the number alone, its count in
|
||||
// TRACKTOTAL and DISCTOTAL, as Picard writes them: dhowden/tag reads
|
||||
// TRACKNUMBER "3/20" as 0, and every album imported before #6171 lost its
|
||||
// order that way. ID3 and MP4 take "3/20", which their readers parse.
|
||||
// TRACKTOTAL and DISCTOTAL, as Picard writes them: dhowden/tag reads a
|
||||
// TRACKNUMBER of "3/20" as 0, which would lose the album's order. ID3 and MP4
|
||||
// take "3/20", which their readers parse.
|
||||
func (t Tags) args(ext string) []string {
|
||||
vorbis := ext == ".flac" || ext == ".ogg" || ext == ".opus"
|
||||
track, disc := ofN(t.Track, t.Tracks), ofN(t.Disc, t.Discs)
|
||||
@@ -111,7 +111,7 @@ func Place(ctx context.Context, src, dst string, t Tags) (tagged bool, err error
|
||||
return placeFile(ctx, src, dst, t, false)
|
||||
}
|
||||
|
||||
// Overwrite is Place onto a file an upgrade replaces (#5524): the new copy
|
||||
// Overwrite is Place onto a file an upgrade replaces: the new copy
|
||||
// takes the old one's path in one rename, so the library never sees the
|
||||
// path empty, and the track row at that path, history and all, carries on
|
||||
// with the new file.
|
||||
|
||||
Reference in New Issue
Block a user