feat: per-user volume leveling preference, synced across devices (M464 #4998)
release / govulncheck (push) Successful in 22s
release / go (push) Successful in 1m17s
release / web (push) Failing after 1m5s
release / android (push) Failing after 1m51s
release / Attach APK to the Release (tag releases only) (push) Canceled after 0s
release / Build + push container image (push) Canceled after 0s
release / Verify release artifacts (tag releases only) (push) Canceled after 0s
release / integration (push) Canceled after 4m12s
release / Build signed APK (releases and dev) (push) Canceled after 3m21s
release / govulncheck (push) Successful in 22s
release / go (push) Successful in 1m17s
release / web (push) Failing after 1m5s
release / android (push) Failing after 1m51s
release / Attach APK to the Release (tag releases only) (push) Canceled after 0s
release / Build + push container image (push) Canceled after 0s
release / Verify release artifacts (tag releases only) (push) Canceled after 0s
release / integration (push) Canceled after 4m12s
release / Build signed APK (releases and dev) (push) Canceled after 3m21s
Mode (off, auto, track, album), target (-18, -16, -14 LUFS) and boost (within headroom, or fully with a limiter), stored per user on the server so the web player, the Android app and casts apply the same one. - Server: user_normalization_prefs (migration 0067), GET/PUT /api/me/normalization; a whole-body PUT, validated, last write wins. - Web: Settings > Playback > Volume leveling. Saves at once, restores the old choice if the save fails, and caches the value for the player. - Android: Settings card. The device keeps a copy for offline playback (Room v9 with an explicit migration, so the upgrade wipes nothing). Writes are offline-first: shown at once, PUT best effort, queued on failure (NORMALIZATION_SET, collapsed to the newest). A refresh never overwrites a change still queued. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
@@ -0,0 +1,69 @@
|
||||
package library
|
||||
|
||||
import (
|
||||
"context"
|
||||
"errors"
|
||||
"testing"
|
||||
|
||||
"git.fabledsword.com/bvandeusen/minstrel/internal/db/dbq"
|
||||
"git.fabledsword.com/bvandeusen/minstrel/internal/dbtest"
|
||||
)
|
||||
|
||||
func TestNormalizationPrefs_Validate(t *testing.T) {
|
||||
if err := DefaultNormalizationPrefs.Validate(); err != nil {
|
||||
t.Fatalf("the defaults are invalid: %v", err)
|
||||
}
|
||||
for _, p := range []NormalizationPrefs{
|
||||
{Mode: "loud", TargetLUFS: -18, Boost: "headroom"},
|
||||
{Mode: "auto", TargetLUFS: -23, Boost: "headroom"},
|
||||
{Mode: "auto", TargetLUFS: -18, Boost: "max"},
|
||||
// A field left out of a PUT body decodes as its zero value.
|
||||
{Mode: "auto", Boost: "headroom"},
|
||||
} {
|
||||
if err := p.Validate(); !errors.Is(err, ErrNormalizationPrefsInvalid) {
|
||||
t.Errorf("%+v: err = %v, want ErrNormalizationPrefsInvalid", p, err)
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
// A user with no row gets the Go defaults, and a stored row reads back the
|
||||
// migration's defaults for any column the insert left out; the two must
|
||||
// agree, or a user would hear a different level after their first save.
|
||||
func TestNormalizationPrefs_DefaultsAndRoundTrip_Integration(t *testing.T) {
|
||||
pool := newPool(t)
|
||||
ctx := context.Background()
|
||||
q := dbq.New(pool)
|
||||
user, err := q.CreateUser(ctx, dbq.CreateUserParams{
|
||||
Username: dbtest.TestUserPrefix + "norm-prefs", PasswordHash: "x", ApiTokenHash: "norm-prefs-token",
|
||||
})
|
||||
if err != nil {
|
||||
t.Fatalf("user: %v", err)
|
||||
}
|
||||
|
||||
got, err := LoadNormalizationPrefs(ctx, q, user.ID)
|
||||
if err != nil || got != DefaultNormalizationPrefs {
|
||||
t.Fatalf("unset prefs = %+v, %v; want the defaults", got, err)
|
||||
}
|
||||
|
||||
if _, err := pool.Exec(ctx, "INSERT INTO user_normalization_prefs (user_id) VALUES ($1)", user.ID); err != nil {
|
||||
t.Fatalf("insert defaults row: %v", err)
|
||||
}
|
||||
got, err = LoadNormalizationPrefs(ctx, q, user.ID)
|
||||
if err != nil || got != DefaultNormalizationPrefs {
|
||||
t.Errorf("migration defaults = %+v, Go defaults = %+v (err %v)", got, DefaultNormalizationPrefs, err)
|
||||
}
|
||||
|
||||
want := NormalizationPrefs{Mode: "track", TargetLUFS: -14, Boost: "limiter"}
|
||||
if saved, err := SaveNormalizationPrefs(ctx, q, user.ID, want); err != nil || saved != want {
|
||||
t.Fatalf("save = %+v, %v; want %+v", saved, err, want)
|
||||
}
|
||||
if got, _ := LoadNormalizationPrefs(ctx, q, user.ID); got != want {
|
||||
t.Errorf("after save = %+v, want %+v", got, want)
|
||||
}
|
||||
if _, err := SaveNormalizationPrefs(ctx, q, user.ID, NormalizationPrefs{Mode: "x"}); !errors.Is(err, ErrNormalizationPrefsInvalid) {
|
||||
t.Errorf("invalid save: err = %v", err)
|
||||
}
|
||||
if got, _ := LoadNormalizationPrefs(ctx, q, user.ID); got != want {
|
||||
t.Errorf("an invalid save changed the stored prefs to %+v", got)
|
||||
}
|
||||
}
|
||||
Reference in New Issue
Block a user