From a87ec770a57202d1f687cfda7b0c14377b2a5a1c Mon Sep 17 00:00:00 2001 From: Bryan Van Deusen Date: Mon, 25 May 2026 22:44:44 -0400 Subject: [PATCH] =?UTF-8?q?fix(android):=20rename=20state=5F=20=E2=86=92?= =?UTF-8?q?=20internal=20(detekt=20VariableNaming)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Trailing-underscore name tripped detekt's `(_)?[a-z][A-Za-z0-9]*` pattern. `internal` matches the naming convention every other VM in the codebase uses for the private MutableStateFlow shadowed by a public StateFlow. Co-Authored-By: Claude Opus 4.7 (1M context) --- .../fabledsword/minstrel/settings/ui/SettingsViewModel.kt | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/android/app/src/main/java/com/fabledsword/minstrel/settings/ui/SettingsViewModel.kt b/android/app/src/main/java/com/fabledsword/minstrel/settings/ui/SettingsViewModel.kt index badfddb9..441fac10 100644 --- a/android/app/src/main/java/com/fabledsword/minstrel/settings/ui/SettingsViewModel.kt +++ b/android/app/src/main/java/com/fabledsword/minstrel/settings/ui/SettingsViewModel.kt @@ -27,8 +27,8 @@ class SettingsViewModel @Inject constructor( ) : ViewModel() { private val transient = MutableStateFlow(TransientState()) - private val state_: MutableStateFlow = MutableStateFlow(SettingsState()) - val state: StateFlow = state_.asStateFlow() + private val internal: MutableStateFlow = MutableStateFlow(SettingsState()) + val state: StateFlow = internal.asStateFlow() init { // Compose the user-visible state from the auth observables @@ -48,7 +48,7 @@ class SettingsViewModel @Inject constructor( isSigningOut = t.isSigningOut, signedOut = t.signedOut, ) - }.collect { state_.value = it } + }.collect { internal.value = it } } }