bvandeusen/minstrel
1
0
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases 39 Wiki Activity

fix(flutter/test): testWidgets skip takes bool, not String

Browse Source 
CI analyze flagged storage_section_test.dart's `skip: _skipDrift` calls.
testWidgets has signature `skip: bool?`; only test() takes `String?` as
the skip-reason. Changed _skipDrift in this file to `const bool = true`
and moved the rationale into a comment. The other two drift-cohort
files (sync_controller_test, audio_cache_manager_test) use test() so
their String const is fine.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
Bryan Van Deusen
2026-05-10 10:41:48 -04:00
parent 1b223d3891
commit a3db6c9453
1 changed files with 5 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
flutter_client/test/settings/storage_section_test.dart
+5 -1
View File
@@ -17,7 +17,11 @@ class _MockStorage extends Mock implements FlutterSecureStorage {}
// which opens the AppDb via NativeDatabase. CI's flutter-ci runner // which opens the AppDb via NativeDatabase. CI's flutter-ci runner
// lacks libsqlite3.so so this silently emits a warning today and would // lacks libsqlite3.so so this silently emits a warning today and would
// break under stricter analyze. Skipped with the drift cohort. // break under stricter analyze. Skipped with the drift cohort.
const _skipDrift = 'libsqlite3 missing on flutter-ci runner; on-device covers'; //
// testWidgets only accepts a bool for skip (unlike test() which takes
// a String reason). Reason: 'libsqlite3 missing on flutter-ci runner;
// on-device covers'. See Fable #399.
const _skipDrift = true;
void main() { void main() {
setUpAll(() { setUpAll(() {