fix(dbtest): reset tag-sources settings between tests (#1490)
Add tag_provider_settings to the truncation list and reset tag_sources_meta.current_version to 1 in ResetDB, mirroring the cover-art settings reset. Without it the migration-seeded musicbrainz/lastfm rows leaked across tests and desynced the enabled-set signature, so a key-only PATCH spuriously reported version_bumped=true (TestAdminUpdateTagSource_KeyOnlyDoesNotBump). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -62,6 +62,10 @@ var dataTables = []string{
|
|||||||
// (never recreates the singleton, seeded once by 0018); ResetDB
|
// (never recreates the singleton, seeded once by 0018); ResetDB
|
||||||
// resets its counter via UPDATE below instead.
|
// resets its counter via UPDATE below instead.
|
||||||
"cover_art_provider_settings",
|
"cover_art_provider_settings",
|
||||||
|
// Same reasoning for the tag-enrichment settings (#1490): truncate the
|
||||||
|
// per-provider rows (reconcile re-seeds registered ones), and reset the
|
||||||
|
// tag_sources_meta counter via UPDATE below rather than truncating it.
|
||||||
|
"tag_provider_settings",
|
||||||
// recsettings.New reconciles shipped defaults on every construction
|
// recsettings.New reconciles shipped defaults on every construction
|
||||||
// (#1250), so truncating gives each test pristine tuning values.
|
// (#1250), so truncating gives each test pristine tuning values.
|
||||||
"recommendation_weight_profiles",
|
"recommendation_weight_profiles",
|
||||||
@@ -98,4 +102,12 @@ func ResetDB(t *testing.T, pool *pgxpool.Pool) {
|
|||||||
); err != nil {
|
); err != nil {
|
||||||
t.Fatalf("dbtest.ResetDB reset cover-art version: %v", err)
|
t.Fatalf("dbtest.ResetDB reset cover-art version: %v", err)
|
||||||
}
|
}
|
||||||
|
// Same for the tag-sources counter (#1490) — clears cross-test version
|
||||||
|
// accumulation that would spuriously report version_bumped on a
|
||||||
|
// key-only change.
|
||||||
|
if _, err := pool.Exec(ctx,
|
||||||
|
"UPDATE tag_sources_meta SET current_version = 1, last_registered_providers_hash = ''",
|
||||||
|
); err != nil {
|
||||||
|
t.Fatalf("dbtest.ResetDB reset tag-sources version: %v", err)
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|||||||
Reference in New Issue
Block a user