bvandeusen/minstrel
1
0
Fork 0
Code Issues 2 Pull Requests Actions Packages Projects Releases 52 Wiki Activity

chore(deps): SvelteKit 3 with adapter-static 4 and TypeScript 6, full-tree npm audit (#5021)

Browse Source 
Merges Renovate's kit 3 (PR #149) and adapter-static 4 (PR #148) bumps,
plus the migration they need. The mechanical part is `sv migrate
sveltekit-3`, run one task at a time and reviewed:

- svelte.config.js is gone. Its options move into sveltekit() in
  vite.config.ts, exported as kitOptions so vitest.config.ts runs the
  same kit setup, including the $test-utils alias the tests import.
- $lib becomes #lib through package.json "imports". There is no
  src/lib/index, so only the "#lib/*" entry is kept.
- tsconfig extends $app/tsconfig.
- Peer floors raised to kit 3's requirements: svelte ^5.57.1, vite
  ^8.0.12, svelte-check ^4.7.5.

By hand, from the codemod's list of non-automated tasks:

- goto's replaceState option is now replace; keepFocus becomes
  reset: false. For the search typeahead, reset: false also stops the
  scroll-to-top, which is wanted while typing.
- The test setup mocks drop pushState/replaceState and $app/paths
  base/assets, which kit 3 removed, and mock refreshAll in place of
  invalidateAll.
- The other flagged files only read page.url or goto internal routes,
  so they needed no change.

TypeScript goes to ^6, not the ^7 Renovate offers: kit 3 declares
typescript ^6 as a peer and svelte-check 4.7 accepts ^5 || ^6. Move to
7 once both accept it.

With Tailwind 4 and kit 3 in, `npm audit` on the whole tree reports 0,
so the web lane now audits every dependency rather than only what
ships to browsers.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
bvandeusen
2026-10-08 10:50:39 -04:00
co-authored by Claude Opus 5.5
parent beba5b2082 c83933b61a
commit 94a9c8cbe3
186 changed files with 916 additions and 924 deletions
Download Patch File Download Diff File Expand all files Collapse all files
web/src/routes/settings/+page.svelte
+13 -13
View File
@@ -1,6 +1,6 @@
<script lang="ts">
import { onMount } from 'svelte';
import { pageTitle } from '$lib/branding';
import { pageTitle } from '#lib/branding.js';
import { useQueryClient } from '@tanstack/svelte-query';
import type { CreateQueryResult, CreateMutationResult } from '@tanstack/svelte-query';
import {
@@ -8,15 +8,15 @@
createTokenMutation,
createEnabledMutation,
type LBStatus
} from '$lib/api/listenbrainz';
} from '#lib/api/listenbrainz.js';
import {
createRecommendationMetricsQuery,
type RecommendationMetrics,
type SurfaceIntent,
type MetricDelta
} from '$lib/api/metrics';
import { theme, setTheme, type ThemePreference } from '$lib/stores/theme.svelte';
import { player, setCrossfade } from '$lib/player/store.svelte';
} from '#lib/api/metrics.js';
import { theme, setTheme, type ThemePreference } from '#lib/stores/theme.svelte.js';
import { player, setCrossfade } from '#lib/player/store.svelte.js';
import {
updateProfile,
changePassword,
@@ -24,14 +24,14 @@
getSubsonicPasswordStatus,
generateSubsonicPassword,
clearSubsonicPassword
} from '$lib/api/me';
import { errCode } from '$lib/api/errors';
import { pushToast } from '$lib/stores/toast.svelte';
import MobileAppDownload from '$lib/components/MobileAppDownload.svelte';
import ServerVersion from '$lib/components/ServerVersion.svelte';
import ActiveSessions from '$lib/components/ActiveSessions.svelte';
import NormalizationSetting from '$lib/components/NormalizationSetting.svelte';
import NotificationSettings from '$lib/components/NotificationSettings.svelte';
} from '#lib/api/me.js';
import { errCode } from '#lib/api/errors.js';
import { pushToast } from '#lib/stores/toast.svelte.js';
import MobileAppDownload from '#lib/components/MobileAppDownload.svelte';
import ServerVersion from '#lib/components/ServerVersion.svelte';
import ActiveSessions from '#lib/components/ActiveSessions.svelte';
import NormalizationSetting from '#lib/components/NormalizationSetting.svelte';
import NotificationSettings from '#lib/components/NotificationSettings.svelte';
const queryClient = useQueryClient();
web/src/routes/settings/Appearance.test.ts
+6 -6
View File
@@ -1,7 +1,7 @@
import { describe, expect, test, vi, beforeEach } from 'vitest';
import { render, screen, fireEvent } from '@testing-library/svelte';
vi.mock('$lib/api/listenbrainz', () => {
vi.mock('#lib/api/listenbrainz.js', () => {
// Mocks must look like a Svelte readable store. The page reads e.g.
// $status.isPending, which is shorthand for "subscribe to status,
// then read .isPending on the emitted value." Returning an object
@@ -27,8 +27,8 @@ vi.mock('$lib/api/listenbrainz', () => {
// The Notifications section has its own tests (NotificationSettings.test.ts);
// here it only needs a settled query so the page renders.
vi.mock('$lib/api/notifications', async (importOriginal) => {
const mod = await importOriginal<typeof import('$lib/api/notifications')>();
vi.mock('#lib/api/notifications.js', async (importOriginal) => {
const mod = await importOriginal<typeof import('#lib/api/notifications.js')>();
const { mockQuery } = await import('../../test-utils/query');
return {
...mod,
@@ -39,8 +39,8 @@ vi.mock('$lib/api/notifications', async (importOriginal) => {
});
// The Volume leveling setting loads on mount; keep it off the network.
vi.mock('$lib/api/normalization', async (importOriginal) => {
const mod = await importOriginal<typeof import('$lib/api/normalization')>();
vi.mock('#lib/api/normalization.js', async (importOriginal) => {
const mod = await importOriginal<typeof import('#lib/api/normalization.js')>();
return {
...mod,
getNormalization: vi.fn().mockResolvedValue(mod.DEFAULT_NORMALIZATION),
@@ -48,7 +48,7 @@ vi.mock('$lib/api/normalization', async (importOriginal) => {
};
});
vi.mock('$lib/api/metrics', () => ({
vi.mock('#lib/api/metrics.js', () => ({
createRecommendationMetricsQuery: () => ({
subscribe: (run: (v: unknown) => void) => {
run({ isPending: false, isError: false, data: { window_days: 30, baseline: null, groups: [] } });
web/src/routes/settings/settings.test.ts
+10 -10
View File
@@ -1,9 +1,9 @@
import { afterEach, describe, expect, test, vi } from 'vitest';
import { render, screen, fireEvent, waitFor, within } from '@testing-library/svelte';
import { readable, writable } from 'svelte/store';
import type { LBStatus } from '$lib/api/listenbrainz';
import type { LBStatus } from '#lib/api/listenbrainz.js';
vi.mock('$lib/api/listenbrainz', () => ({
vi.mock('#lib/api/listenbrainz.js', () => ({
createLBStatusQuery: vi.fn(),
createTokenMutation: vi.fn(),
createEnabledMutation: vi.fn(),
@@ -13,8 +13,8 @@ vi.mock('$lib/api/listenbrainz', () => ({
// The Notifications section has its own tests (NotificationSettings.test.ts);
// here it only needs a settled query so the page renders.
vi.mock('$lib/api/notifications', async (importOriginal) => {
const mod = await importOriginal<typeof import('$lib/api/notifications')>();
vi.mock('#lib/api/notifications.js', async (importOriginal) => {
const mod = await importOriginal<typeof import('#lib/api/notifications.js')>();
const { mockQuery } = await import('../../test-utils/query');
return {
...mod,
@@ -25,8 +25,8 @@ vi.mock('$lib/api/notifications', async (importOriginal) => {
});
// The Volume leveling setting loads on mount; keep it off the network.
vi.mock('$lib/api/normalization', async (importOriginal) => {
const mod = await importOriginal<typeof import('$lib/api/normalization')>();
vi.mock('#lib/api/normalization.js', async (importOriginal) => {
const mod = await importOriginal<typeof import('#lib/api/normalization.js')>();
return {
...mod,
getNormalization: vi.fn().mockResolvedValue(mod.DEFAULT_NORMALIZATION),
@@ -34,7 +34,7 @@ vi.mock('$lib/api/normalization', async (importOriginal) => {
};
});
vi.mock('$lib/api/me', () => ({
vi.mock('#lib/api/me.js', () => ({
updateProfile: vi.fn(),
changePassword: vi.fn(),
// Default to a resolved value so the page's $effect doesn't crash
@@ -51,7 +51,7 @@ const metricsMock = vi.hoisted(() => ({
data: { window_days: 30, baseline: null, groups: [] } as unknown
}));
vi.mock('$lib/api/metrics', () => ({
vi.mock('#lib/api/metrics.js', () => ({
createRecommendationMetricsQuery: () => ({
subscribe: (run: (v: unknown) => void) => {
run({ isPending: false, isError: false, data: metricsMock.data });
@@ -67,7 +67,7 @@ import {
createEnabledMutation,
setListenBrainzToken,
setListenBrainzEnabled
} from '$lib/api/listenbrainz';
} from '#lib/api/listenbrainz.js';
import {
updateProfile,
changePassword,
@@ -75,7 +75,7 @@ import {
getSubsonicPasswordStatus,
generateSubsonicPassword,
clearSubsonicPassword
} from '$lib/api/me';
} from '#lib/api/me.js';
function mockStatusStore(data: LBStatus) {
return readable({ data, isPending: false, isError: false });