bvandeusen/minstrel
1
0
Fork 0
Code Issues 2 Pull Requests Actions 2 Packages Projects Releases 52 Wiki Activity

fix(android): look gains up by key, not value (M464 #5000)
release / govulncheck (push) Successful in 16s
Details
release / web (push) Successful in 1m28s
Details
release / go (push) Successful in 1m43s
Details
release / integration (push) Successful in 4m38s
Details
release / android (push) Successful in 5m19s
Details
release / Build signed APK (releases and dev) (push) Successful in 5m30s
Details
release / Attach APK to the Release (tag releases only) (push) Skipped
Details
release / Build + push container image (push) Successful in 1m13s
Details
release / Verify release artifacts (tag releases only) (push) Skipped
Details

Browse Source 
`id in map` on a ConcurrentHashMap resolves to its legacy contains(),
which tests values (KT-18053); the compiler refuses it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
bvandeusen
2026-10-06 19:18:15 -04:00
co-authored by Claude Opus 5.5
parent 1013c283da
commit 92c3f9bdb8
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
android/app/src/main/java/com/fabledsword/minstrel/player/gain/ReplayGainStore.kt
+2 -2
View File
@@ -64,7 +64,7 @@ class ReplayGainStore internal constructor(
fun request(trackIds: Collection<String>) { fun request(trackIds: Collection<String>) {
val now = clock() val now = clock()
val wanted = trackIds.filter { id -> val wanted = trackIds.filter { id ->
id !in gains && !gains.containsKey(id) &&
(missedAt[id]?.let { now - it > MISS_RETRY_MS } ?: true) && (missedAt[id]?.let { now - it > MISS_RETRY_MS } ?: true) &&
inflight.add(id) inflight.add(id)
} }
@@ -80,7 +80,7 @@ class ReplayGainStore internal constructor(
internal suspend fun load(ids: List<String>) { internal suspend fun load(ids: List<String>) {
fromCache(ids) fromCache(ids)
val rest = ids.filter { it !in gains } val rest = ids.filter { !gains.containsKey(it) }
val health = serverHealth() val health = serverHealth()
if (rest.isEmpty() || health == ServerHealth.Offline || health == ServerHealth.ServerDown) return if (rest.isEmpty() || health == ServerHealth.Offline || health == ServerHealth.ServerDown) return
for (batch in rest.chunked(MAX_IDS_PER_REQUEST)) { for (batch in rest.chunked(MAX_IDS_PER_REQUEST)) {