fix(server): wrap defer tx.Rollback for errcheck + gofmt -s alignment
golangci-lint surfaced both on 9c7dec6:
- errcheck on bare 'defer tx.Rollback(ctx)' in 2 test files
- gofmt -s wanted tighter map-key alignment in library_sync.go +
library_sync_test.go (auto-fixed by 'gofmt -s -w')
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -227,8 +227,8 @@ func scopedLikeRows(rows []string, userIDStr, entityKey string) []json.RawMessag
|
|||||||
continue
|
continue
|
||||||
}
|
}
|
||||||
b, _ := json.Marshal(map[string]string{
|
b, _ := json.Marshal(map[string]string{
|
||||||
"user_id": parts[0],
|
"user_id": parts[0],
|
||||||
entityKey: parts[1],
|
entityKey: parts[1],
|
||||||
})
|
})
|
||||||
msgs = append(msgs, b)
|
msgs = append(msgs, b)
|
||||||
}
|
}
|
||||||
|
|||||||
@@ -49,7 +49,7 @@ func TestLibrarySync_AfterArtistUpsert_ReturnsHydratedPayload(t *testing.T) {
|
|||||||
if err != nil {
|
if err != nil {
|
||||||
t.Fatalf("begin: %v", err)
|
t.Fatalf("begin: %v", err)
|
||||||
}
|
}
|
||||||
defer tx.Rollback(ctx)
|
defer func() { _ = tx.Rollback(ctx) }()
|
||||||
var artistID string
|
var artistID string
|
||||||
if err := tx.QueryRow(ctx,
|
if err := tx.QueryRow(ctx,
|
||||||
`INSERT INTO artists (name, sort_name) VALUES ($1, $2) RETURNING id::text`,
|
`INSERT INTO artists (name, sort_name) VALUES ($1, $2) RETURNING id::text`,
|
||||||
@@ -205,4 +205,3 @@ func TestSplitOnce(t *testing.T) {
|
|||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
@@ -43,7 +43,7 @@ func TestLogChange_WritesRowInTx(t *testing.T) {
|
|||||||
|
|
||||||
tx, err := pool.Begin(ctx)
|
tx, err := pool.Begin(ctx)
|
||||||
require.NoError(t, err)
|
require.NoError(t, err)
|
||||||
defer tx.Rollback(ctx)
|
defer func() { _ = tx.Rollback(ctx) }()
|
||||||
|
|
||||||
require.NoError(t, sync.LogChange(ctx, tx, sync.EntityArtist, "artist-123", sync.OpUpsert))
|
require.NoError(t, sync.LogChange(ctx, tx, sync.EntityArtist, "artist-123", sync.OpUpsert))
|
||||||
require.NoError(t, tx.Commit(ctx))
|
require.NoError(t, tx.Commit(ctx))
|
||||||
|
|||||||
Reference in New Issue
Block a user