test(flutter): re-enable drift tests after ci-flutter:1.26 ships libsqlite3-0
Drops the libsqlite3-missing skip cohort now that the ci-flutter runner image installs libsqlite3-0 (CI-runner commit on its main). Per-file removals (no behavior change in tests themselves — they just stop being skipped): - `@Tags(['drift'])` + `library;` directive from 5 files. - `const _skipDrift = ...;` declaration + its rationale comment from 6 files (the 5 above + like_button_test.dart, which had its own _skipDrift for the rollback-via-drift case). - `skip: _skipDrift` annotations from 17 test invocations across those 6 files (16 single-line + 1 multi-line in like_button). - Stale `@Tags(['drift']) tier covers it` reference in home_screen_test.dart's drift-coverage comment. Net -79 +18 lines across 7 files; 17 previously-silent tests are now part of the CI signal. Fable #399. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -12,8 +12,7 @@ import 'package:minstrel/playlists/playlists_provider.dart';
|
||||
import 'package:minstrel/theme/theme_data.dart';
|
||||
|
||||
// All tests pump an empty HomeIndex unless they care about populated
|
||||
// section IDs — per-tile hydration is intentionally not exercised here
|
||||
// (that requires drift, and the @Tags(['drift']) tier covers it).
|
||||
// section IDs — per-tile hydration is intentionally not exercised here.
|
||||
// What this suite verifies is the screen's section-level shape:
|
||||
// placeholders / empty-state copy / section presence given the index.
|
||||
const _emptyIndex = HomeIndex.empty;
|
||||
|
||||
@@ -1,6 +1,3 @@
|
||||
@Tags(['drift'])
|
||||
library;
|
||||
|
||||
import 'package:flutter/material.dart';
|
||||
import 'package:flutter_riverpod/flutter_riverpod.dart';
|
||||
import 'package:flutter_test/flutter_test.dart';
|
||||
@@ -11,14 +8,6 @@ import 'package:minstrel/models/album.dart';
|
||||
import 'package:minstrel/models/track.dart';
|
||||
import 'package:minstrel/theme/theme_data.dart';
|
||||
|
||||
// Same drift-cohort skip as the rest. TrackRow now contains
|
||||
// CachedIndicator (ConsumerWidget), which reads
|
||||
// audioCacheManagerProvider → constructs AppDb → drift_flutter calls
|
||||
// driftDatabase() → libsqlite3.so isn't on the runner. Open a real
|
||||
// async chain that leaves a pending timer at test teardown.
|
||||
// See Fable #399.
|
||||
const _skipDrift = true;
|
||||
|
||||
void main() {
|
||||
testWidgets('AlbumCard renders title and artist', (tester) async {
|
||||
await tester.pumpWidget(MaterialApp(
|
||||
@@ -39,7 +28,7 @@ void main() {
|
||||
expect(find.text('Boards of Canada'), findsOneWidget);
|
||||
});
|
||||
|
||||
testWidgets('TrackRow shows mm:ss duration', skip: _skipDrift, (tester) async {
|
||||
testWidgets('TrackRow shows mm:ss duration', (tester) async {
|
||||
// TrackRow now contains CachedIndicator (ConsumerWidget) so a
|
||||
// ProviderScope is required at the root.
|
||||
await tester.pumpWidget(ProviderScope(
|
||||
|
||||
Reference in New Issue
Block a user