feat: the admin settings cards read as menus: each a titled group of rows with one short line, status first, failures in words (M503 #5607)
release / govulncheck (push) Successful in 16s
release / web (push) Failing after 1m27s
release / go (push) Successful in 1m44s
release / android (push) Successful in 5m13s
release / integration (push) Successful in 5m18s
release / Build signed APK (releases and dev) (push) Successful in 5m26s
release / Attach APK to the Release (tag releases only) (push) Skipped
release / Build + push container image (push) Skipped
release / Verify release artifacts (tag releases only) (push) Skipped
release / govulncheck (push) Successful in 16s
release / web (push) Failing after 1m27s
release / go (push) Successful in 1m44s
release / android (push) Successful in 5m13s
release / integration (push) Successful in 5m18s
release / Build signed APK (releases and dev) (push) Successful in 5m26s
release / Attach APK to the Release (tag releases only) (push) Skipped
release / Build + push container image (push) Skipped
release / Verify release artifacts (tag releases only) (push) Skipped
Indexers and clients, searching, missing files, Lidarr's neighbours, AcoustID, fingerprinting, loudness, outgoing email's schedule, public address and proxies move from paragraph cards to SettingsGroup and SettingRow. Switches are role="switch". Also fixes the two type errors run 9023 found: the Lidarr test result is narrowed before its lists are read, and the tag-source save mock carries version_bumped. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
Claude Opus 5.5
@@ -9,6 +9,8 @@
|
||||
} from '#lib/api/admin.js';
|
||||
import { errMessage } from '#lib/api/errors.js';
|
||||
import { pushToast } from '#lib/stores/toast.svelte.js';
|
||||
import SettingsGroup from '#lib/components/settings/SettingsGroup.svelte';
|
||||
import SettingRow from '#lib/components/settings/SettingRow.svelte';
|
||||
|
||||
// Loudness analysis (#4995): the background measurement that loudness
|
||||
// normalization levels playback from, its progress, and its knobs. The
|
||||
@@ -77,121 +79,59 @@
|
||||
}
|
||||
}
|
||||
|
||||
const inputClass =
|
||||
'mt-1 w-28 rounded border border-border bg-background px-2 py-1 text-sm text-text-primary ' +
|
||||
'focus-visible:outline-solid focus-visible:outline-2 focus-visible:outline-accent';
|
||||
const button =
|
||||
'rounded-md border border-border px-3 py-1.5 text-sm text-text-secondary hover:bg-surface-hover hover:text-text-primary disabled:opacity-50';
|
||||
const field = 'w-24 rounded-md border border-border bg-background px-2 py-1.5 text-sm';
|
||||
</script>
|
||||
|
||||
<section class="space-y-4 rounded border border-border bg-surface p-4">
|
||||
<div>
|
||||
<h2 class="font-display text-lg font-medium">Loudness analysis</h2>
|
||||
<p class="mt-1 text-sm text-text-secondary">
|
||||
Measures how loud each track is, so playback can even out the volume between tracks. It runs
|
||||
in the background; until a track is measured, it plays at its own volume.
|
||||
</p>
|
||||
</div>
|
||||
|
||||
<SettingsGroup title="Loudness" id="loudness" hint="Measures each track so playback can even out the volume.">
|
||||
{#if coverage && coverage.total > 0}
|
||||
<div class="flex flex-wrap items-center gap-3 text-sm" data-testid="loudness-coverage">
|
||||
<span>
|
||||
{coverage.measured.toLocaleString()} of {coverage.total.toLocaleString()} tracks measured
|
||||
</span>
|
||||
{#if coverage.pending > 0}
|
||||
<span class="text-text-muted">·</span>
|
||||
<span>{coverage.pending.toLocaleString()} pending</span>
|
||||
{/if}
|
||||
{#if !coverage.enabled && coverage.pending > 0}
|
||||
<span class="text-text-muted">·</span>
|
||||
<span>paused while analysis is off</span>
|
||||
{/if}
|
||||
{#if coverage.silent > 0}
|
||||
<span class="text-text-muted">·</span>
|
||||
<span
|
||||
class="cursor-help"
|
||||
title="These tracks are silent or too short to measure. They play without adjustment."
|
||||
>
|
||||
{coverage.silent.toLocaleString()} silent
|
||||
</span>
|
||||
{/if}
|
||||
{#if coverage.unreadable > 0}
|
||||
<span class="text-text-muted">·</span>
|
||||
<span
|
||||
class="cursor-help"
|
||||
title="ffmpeg couldn't decode these files. Each is tried again when its file changes."
|
||||
>
|
||||
{coverage.unreadable.toLocaleString()} unreadable
|
||||
</span>
|
||||
{/if}
|
||||
{@const c = coverage}
|
||||
<div data-testid="loudness-coverage">
|
||||
<SettingRow label="Progress">
|
||||
{#snippet hint()}
|
||||
{c.measured.toLocaleString()} of {c.total.toLocaleString()} tracks measured
|
||||
{#if c.pending > 0}{` · ${c.pending.toLocaleString()} pending`}{/if}
|
||||
{#if !c.enabled && c.pending > 0}{' · paused while analysis is off'}{/if}
|
||||
{#if c.silent > 0}
|
||||
<span title="Silent or too short to measure. They play without adjustment.">{` · ${c.silent.toLocaleString()} silent`}</span>
|
||||
{/if}
|
||||
{#if c.unreadable > 0}
|
||||
<span title="ffmpeg couldn't decode these files. Each is tried again when its file changes.">{` · ${c.unreadable.toLocaleString()} unreadable`}</span>
|
||||
{/if}
|
||||
{/snippet}
|
||||
</SettingRow>
|
||||
</div>
|
||||
{/if}
|
||||
|
||||
{#if loadError}
|
||||
<p class="text-sm text-action-destructive">
|
||||
<p class="px-4 py-3 text-sm text-error-fg">
|
||||
Couldn't load loudness analysis settings.
|
||||
<button type="button" class="underline hover:no-underline" onclick={load}>Try again</button>
|
||||
</p>
|
||||
{:else if form === null}
|
||||
<p class="text-sm text-text-secondary">Loading…</p>
|
||||
<p class="px-4 py-3 text-sm text-text-secondary">Loading…</p>
|
||||
{:else}
|
||||
<label class="flex items-start gap-3">
|
||||
<input type="checkbox" bind:checked={form.enabled} class="mt-1" />
|
||||
<span>
|
||||
<span class="text-sm text-text-primary">Analyze tracks</span>
|
||||
<span class="block text-xs text-text-secondary">
|
||||
Off stops the background analysis, including for new tracks. Tracks already measured keep
|
||||
their values, so they stay leveled.
|
||||
</span>
|
||||
</span>
|
||||
</label>
|
||||
|
||||
<label class="block">
|
||||
<span class="text-sm text-text-primary">Files analyzed at once</span>
|
||||
<span class="block text-xs text-text-secondary">
|
||||
Each analysis reads the whole file, competing with playback for CPU and with streaming for
|
||||
the disk. Lower it if playback stutters while it runs.
|
||||
</span>
|
||||
<input
|
||||
type="number"
|
||||
min="1"
|
||||
max="8"
|
||||
bind:value={form.backfill_concurrency}
|
||||
class={inputClass}
|
||||
/>
|
||||
</label>
|
||||
|
||||
<label class="block">
|
||||
<span class="text-sm text-text-primary">Speaker cache (MB)</span>
|
||||
<span class="block text-xs text-text-secondary">
|
||||
Leveled copies for Sonos and UPnP speakers. The least recently played go first.
|
||||
</span>
|
||||
<input
|
||||
type="number"
|
||||
min="256"
|
||||
max="65536"
|
||||
step="256"
|
||||
bind:value={form.leveled_cache_mb}
|
||||
class={inputClass}
|
||||
/>
|
||||
</label>
|
||||
|
||||
{#if !valid}
|
||||
<div class="text-xs text-action-destructive" data-testid="settings-problems">
|
||||
{#if !concurrencyOk}<p>Files analyzed at once must be a whole number from 1 to 8.</p>{/if}
|
||||
{#if !cacheOk}<p>Speaker cache must be a whole number of MB from 256 to 65536.</p>{/if}
|
||||
</div>
|
||||
{/if}
|
||||
|
||||
<div class="flex justify-end">
|
||||
<button
|
||||
type="button"
|
||||
class="rounded-md bg-action-secondary px-4 py-2 text-sm text-action-fg hover:opacity-90
|
||||
focus-visible:outline-solid focus-visible:outline-2 focus-visible:outline-accent
|
||||
disabled:cursor-not-allowed disabled:opacity-50"
|
||||
disabled={!dirty || saving || !valid}
|
||||
onclick={save}
|
||||
>
|
||||
<SettingRow label="Analyze tracks" for="loudness-enabled" hint="Off stops it; tracks already measured stay leveled.">
|
||||
<input id="loudness-enabled" type="checkbox" role="switch" aria-checked={form.enabled} bind:checked={form.enabled} class="h-4 w-4 cursor-pointer accent-accent" />
|
||||
</SettingRow>
|
||||
<SettingRow label="Files analyzed at once" for="loudness-concurrency" hint="Lower it if playback stutters while it runs.">
|
||||
<input id="loudness-concurrency" type="number" min="1" max="8" bind:value={form.backfill_concurrency} class={field} />
|
||||
</SettingRow>
|
||||
<SettingRow label="Speaker cache" for="loudness-cache" hint="Leveled copies for Sonos and UPnP speakers.">
|
||||
<input id="loudness-cache" type="number" min="256" max="65536" step="256" bind:value={form.leveled_cache_mb} class={field} />
|
||||
<span class="text-sm text-text-secondary">MB</span>
|
||||
</SettingRow>
|
||||
<div class="flex flex-wrap items-center justify-end gap-2 px-4 py-3">
|
||||
{#if !valid}
|
||||
<div class="mr-auto text-xs text-error-fg" data-testid="settings-problems">
|
||||
{#if !concurrencyOk}<p>Files analyzed at once must be a whole number from 1 to 8.</p>{/if}
|
||||
{#if !cacheOk}<p>Speaker cache must be a whole number of MB from 256 to 65536.</p>{/if}
|
||||
</div>
|
||||
{/if}
|
||||
<button type="button" class={button} disabled={!dirty || saving || !valid} onclick={save}>
|
||||
{saving ? 'Saving…' : 'Save'}
|
||||
</button>
|
||||
</div>
|
||||
{/if}
|
||||
</section>
|
||||
</SettingsGroup>
|
||||
|
||||
Reference in New Issue
Block a user