fix: shutdown ends the live-event streams so a redeploy drains instead of waiting out its deadline (#5293)
release / govulncheck (push) Successful in 24s
release / web (push) Successful in 1m49s
release / go (push) Successful in 2m3s
release / integration (push) Successful in 6m1s
release / android (push) Successful in 6m25s
release / Build signed APK (releases and dev) (push) Successful in 6m24s
release / Attach APK to the Release (tag releases only) (push) Skipped
release / Build + push container image (push) Successful in 15s
release / Verify release artifacts (tag releases only) (push) Skipped

http.Server.Shutdown waits for in-flight requests but never cancels them,
and an SSE stream only ends when its client leaves, so any open tab or
signed-in phone held every redeploy for the full 10s and the old task
exited 1. With the swarm's stop-first update that was ~10s of downtime per
deploy. The bus now closes on shutdown, ending each stream; clients
reconnect to the next instance.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
2026-10-23 06:46:18 -04:00
co-authored by Claude Opus 5.5
parent fefc51439e
commit 79b90bda03
4 changed files with 71 additions and 1 deletions
+5
View File
@@ -481,6 +481,11 @@ func run() error {
// server's limitRequestBody middleware instead.
IdleTimeout: 120 * time.Second,
}
// Shutdown waits for in-flight requests but never cancels them, and an
// SSE stream only ends when its client leaves. Closing the bus ends
// every stream as shutdown begins, so the drain waits only on real work
// such as an audio stream; clients reconnect to the next instance (#5293).
httpServer.RegisterOnShutdown(bus.Close)
errCh := make(chan error, 1)
go func() {