From 7250f1f0e0d5ebd3d78bbd6ebf2a952e6b7051f0 Mon Sep 17 00:00:00 2001 From: Bryan Van Deusen Date: Wed, 27 May 2026 11:48:44 -0400 Subject: [PATCH] =?UTF-8?q?fix(android):=20LibraryViewModelTest=20?= =?UTF-8?q?=E2=80=94=20pass=20PlayerController=20to=20ctor?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 92a9b55 added PlayerController to LibraryViewModel for the Library "Shuffle all" button. Tests need a relaxed mock; none of the four cases exercise shuffleAll() so the mock just satisfies the constructor. Co-Authored-By: Claude Opus 4.7 (1M context) --- .../library/ui/LibraryViewModelTest.kt | 25 ++++++++++++++++--- 1 file changed, 21 insertions(+), 4 deletions(-) diff --git a/android/app/src/test/java/com/fabledsword/minstrel/library/ui/LibraryViewModelTest.kt b/android/app/src/test/java/com/fabledsword/minstrel/library/ui/LibraryViewModelTest.kt index 56dbd113..19570367 100644 --- a/android/app/src/test/java/com/fabledsword/minstrel/library/ui/LibraryViewModelTest.kt +++ b/android/app/src/test/java/com/fabledsword/minstrel/library/ui/LibraryViewModelTest.kt @@ -5,6 +5,7 @@ import com.fabledsword.minstrel.cache.sync.SyncController import com.fabledsword.minstrel.library.data.LibraryRepository import com.fabledsword.minstrel.models.AlbumRef import com.fabledsword.minstrel.models.ArtistRef +import com.fabledsword.minstrel.player.PlayerController import com.fabledsword.minstrel.testutil.MainDispatcherExtension import io.mockk.every import io.mockk.mockk @@ -26,7 +27,11 @@ class LibraryViewModelTest { every { repo.observeArtists() } returns MutableSharedFlow() every { repo.observeAlbums() } returns MutableSharedFlow() - val vm = LibraryViewModel(repo, mockk(relaxed = true)) + val vm = LibraryViewModel( + repo, + mockk(relaxed = true), + mockk(relaxed = true), + ) assertEquals(LibraryUiState.Loading, vm.uiState.value) } @@ -44,7 +49,11 @@ class LibraryViewModelTest { every { repo.observeArtists() } returns flowOf(emptyList()) every { repo.observeAlbums() } returns flowOf(emptyList()) - val vm = LibraryViewModel(repo, mockk(relaxed = true)) + val vm = LibraryViewModel( + repo, + mockk(relaxed = true), + mockk(relaxed = true), + ) vm.uiState.test { assertEquals(LibraryUiState.Empty, awaitItem()) @@ -60,7 +69,11 @@ class LibraryViewModelTest { every { repo.observeAlbums() } returns flowOf(listOf(AlbumRef(id = "al1", title = "Geogaddi", artistId = "a1"))) - val vm = LibraryViewModel(repo, mockk(relaxed = true)) + val vm = LibraryViewModel( + repo, + mockk(relaxed = true), + mockk(relaxed = true), + ) vm.uiState.test { val success = awaitItem() as LibraryUiState.Success @@ -79,7 +92,11 @@ class LibraryViewModelTest { flow { throw IllegalStateException("DAO blew up") } every { repo.observeAlbums() } returns flowOf(emptyList()) - val vm = LibraryViewModel(repo, mockk(relaxed = true)) + val vm = LibraryViewModel( + repo, + mockk(relaxed = true), + mockk(relaxed = true), + ) vm.uiState.test { val error = awaitItem() as LibraryUiState.Error