feat: Minstrel stops acquiring music and drops Discover
release / go (push) Successful in 1m54s
release / web (push) Failing after 5s
release / integration (push) Failing after 3m44s
release / govulncheck (push) Successful in 20s
release / Attach APK to the Release (tag releases only) (push) Canceled after 0s
release / Build + push container image (push) Canceled after 0s
release / Verify release artifacts (tag releases only) (push) Canceled after 0s
release / Build signed APK (push) Canceled after 19s
release / android (push) Canceled after 2m37s
release / go (push) Successful in 1m54s
release / web (push) Failing after 5s
release / integration (push) Failing after 3m44s
release / govulncheck (push) Successful in 20s
release / Attach APK to the Release (tag releases only) (push) Canceled after 0s
release / Build + push container image (push) Canceled after 0s
release / Verify release artifacts (tag releases only) (push) Canceled after 0s
release / Build signed APK (push) Canceled after 19s
release / android (push) Canceled after 2m37s
Minstrel is now a viewer of the library it is pointed at. Finding, downloading and filing music moves out of it. Removed from the server: - the request flow (requests, approval, auto-approve) and the wanted list, follows, release profiles and release blocks; - searching indexers, the download clients, the importer, the album lifecycle and missing-file re-acquisition; - the catalogue's discography, search and art (the MusicBrainz release and track-list cache stays, for the duplicate resolver); - Discover: its suggestions of artists not in the library, snoozes, the candidate-artist tag enrichment and its tuning scope; - writes to acquisition tables from moving the library folder and from merging duplicates, the want-list join on Suspect sources, the sealing of acquisition credentials, and the release-group lookup only re-acquisition used. Settling a wrong-slot duplicate no longer sets the release aside: the copies go and their slots show as missing until a good copy is in the library. Removed from the web: Admin > Acquisition and Requests, /requests, /discover, Follow on the artist page, the auto-approve toggle, and the Collection's wanted-list tabs. The Collection is now the library's health: an overview, Reports, Duplicates, Suspect sources and Missing files. The README and docs no longer describe getting music. The tables stay for now; a later migration drops them. The request notification kinds and the Android screens are still to go. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
@@ -206,9 +206,6 @@ func foldTrackInto(
|
||||
if _, err := tq.MergeRepointPlaybackErrors(ctx, dbq.MergeRepointPlaybackErrorsParams{SurvivorID: survivorID, LoserID: loserID}); err != nil {
|
||||
return f, fmt.Errorf("move playback errors: %w", err)
|
||||
}
|
||||
if _, err := tq.MergeRepointRequests(ctx, dbq.MergeRepointRequestsParams{SurvivorID: survivorID, LoserID: loserID}); err != nil {
|
||||
return f, fmt.Errorf("move request matches: %w", err)
|
||||
}
|
||||
|
||||
playlists, err := tq.MergeRepointPlaylistTracks(ctx, dbq.MergeRepointPlaylistTracksParams{SurvivorID: survivorID, LoserID: loserID})
|
||||
if err != nil {
|
||||
|
||||
@@ -38,7 +38,7 @@ import (
|
||||
// - One file filling several of an album's track slots: MusicBrainz's track
|
||||
// lengths say which slot it belongs to, or AcoustID which song it is when
|
||||
// each copy was cut to its own slot's length, and the copies in the other
|
||||
// slots are removed so the album is fetched again (duplicate_settle.go).
|
||||
// slots are removed, leaving those slots missing (duplicate_settle.go).
|
||||
// - Anything else waits for an admin.
|
||||
|
||||
const (
|
||||
|
||||
@@ -379,7 +379,7 @@ func seedTrackList(t *testing.T, pool *pgxpool.Pool, album dbq.Album, songs map[
|
||||
|
||||
// One recording in two slots of an album: MusicBrainz says Void is as long as
|
||||
// the file and Reach is a minute longer, so the copy in Reach's slot goes. Its
|
||||
// track stays, marked missing, for the album to be fetched again.
|
||||
// track stays, marked missing, until a good copy arrives.
|
||||
func TestResolveDuplicates_RemovesACopyFromAnotherSongsSlot_Integration(t *testing.T) {
|
||||
f := newOneAlbumFixture(t, "acoustic", "Void", "Reach")
|
||||
seedTrackList(t, f.pool, f.album, map[string]int{"Void": 220500, "Reach": 281000})
|
||||
@@ -420,7 +420,7 @@ func TestResolveDuplicates_RemovesACopyFromAnotherSongsSlot_Integration(t *testi
|
||||
// A slot emptied of another song's file folds into a copy of its own song the
|
||||
// album already holds (Savant's VOID DLC "Weeper" beside Void's). A copy under
|
||||
// the title that is not as long as the song is another song: the slot waits for
|
||||
// a copy fetched again, and folds into that.
|
||||
// a good copy, and folds into that.
|
||||
func TestResolveDuplicates_EmptiedSlotFoldsOnlyIntoItsOwnSong_Integration(t *testing.T) {
|
||||
for _, tc := range []struct {
|
||||
name string
|
||||
@@ -488,40 +488,21 @@ func TestResolveDuplicates_RemovesEveryCopyWhenNoSlotIsTheirs_Integration(t *tes
|
||||
// seedTrimmedAlbum is newOneAlbumFixture for one recording cut to both its
|
||||
// slots' lengths: identical audio, as Tormentor and as Record Shop, each as
|
||||
// long as its own slot's song, and the track list naming each slot's
|
||||
// recording. The files came from a download Minstrel imported.
|
||||
// recording.
|
||||
func seedTrimmedAlbum(t *testing.T) oneAlbumFixture {
|
||||
t.Helper()
|
||||
f := newOneAlbumFixture(t, "exact", "Tormentor", "Record Shop")
|
||||
ctx := context.Background()
|
||||
seedTrackList(t, f.pool, f.album, map[string]int{"Tormentor": 221000, "Record Shop": 219000})
|
||||
for _, stmt := range []struct {
|
||||
sql string
|
||||
args []any
|
||||
}{
|
||||
{`UPDATE mb_release_tracks SET recording_mbid = 'rec-' || lower(replace(title, ' ', '-'))`, nil},
|
||||
{`INSERT INTO grabs (info_hash, name, key, client, save_path, origin, import_state, destination)
|
||||
VALUES ('abc123', 'The Wombats - Void [WEB]', 'k', 'qbit', '/dl', 'schedule', 'imported', $1)`,
|
||||
[]any{filepath.Dir(f.aPath)}},
|
||||
} {
|
||||
if _, err := f.pool.Exec(ctx, stmt.sql, stmt.args...); err != nil {
|
||||
t.Fatalf("exec %q: %v", stmt.sql, err)
|
||||
}
|
||||
if _, err := f.pool.Exec(ctx,
|
||||
`UPDATE mb_release_tracks SET recording_mbid = 'rec-' || lower(replace(title, ' ', '-'))`); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
return f
|
||||
}
|
||||
|
||||
func releaseBlocked(t *testing.T, pool *pgxpool.Pool, hash string) bool {
|
||||
t.Helper()
|
||||
var n int
|
||||
if err := pool.QueryRow(context.Background(),
|
||||
`SELECT count(*) FROM release_blocks WHERE info_hash = $1 AND reason = 'files'`, hash).Scan(&n); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
return n == 1
|
||||
}
|
||||
|
||||
// AcoustID matched one copy to Tormentor's recording: that copy stays, Record
|
||||
// Shop's goes, and the download they came from is set aside.
|
||||
// AcoustID matched one copy to Tormentor's recording: that copy stays and
|
||||
// Record Shop's goes.
|
||||
func TestResolveDuplicates_KeepsTheCopyAcoustIDNames_Integration(t *testing.T) {
|
||||
f := seedTrimmedAlbum(t)
|
||||
if _, err := f.pool.Exec(context.Background(),
|
||||
@@ -543,9 +524,6 @@ func TestResolveDuplicates_KeepsTheCopyAcoustIDNames_Integration(t *testing.T) {
|
||||
t.Fatalf("result %+v, tormentor exists %v, record shop exists %v; want only Record Shop's copy removed",
|
||||
res, exists(f.aPath), exists(f.bPath))
|
||||
}
|
||||
if !releaseBlocked(t, f.pool, "abc123") {
|
||||
t.Error("the download the files came from was not set aside, so the album would be fetched from it again")
|
||||
}
|
||||
}
|
||||
|
||||
// Copies whose own lookups all name Record Shop's recording are that
|
||||
@@ -651,8 +629,8 @@ func TestResolveDuplicates_TrimmedCopiesAcoustIDCannotName_Integration(t *testin
|
||||
if err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
if res.WrongFiles != 0 || !exists(f.aPath) || !exists(f.bPath) || releaseBlocked(t, f.pool, "abc123") {
|
||||
t.Fatalf("result %+v; want nothing removed or set aside while AcoustID cannot answer", res)
|
||||
if res.WrongFiles != 0 || !exists(f.aPath) || !exists(f.bPath) {
|
||||
t.Fatalf("result %+v; want nothing removed while AcoustID cannot answer", res)
|
||||
}
|
||||
if status, _, _, _ := (resolveFixture{pool: f.pool, groupID: f.groupID}).group(t); status != "pending" {
|
||||
t.Errorf("group = %s, want pending", status)
|
||||
|
||||
@@ -11,7 +11,6 @@ import (
|
||||
"github.com/jackc/pgx/v5/pgtype"
|
||||
"github.com/jackc/pgx/v5/pgxpool"
|
||||
|
||||
"git.fabledsword.com/bvandeusen/minstrel/internal/acquire"
|
||||
"git.fabledsword.com/bvandeusen/minstrel/internal/audit"
|
||||
"git.fabledsword.com/bvandeusen/minstrel/internal/db/dbq"
|
||||
"git.fabledsword.com/bvandeusen/minstrel/internal/musicbrainz"
|
||||
@@ -29,8 +28,8 @@ import (
|
||||
// three of an album's tracks). The album's MusicBrainz track list
|
||||
// says how long each slot's song is. When exactly one slot's song is as
|
||||
// long as the file and every other slot's song is clearly not, the copies
|
||||
// in the other slots are removed and their tracks marked missing, so the
|
||||
// reacquisition sweeper wants the album back and a good copy fills them.
|
||||
// in the other slots are removed and their tracks marked missing, until a
|
||||
// good copy fills them.
|
||||
// When every slot's song is clearly not the file, every copy goes.
|
||||
// - named: the lengths cannot say (one recording filed as many tracks, each
|
||||
// cut to its own slot's length), but AcoustID
|
||||
@@ -40,9 +39,6 @@ import (
|
||||
// when it is in none of their slots. Same audio that AcoustID does not
|
||||
// know at all is no copy's song, and every copy goes.
|
||||
//
|
||||
// Whenever copies go, the release the files came from is set aside, so the
|
||||
// album fetched again is not the same files.
|
||||
//
|
||||
// Anything less certain stays with an admin, who settles it the same way
|
||||
// with their own answer (SettleWrongSlot).
|
||||
|
||||
@@ -234,11 +230,8 @@ func settleWrongSlots(
|
||||
if !ok {
|
||||
continue
|
||||
}
|
||||
// Set aside before the files go: a pass that dies between the two
|
||||
// still does not fetch the same files again.
|
||||
blocked := blockReleasesHolding(ctx, pool, logger, g)
|
||||
emptied := emptiedSlots(ctx, q, logger, g, losers, tracks)
|
||||
n, err := removeWrongSlots(ctx, pool, logger, g, keep, losers, emptied, blocked, pgtype.UUID{})
|
||||
n, err := removeWrongSlots(ctx, pool, logger, g, keep, losers, emptied, pgtype.UUID{})
|
||||
removed += n
|
||||
if err != nil {
|
||||
logger.Warn("duplicate resolve: removing wrong-slot copies failed", "group_id", syncpkg.FormatUUID(g.id), "err", err)
|
||||
@@ -261,19 +254,15 @@ var ErrNotWrongSlot = errors.New("library: duplicate group is not one recording
|
||||
type WrongSlotResult struct {
|
||||
Kept *MergedCopy
|
||||
Removed []MergedCopy
|
||||
// Blocked names the releases set aside. None when the album was imported
|
||||
// before Minstrel downloaded anything: the same files may come back.
|
||||
Blocked []string
|
||||
}
|
||||
|
||||
// SettleWrongSlot settles a one-album mismatch the resolver left for the
|
||||
// admin, with their answer in place of MusicBrainz's lengths and
|
||||
// AcoustID's. keepID is the copy whose title they say the recording is; an
|
||||
// invalid id means they cannot say, and every copy goes. Either way it is the
|
||||
// resolver's own path: the release the files came from is set aside, the
|
||||
// copies removed are marked missing, and the album is wanted again for them.
|
||||
// A merge does none of that, and keeps one copy's title whether or not it is
|
||||
// the audio's.
|
||||
// resolver's own path: the copies removed are marked missing, and their slots
|
||||
// wait for a good copy. A merge does none of that, and keeps one copy's title
|
||||
// whether or not it is the audio's.
|
||||
//
|
||||
// Copies sharing the kept copy's title are one song held twice and stay, as in
|
||||
// wrongSlots: the next sweep finds the pair and the resolver merges it.
|
||||
@@ -320,9 +309,9 @@ func SettleWrongSlot(
|
||||
}
|
||||
}
|
||||
|
||||
res := WrongSlotResult{Blocked: blockReleasesHolding(ctx, pool, logger, g)}
|
||||
var res WrongSlotResult
|
||||
emptied := emptiedSlots(ctx, q, logger, g, losers, tracks)
|
||||
n, err := removeWrongSlots(ctx, pool, logger, g, keep, losers, emptied, res.Blocked, actorID)
|
||||
n, err := removeWrongSlots(ctx, pool, logger, g, keep, losers, emptied, actorID)
|
||||
if keep >= 0 {
|
||||
res.Kept = &MergedCopy{TrackID: g.members[keep].TrackID, FilePath: g.members[keep].FilePath}
|
||||
}
|
||||
@@ -434,40 +423,9 @@ func groupRecordings(
|
||||
return ids, true
|
||||
}
|
||||
|
||||
// blockReleasesHolding sets aside the downloads a group's files were imported
|
||||
// from, and returns their names. An album imported before Minstrel downloaded
|
||||
// anything has none.
|
||||
func blockReleasesHolding(ctx context.Context, pool *pgxpool.Pool, logger *slog.Logger, g *resolveGroup) []string {
|
||||
q := dbq.New(pool)
|
||||
seen := map[string]bool{}
|
||||
var names []string
|
||||
for _, m := range g.members {
|
||||
grabs, err := q.ListImportedGrabsHolding(ctx, m.FilePath)
|
||||
if err != nil {
|
||||
logger.Warn("duplicate resolve: finding the download a file came from failed", "path", m.FilePath, "err", err)
|
||||
continue
|
||||
}
|
||||
for _, gr := range grabs {
|
||||
if seen[gr.InfoHash] {
|
||||
continue
|
||||
}
|
||||
seen[gr.InfoHash] = true
|
||||
if err := acquire.NewMemory(pool).Block(ctx, dbq.BlockReleaseParams{
|
||||
InfoHash: gr.InfoHash, Name: gr.Name, Reason: acquire.BlockFiles,
|
||||
Detail: "one recording fills several of the album's tracks.", WantID: gr.WantID,
|
||||
}); err != nil {
|
||||
logger.Warn("duplicate resolve: setting the release aside failed", "release", gr.Name, "err", err)
|
||||
continue
|
||||
}
|
||||
names = append(names, gr.Name)
|
||||
}
|
||||
}
|
||||
return names
|
||||
}
|
||||
|
||||
// emptiedSlots is the losers whose song the album holds no other copy of:
|
||||
// no present track on it under that title as long as the song's slot. Those
|
||||
// wait for a copy fetched again (migration 0095). The rest are the song held
|
||||
// wait for a good copy to arrive. The rest are the song held
|
||||
// twice, and missing-pair folding folds them into the copy held: Savant's
|
||||
// VOID DLC "Weeper" beside Void's. A failed read counts every loser as
|
||||
// emptied, which only makes the album wait for a copy it may not need.
|
||||
@@ -515,17 +473,16 @@ func neverRead(ctx context.Context, q *dbq.Queries, rg string) bool {
|
||||
|
||||
// removeWrongSlots deletes each loser's file, then marks its track missing in
|
||||
// the same transaction that closes the group. The row is kept, with its likes
|
||||
// and plays: it is the slot, and a good copy fetched again takes it over. Its
|
||||
// recording MBID is dropped, being the wrong file's, so missing-pair folding
|
||||
// does not fold the slot into the copy that was kept. The slots in emptied
|
||||
// are stamped to wait for a copy fetched again (emptiedSlots). blocked names
|
||||
// the releases set aside, for the record. A file that cannot be removed stops
|
||||
// and plays: it is the slot, and a good copy that arrives later takes it over.
|
||||
// Its recording MBID is dropped, being the wrong file's, so missing-pair
|
||||
// folding does not fold the slot into the copy that was kept. The slots in
|
||||
// emptied are stamped to wait for a good copy (emptiedSlots). A file that cannot be removed stops
|
||||
// the group; the ones already gone are still marked, and the group waits for
|
||||
// the next pass. actorID is the admin settling it by hand, invalid for the
|
||||
// resolver.
|
||||
func removeWrongSlots(
|
||||
ctx context.Context, pool *pgxpool.Pool, logger *slog.Logger, g *resolveGroup, keep int, losers []int,
|
||||
emptied []pgtype.UUID, blocked []string, actorID pgtype.UUID,
|
||||
emptied []pgtype.UUID, actorID pgtype.UUID,
|
||||
) (int, error) {
|
||||
var gone []pgtype.UUID
|
||||
var removedFiles []map[string]string
|
||||
@@ -579,9 +536,6 @@ func removeWrongSlots(
|
||||
"artist": g.members[0].ArtistName,
|
||||
"removed": removedFiles,
|
||||
}
|
||||
if len(blocked) > 0 {
|
||||
details["blocked"] = blocked
|
||||
}
|
||||
keptPath := ""
|
||||
if keep >= 0 {
|
||||
kept := g.members[keep]
|
||||
|
||||
@@ -3,7 +3,6 @@ package library
|
||||
import (
|
||||
"context"
|
||||
"errors"
|
||||
"path/filepath"
|
||||
"strings"
|
||||
"testing"
|
||||
|
||||
@@ -15,19 +14,13 @@ import (
|
||||
)
|
||||
|
||||
// undecidedSlot is one recording filed as Void and as Reach, two songs
|
||||
// MusicBrainz lists at lengths that cannot tell them apart, from a download
|
||||
// Minstrel imported: the resolver leaves it pending for an admin.
|
||||
// MusicBrainz lists at lengths that cannot tell them apart: the resolver
|
||||
// leaves it pending for an admin.
|
||||
func undecidedSlot(t *testing.T) (oneAlbumFixture, dbq.User) {
|
||||
t.Helper()
|
||||
f := newOneAlbumFixture(t, "acoustic", "Void", "Reach")
|
||||
ctx := context.Background()
|
||||
seedTrackList(t, f.pool, f.album, map[string]int{"Void": 220500, "Reach": 221000})
|
||||
if _, err := f.pool.Exec(ctx,
|
||||
`INSERT INTO grabs (info_hash, name, key, client, save_path, origin, import_state, destination)
|
||||
VALUES ('abc123', 'Savant - Void [WEB]', 'k', 'qbit', '/dl', 'schedule', 'imported', $1)`,
|
||||
filepath.Dir(f.aPath)); err != nil {
|
||||
t.Fatal(err)
|
||||
}
|
||||
if res, err := ResolveDuplicates(ctx, f.pool, nil, "", true); err != nil || res.WrongFiles != 0 {
|
||||
t.Fatalf("resolve = %+v, %v; want the group left for the operator", res, err)
|
||||
}
|
||||
@@ -41,8 +34,8 @@ func undecidedSlot(t *testing.T) (oneAlbumFixture, dbq.User) {
|
||||
return f, u
|
||||
}
|
||||
|
||||
// emptiedTrack says whether a copy's track is marked missing and waiting for
|
||||
// the album to be fetched again.
|
||||
// emptiedTrack says whether a copy's track is marked missing and its slot
|
||||
// emptied.
|
||||
func emptiedTrack(t *testing.T, f oneAlbumFixture, id pgtype.UUID) bool {
|
||||
t.Helper()
|
||||
var emptied bool
|
||||
@@ -72,9 +65,8 @@ func settledByHand(t *testing.T, f oneAlbumFixture, actor dbq.User) {
|
||||
}
|
||||
}
|
||||
|
||||
// "Get it again": the admin cannot say which song the recording is, so
|
||||
// every copy goes, the download they came from is set aside, and both slots
|
||||
// wait for the album fetched again. A merge would have kept one title.
|
||||
// The admin cannot say which song the recording is, so every copy goes and
|
||||
// both slots show as missing. A merge would have kept one title.
|
||||
func TestSettleWrongSlot_GetItAgainRemovesEveryCopy_Integration(t *testing.T) {
|
||||
f, op := undecidedSlot(t)
|
||||
ctx := context.Background()
|
||||
@@ -88,12 +80,9 @@ func TestSettleWrongSlot_GetItAgainRemovesEveryCopy_Integration(t *testing.T) {
|
||||
}
|
||||
for _, id := range []pgtype.UUID{f.a.ID, f.b.ID} {
|
||||
if !emptiedTrack(t, f, id) {
|
||||
t.Errorf("track %s is not waiting to be fetched again", syncpkg.FormatUUID(id))
|
||||
t.Errorf("track %s is not marked missing with its slot emptied", syncpkg.FormatUUID(id))
|
||||
}
|
||||
}
|
||||
if !releaseBlocked(t, f.pool, "abc123") || len(res.Blocked) != 1 {
|
||||
t.Errorf("blocked %v; want the download the files came from set aside", res.Blocked)
|
||||
}
|
||||
settledByHand(t, f, op)
|
||||
|
||||
if _, err := SettleWrongSlot(ctx, f.pool, nil, f.groupID, pgtype.UUID{}, op.ID); !errors.Is(err, ErrDuplicateGroupNotPending) {
|
||||
@@ -102,7 +91,7 @@ func TestSettleWrongSlot_GetItAgainRemovesEveryCopy_Integration(t *testing.T) {
|
||||
}
|
||||
|
||||
// "This one is Reach": the copy the admin names stays, and only Void's slot
|
||||
// is emptied and wanted again.
|
||||
// is emptied.
|
||||
func TestSettleWrongSlot_KeepsTheCopyTheOperatorNames_Integration(t *testing.T) {
|
||||
f, op := undecidedSlot(t)
|
||||
res, err := SettleWrongSlot(context.Background(), f.pool, nil, f.groupID, f.b.ID, op.ID)
|
||||
@@ -114,10 +103,7 @@ func TestSettleWrongSlot_KeepsTheCopyTheOperatorNames_Integration(t *testing.T)
|
||||
res, exists(f.aPath), exists(f.bPath))
|
||||
}
|
||||
if !emptiedTrack(t, f, f.a.ID) {
|
||||
t.Error("Void's track is not waiting to be fetched again")
|
||||
}
|
||||
if !releaseBlocked(t, f.pool, "abc123") {
|
||||
t.Error("the download the files came from is not set aside")
|
||||
t.Error("Void's track is not marked missing with its slot emptied")
|
||||
}
|
||||
settledByHand(t, f, op)
|
||||
}
|
||||
@@ -141,7 +127,7 @@ func TestSettleWrongSlot_RefusesWhatItCannotSettle_Integration(t *testing.T) {
|
||||
if _, err := SettleWrongSlot(ctx, f.pool, nil, f.groupID, other, op.ID); !errors.Is(err, ErrSurvivorNotInGroup) {
|
||||
t.Errorf("err = %v, want ErrSurvivorNotInGroup", err)
|
||||
}
|
||||
if !exists(f.aPath) || !exists(f.bPath) || releaseBlocked(t, f.pool, "abc123") {
|
||||
if !exists(f.aPath) || !exists(f.bPath) {
|
||||
t.Error("something changed")
|
||||
}
|
||||
})
|
||||
|
||||
@@ -109,12 +109,6 @@ func (s *Scanner) SetRoots(ctx context.Context, changes []RootChange) (RerootRes
|
||||
if _, err := tq.RerootAlbumCoverPaths(ctx, dbq.RerootAlbumCoverPathsParams{NewRoot: m.Path, OldRoot: m.Was}); err != nil {
|
||||
return fmt.Errorf("reroot covers: %w", err)
|
||||
}
|
||||
if _, err := tq.RerootGrabDestinations(ctx, dbq.RerootGrabDestinationsParams{NewRoot: m.Path, OldRoot: m.Was}); err != nil {
|
||||
return fmt.Errorf("reroot downloads: %w", err)
|
||||
}
|
||||
if _, err := tq.RerootImportRoot(ctx, dbq.RerootImportRootParams{NewRoot: m.Path, OldRoot: m.Was}); err != nil {
|
||||
return fmt.Errorf("reroot import folder: %w", err)
|
||||
}
|
||||
}
|
||||
_, err := tq.UpdateLibraryScanPaths(ctx, roots)
|
||||
return err
|
||||
|
||||
@@ -13,8 +13,8 @@ type TagMBIDs struct {
|
||||
// Release is musicbrainz_albumid: one edition, what albums.mbid stores.
|
||||
Release string
|
||||
Artist string
|
||||
// ReleaseGroup is musicbrainz_releasegroupid. Wants name albums by
|
||||
// release group, so re-acquisition and request completion key on it.
|
||||
// ReleaseGroup is musicbrainz_releasegroupid. The duplicate resolver
|
||||
// reads an album's MusicBrainz track lists by it.
|
||||
ReleaseGroup string
|
||||
// Recording is what tracks.mbid stores and the ListenBrainz Labs
|
||||
// similar-recordings API keys on.
|
||||
|
||||
@@ -57,9 +57,9 @@ var audioExtensions = map[string]bool{
|
||||
// to new files only because taste_profile.sql reads tracks.genre directly,
|
||||
// so a half-repaired library would carry both spellings as separate tags.
|
||||
// 3: the MusicBrainz release-group id is read into albums.release_group_mbid.
|
||||
// Wants name albums by release group, not by the release id
|
||||
// albums.mbid holds, so re-acquisition and request completion need it for
|
||||
// the albums already in the library, not only for files added from now on.
|
||||
// The duplicate resolver reads an album's track lists by release group,
|
||||
// not by the release id albums.mbid holds, so it needs it for the albums
|
||||
// already in the library, not only for files added from now on.
|
||||
// 4: every value of a repeated genre field is read for FLAC, Ogg Vorbis, Opus
|
||||
// and MP4. dhowden/tag kept only the last, and most FLACs that carry
|
||||
// genres declare more than one.
|
||||
|
||||
Reference in New Issue
Block a user