bvandeusen/minstrel
1
0
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases 39 Wiki Activity

style(scrobble): rename unused r *http.Request to _ in client tests

Browse Source 
Caught by revive's unused-parameter check. The four error-path tests
don't read the request body, so the parameter is properly named _.
This commit is contained in:
Bryan Van Deusen
2026-04-28 09:09:45 -04:00
parent 3d23f4930c
commit 5359a16091
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
internal/scrobble/listenbrainz/client_test.go
+4 -4
View File
@@ -55,7 +55,7 @@ func TestClient_SubmitListens_Success(t *testing.T) {
} }
func TestClient_SubmitListens_401_ReturnsErrAuth(t *testing.T) { func TestClient_SubmitListens_401_ReturnsErrAuth(t *testing.T) {
c, srv := newTestClient(func(w http.ResponseWriter, r *http.Request) { c, srv := newTestClient(func(w http.ResponseWriter, _ *http.Request) {
w.WriteHeader(http.StatusUnauthorized) w.WriteHeader(http.StatusUnauthorized)
}) })
defer srv.Close() defer srv.Close()
@@ -66,7 +66,7 @@ func TestClient_SubmitListens_401_ReturnsErrAuth(t *testing.T) {
} }
func TestClient_SubmitListens_400_ReturnsErrPermanent(t *testing.T) { func TestClient_SubmitListens_400_ReturnsErrPermanent(t *testing.T) {
c, srv := newTestClient(func(w http.ResponseWriter, r *http.Request) { c, srv := newTestClient(func(w http.ResponseWriter, _ *http.Request) {
w.WriteHeader(http.StatusBadRequest) w.WriteHeader(http.StatusBadRequest)
}) })
defer srv.Close() defer srv.Close()
@@ -77,7 +77,7 @@ func TestClient_SubmitListens_400_ReturnsErrPermanent(t *testing.T) {
} }
func TestClient_SubmitListens_503_ReturnsErrTransient(t *testing.T) { func TestClient_SubmitListens_503_ReturnsErrTransient(t *testing.T) {
c, srv := newTestClient(func(w http.ResponseWriter, r *http.Request) { c, srv := newTestClient(func(w http.ResponseWriter, _ *http.Request) {
w.WriteHeader(http.StatusServiceUnavailable) w.WriteHeader(http.StatusServiceUnavailable)
}) })
defer srv.Close() defer srv.Close()
@@ -88,7 +88,7 @@ func TestClient_SubmitListens_503_ReturnsErrTransient(t *testing.T) {
} }
func TestClient_SubmitListens_429_ReturnsRetryAfter(t *testing.T) { func TestClient_SubmitListens_429_ReturnsRetryAfter(t *testing.T) {
c, srv := newTestClient(func(w http.ResponseWriter, r *http.Request) { c, srv := newTestClient(func(w http.ResponseWriter, _ *http.Request) {
w.Header().Set("Retry-After", "60") w.Header().Set("Retry-After", "60")
w.WriteHeader(http.StatusTooManyRequests) w.WriteHeader(http.StatusTooManyRequests)
}) })