feat(playevents): post-commit MaybeEnqueue in RecordPlayEnded + Synthetic
This commit is contained in:
@@ -34,7 +34,7 @@ func testPool(t *testing.T) *pgxpool.Pool {
|
||||
}
|
||||
t.Cleanup(pool.Close)
|
||||
if _, err := pool.Exec(context.Background(),
|
||||
"TRUNCATE play_events, skip_events, play_sessions, sessions, users, tracks, albums, artists RESTART IDENTITY CASCADE"); err != nil {
|
||||
"TRUNCATE scrobble_queue, play_events, skip_events, play_sessions, sessions, users, tracks, albums, artists RESTART IDENTITY CASCADE"); err != nil {
|
||||
t.Fatalf("truncate: %v", err)
|
||||
}
|
||||
return pool
|
||||
@@ -317,3 +317,60 @@ func TestRecordPlayStarted_VectorScopedToSession(t *testing.T) {
|
||||
t.Errorf("recent_track_ids has %d entries from prior session, want 0", len(recentIDs))
|
||||
}
|
||||
}
|
||||
|
||||
func TestRecordPlayEnded_QualifyingPlay_EnqueuesScrobble(t *testing.T) {
|
||||
f := newFixture(t, 300_000) // 300s track
|
||||
ctx := context.Background()
|
||||
|
||||
// Enable LB for the user.
|
||||
tk := "tk"
|
||||
if err := f.q.SetListenBrainzToken(ctx, dbq.SetListenBrainzTokenParams{ID: f.user, ListenbrainzToken: &tk}); err != nil {
|
||||
t.Fatalf("token: %v", err)
|
||||
}
|
||||
if err := f.q.SetListenBrainzEnabled(ctx, dbq.SetListenBrainzEnabledParams{ID: f.user, ListenbrainzEnabled: true}); err != nil {
|
||||
t.Fatalf("enable: %v", err)
|
||||
}
|
||||
|
||||
res, err := f.w.RecordPlayStarted(ctx, f.user, f.track, "test", time.Now().Add(-1*time.Minute))
|
||||
if err != nil {
|
||||
t.Fatalf("start: %v", err)
|
||||
}
|
||||
// 250s played out of 300s = ~83% — well above LB threshold.
|
||||
if err := f.w.RecordPlayEnded(ctx, res.PlayEventID, 250_000, time.Now()); err != nil {
|
||||
t.Fatalf("end: %v", err)
|
||||
}
|
||||
|
||||
var n int
|
||||
if err := f.pool.QueryRow(ctx,
|
||||
`SELECT count(*) FROM scrobble_queue WHERE play_event_id = $1`, res.PlayEventID).Scan(&n); err != nil {
|
||||
t.Fatalf("count: %v", err)
|
||||
}
|
||||
if n != 1 {
|
||||
t.Errorf("scrobble_queue rows = %d, want 1", n)
|
||||
}
|
||||
}
|
||||
|
||||
func TestRecordPlayEnded_SubThreshold_NoEnqueue(t *testing.T) {
|
||||
f := newFixture(t, 300_000)
|
||||
ctx := context.Background()
|
||||
|
||||
tk := "tk"
|
||||
_ = f.q.SetListenBrainzToken(ctx, dbq.SetListenBrainzTokenParams{ID: f.user, ListenbrainzToken: &tk})
|
||||
_ = f.q.SetListenBrainzEnabled(ctx, dbq.SetListenBrainzEnabledParams{ID: f.user, ListenbrainzEnabled: true})
|
||||
|
||||
res, err := f.w.RecordPlayStarted(ctx, f.user, f.track, "test", time.Now().Add(-1*time.Minute))
|
||||
if err != nil {
|
||||
t.Fatalf("start: %v", err)
|
||||
}
|
||||
// 60s played, 20% — well below threshold.
|
||||
if err := f.w.RecordPlayEnded(ctx, res.PlayEventID, 60_000, time.Now()); err != nil {
|
||||
t.Fatalf("end: %v", err)
|
||||
}
|
||||
|
||||
var n int
|
||||
_ = f.pool.QueryRow(ctx,
|
||||
`SELECT count(*) FROM scrobble_queue WHERE play_event_id = $1`, res.PlayEventID).Scan(&n)
|
||||
if n != 0 {
|
||||
t.Errorf("expected 0 queue rows for sub-threshold play, got %d", n)
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user