fix(android): extract ArtistSuccessBody to satisfy detekt LongMethod
android / Build + lint + test (push) Failing after 2m56s
android / Build + lint + test (push) Failing after 2m56s
This commit is contained in:
+19
-14
@@ -111,29 +111,34 @@ fun ArtistDetailScreen(
|
|||||||
title = "Couldn't load artist",
|
title = "Couldn't load artist",
|
||||||
body = s.message,
|
body = s.message,
|
||||||
)
|
)
|
||||||
is ArtistDetailUiState.Success -> {
|
is ArtistDetailUiState.Success ->
|
||||||
val artistLiked by viewModel.artistLiked
|
ArtistSuccessBody(s, viewModel, playerViewModel, navController)
|
||||||
.collectAsStateWithLifecycle()
|
}
|
||||||
val playerState by playerViewModel.uiState
|
}
|
||||||
.collectAsStateWithLifecycle()
|
}
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
@Composable
|
||||||
|
private fun ArtistSuccessBody(
|
||||||
|
state: ArtistDetailUiState.Success,
|
||||||
|
viewModel: ArtistDetailViewModel,
|
||||||
|
playerViewModel: com.fabledsword.minstrel.player.ui.PlayerViewModel,
|
||||||
|
navController: NavHostController,
|
||||||
|
) {
|
||||||
|
val artistLiked by viewModel.artistLiked.collectAsStateWithLifecycle()
|
||||||
|
val playerState by playerViewModel.uiState.collectAsStateWithLifecycle()
|
||||||
ArtistBody(
|
ArtistBody(
|
||||||
state = s,
|
state = state,
|
||||||
artistLiked = artistLiked,
|
artistLiked = artistLiked,
|
||||||
playingTrackId = playerState.currentTrack?.id,
|
playingTrackId = playerState.currentTrack?.id,
|
||||||
onPlay = viewModel::playArtist,
|
onPlay = viewModel::playArtist,
|
||||||
onToggleLike = viewModel::toggleLikeArtist,
|
onToggleLike = viewModel::toggleLikeArtist,
|
||||||
onAlbumClick = { id -> navController.navigate(AlbumDetail(id)) },
|
onAlbumClick = { id -> navController.navigate(AlbumDetail(id)) },
|
||||||
onTopTrackClick = viewModel::playTopTracks,
|
onTopTrackClick = viewModel::playTopTracks,
|
||||||
onSimilarArtistClick = { id ->
|
onSimilarArtistClick = { id -> navController.navigate(ArtistDetail(id)) },
|
||||||
navController.navigate(ArtistDetail(id))
|
|
||||||
},
|
|
||||||
)
|
)
|
||||||
}
|
}
|
||||||
}
|
|
||||||
}
|
|
||||||
}
|
|
||||||
}
|
|
||||||
}
|
|
||||||
|
|
||||||
private fun titleFor(state: ArtistDetailUiState): String = when (state) {
|
private fun titleFor(state: ArtistDetailUiState): String = when (state) {
|
||||||
is ArtistDetailUiState.Success -> state.detail.artist.name
|
is ArtistDetailUiState.Success -> state.detail.artist.name
|
||||||
|
|||||||
Reference in New Issue
Block a user