fix(auth): build password-reset links from an operator-set public address, never the Host header (M462 #4981)

buildResetURL used r.Host and r.TLS, so a forgot-password request with a forged Host emailed the victim a real reset token on a link to the attacker's server. Links now come only from network_settings.public_url (migration 0062), and no reset email is sent while it is empty; the response stays the same opaque 200 and the log says why. The address is set on a new "Public address" card under Admin → Integrations, which offers the page's own origin and warns while unset. PUT /api/admin/network-settings takes either field alone, so the proxy card and this one can't overwrite each other. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-10-06 09:32:10 -04:00
parent d411693bb2
commit 46194a609d
16 changed files with 433 additions and 26 deletions
@@ -0,0 +1,107 @@
+<script lang="ts">
+  import { onMount } from 'svelte';
+  import { Save, TriangleAlert } from 'lucide-svelte';
+  import { getNetworkSettings, updatePublicUrl } from '$lib/api/admin';
+  import { errMessage } from '$lib/api/errors';
+  import { pushToast } from '$lib/stores/toast.svelte';
+
+  let saved = $state<string | null>(null);
+  let value = $state('');
+  let saving = $state(false);
+  let loadError = $state(false);
+
+  const dirty = $derived(saved !== null && value.trim() !== saved);
+  // The address this page was loaded from is almost always the right answer,
+  // so offer it rather than making the operator type it.
+  const here = typeof window !== 'undefined' ? window.location.origin : '';
+
+  async function load() {
+    try {
+      const s = await getNetworkSettings();
+      saved = s.public_url;
+      value = s.public_url;
+      loadError = false;
+    } catch {
+      loadError = true;
+    }
+  }
+
+  onMount(load);
+
+  async function save() {
+    saving = true;
+    try {
+      const s = await updatePublicUrl(value.trim());
+      saved = s.public_url;
+      value = s.public_url;
+      pushToast(saved ? 'Public address saved.' : 'Public address cleared.');
+    } catch (e) {
+      pushToast(errMessage(e, "Couldn't save the public address."), 'error');
+    } finally {
+      saving = false;
+    }
+  }
+</script>
+
+<section class="space-y-4 rounded-xl border border-border bg-surface p-5">
+  <div>
+    <h3 class="font-display text-lg font-medium text-text-primary">Public address</h3>
+    <p class="mt-1 text-sm text-text-secondary">
+      The address people use to reach Minstrel. Password-reset emails link here.
+    </p>
+  </div>
+
+  {#if loadError}
+    <p class="text-sm text-action-destructive">
+      Couldn't load network settings.
+      <button type="button" class="underline hover:no-underline" onclick={load}>Try again</button>
+    </p>
+  {:else if saved === null}
+    <p class="text-sm text-text-secondary">Loading…</p>
+  {:else}
+    <div class="flex flex-wrap items-end gap-3">
+      <label class="flex min-w-0 flex-1 flex-col gap-1">
+        <span class="text-sm text-text-secondary">Address</span>
+        <input
+          type="url"
+          inputmode="url"
+          placeholder="https://music.example.com"
+          bind:value
+          class="w-full rounded border border-border bg-background px-2 py-1 font-mono
+                 focus-visible:outline focus-visible:outline-2 focus-visible:outline-accent"
+        />
+      </label>
+      {#if here && value.trim() !== here}
+        <button
+          type="button"
+          class="rounded-md border border-border px-3 py-1.5 text-sm hover:bg-surface-hover
+                 focus-visible:ring-2 focus-visible:ring-accent"
+          onclick={() => (value = here)}
+        >
+          Use {here}
+        </button>
+      {/if}
+      <button
+        type="button"
+        class="inline-flex items-center gap-1.5 rounded-md border border-border px-3 py-1.5
+               text-sm hover:bg-surface-hover focus-visible:ring-2 focus-visible:ring-accent
+               disabled:opacity-50"
+        disabled={saving || !dirty}
+        onclick={save}
+      >
+        <Save size={14} aria-hidden="true" />
+        {saving ? 'Saving…' : 'Save'}
+      </button>
+    </div>
+
+    {#if !saved}
+      <p class="flex items-start gap-2 text-sm text-text-secondary" role="status">
+        <TriangleAlert size={14} class="mt-0.5 flex-shrink-0 text-action-destructive" aria-hidden="true" />
+        <span>
+          Not set, so password-reset emails are not being sent. Minstrel won't build the link from
+          whatever address a request claims, because anyone can claim any address.
+        </span>
+      </p>
+    {/if}
+  {/if}
+</section>