From 327ecb6757364476e0b9ac34d5d52e785ac34487 Mon Sep 17 00:00:00 2001 From: Bryan Van Deusen Date: Sat, 23 May 2026 12:16:23 -0400 Subject: [PATCH] style(android): rename package audio_cache -> audiocache MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit detekt's PackageNaming rule rejects underscores in package names (Kotlin/Java convention is lowercase, no separator). Renamed com.fabledsword.minstrel.cache.audio_cache -> .audiocache. Pattern for future multi-word subpackages: smush rather than _ separator (e.g. mutationqueue, synccontroller, when those land). The on-disk audio_cache/ dir path inside the app cache (PlayerFactory.kt:41) is unaffected — that's a filename string, not a package. Co-Authored-By: Claude Opus 4.7 (1M context) --- .../minstrel/cache/{audio_cache => audiocache}/CacheConfig.kt | 2 +- .../main/java/com/fabledsword/minstrel/player/PlayerFactory.kt | 2 +- .../main/java/com/fabledsword/minstrel/player/PlayerModule.kt | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) rename android/app/src/main/java/com/fabledsword/minstrel/cache/{audio_cache => audiocache}/CacheConfig.kt (94%) diff --git a/android/app/src/main/java/com/fabledsword/minstrel/cache/audio_cache/CacheConfig.kt b/android/app/src/main/java/com/fabledsword/minstrel/cache/audiocache/CacheConfig.kt similarity index 94% rename from android/app/src/main/java/com/fabledsword/minstrel/cache/audio_cache/CacheConfig.kt rename to android/app/src/main/java/com/fabledsword/minstrel/cache/audiocache/CacheConfig.kt index 297bdbb8..dc0453c2 100644 --- a/android/app/src/main/java/com/fabledsword/minstrel/cache/audio_cache/CacheConfig.kt +++ b/android/app/src/main/java/com/fabledsword/minstrel/cache/audiocache/CacheConfig.kt @@ -1,4 +1,4 @@ -package com.fabledsword.minstrel.cache.audio_cache +package com.fabledsword.minstrel.cache.audiocache /** * Defaults for the 2-bucket audio cache. Matches the Flutter client. diff --git a/android/app/src/main/java/com/fabledsword/minstrel/player/PlayerFactory.kt b/android/app/src/main/java/com/fabledsword/minstrel/player/PlayerFactory.kt index c95c5873..8bfe3ccb 100644 --- a/android/app/src/main/java/com/fabledsword/minstrel/player/PlayerFactory.kt +++ b/android/app/src/main/java/com/fabledsword/minstrel/player/PlayerFactory.kt @@ -11,7 +11,7 @@ import androidx.media3.datasource.cache.SimpleCache import androidx.media3.datasource.okhttp.OkHttpDataSource import androidx.media3.exoplayer.ExoPlayer import androidx.media3.exoplayer.source.DefaultMediaSourceFactory -import com.fabledsword.minstrel.cache.audio_cache.CacheConfig +import com.fabledsword.minstrel.cache.audiocache.CacheConfig import dagger.hilt.android.qualifiers.ApplicationContext import okhttp3.OkHttpClient import java.io.File diff --git a/android/app/src/main/java/com/fabledsword/minstrel/player/PlayerModule.kt b/android/app/src/main/java/com/fabledsword/minstrel/player/PlayerModule.kt index 9ebebeb9..cea2719c 100644 --- a/android/app/src/main/java/com/fabledsword/minstrel/player/PlayerModule.kt +++ b/android/app/src/main/java/com/fabledsword/minstrel/player/PlayerModule.kt @@ -1,6 +1,6 @@ package com.fabledsword.minstrel.player -import com.fabledsword.minstrel.cache.audio_cache.CacheConfig +import com.fabledsword.minstrel.cache.audiocache.CacheConfig import dagger.Module import dagger.Provides import dagger.hilt.InstallIn