feat(web): suggestion feed on /discover (search-empty default)

This commit is contained in:
2026-05-01 06:51:41 -04:00
parent 7f18a04161
commit 2f3326aee6
4 changed files with 272 additions and 56 deletions
+37 -6
View File
@@ -10,6 +10,10 @@ vi.mock('$lib/api/lidarr', () => ({
createLidarrSearchQuery: vi.fn()
}));
vi.mock('$lib/api/suggestions', () => ({
createSuggestionsQuery: vi.fn()
}));
vi.mock('$lib/api/requests', () => ({
createRequest: vi.fn().mockResolvedValue({ id: 'r1' })
}));
@@ -25,9 +29,11 @@ vi.mock('@tanstack/svelte-query', async (orig) => {
import DiscoverPage from './+page.svelte';
import { createLidarrSearchQuery } from '$lib/api/lidarr';
import { createSuggestionsQuery } from '$lib/api/suggestions';
import { createRequest } from '$lib/api/requests';
const mockedCreateQuery = createLidarrSearchQuery as ReturnType<typeof vi.fn>;
const mockedCreateSuggestionsQuery = createSuggestionsQuery as ReturnType<typeof vi.fn>;
const mockedCreateRequest = createRequest as ReturnType<typeof vi.fn>;
function result(over: Partial<LidarrSearchResult> = {}): LidarrSearchResult {
@@ -47,6 +53,9 @@ function result(over: Partial<LidarrSearchResult> = {}): LidarrSearchResult {
beforeEach(() => {
// Default: empty results, non-pending. Tests override per-case.
mockedCreateQuery.mockReturnValue(mockQuery<LidarrSearchResult[]>({ data: [] }));
// Default: empty suggestion feed so its empty-state copy renders without
// interfering with search-mode tests.
mockedCreateSuggestionsQuery.mockReturnValue(mockQuery({ data: [] }));
});
afterEach(() => {
@@ -54,11 +63,31 @@ afterEach(() => {
});
describe('Discover page', () => {
test('initial state (no query) shows the search prompt copy', () => {
test('initial state (no query) shows the suggestion feed', () => {
render(DiscoverPage);
expect(screen.getByText(/suggested for you/i)).toBeInTheDocument();
});
test('empty input shows the suggestion feed', () => {
render(DiscoverPage);
expect(screen.getByText(/suggested for you/i)).toBeInTheDocument();
// Kind tabs should NOT be visible when input is empty.
expect(
screen.getByText(/search lidarr for music to add/i)
).toBeInTheDocument();
screen.queryByRole('button', { name: 'Artists' })
).not.toBeInTheDocument();
});
test('typing replaces feed with search', async () => {
vi.useFakeTimers();
render(DiscoverPage);
const input = screen.getByLabelText(/search lidarr/i);
await fireEvent.input(input, { target: { value: 'miles' } });
await vi.advanceTimersByTimeAsync(250);
expect(screen.queryByText(/suggested for you/i)).not.toBeInTheDocument();
expect(screen.getByText(/add music to the library/i)).toBeInTheDocument();
// Kind tabs visible when searching.
expect(screen.getByRole('button', { name: 'Artists' })).toBeInTheDocument();
vi.useRealTimers();
});
test('debounced input fires query factory with typed value after 250ms', async () => {
@@ -165,11 +194,13 @@ describe('Discover page', () => {
});
mockedCreateQuery.mockReturnValue(mockQuery<LidarrSearchResult[]>({ data: [r] }));
render(DiscoverPage);
// Switch to track kind first.
await fireEvent.click(screen.getByRole('button', { name: 'Tracks' }));
// Type first so the kind tabs become visible (empty-input mode shows the
// suggestion feed and hides tabs).
const input = screen.getByLabelText(/search lidarr/i);
await fireEvent.input(input, { target: { value: 'roy' } });
await vi.advanceTimersByTimeAsync(250);
// Switch to track kind.
await fireEvent.click(screen.getByRole('button', { name: 'Tracks' }));
vi.useRealTimers();
const requestBtn = await screen.findByRole('button', {
@@ -204,10 +235,10 @@ describe('Discover page', () => {
});
mockedCreateQuery.mockReturnValue(mockQuery<LidarrSearchResult[]>({ data: [r] }));
render(DiscoverPage);
await fireEvent.click(screen.getByRole('button', { name: 'Tracks' }));
const input = screen.getByLabelText(/search lidarr/i);
await fireEvent.input(input, { target: { value: 'roy' } });
await vi.advanceTimersByTimeAsync(250);
await fireEvent.click(screen.getByRole('button', { name: 'Tracks' }));
vi.useRealTimers();
const requestBtn = await screen.findByRole('button', {