From 2e92ba498c9813dec08677aca02f697673a73603 Mon Sep 17 00:00:00 2001 From: Bryan Van Deusen Date: Mon, 13 Jul 2026 20:45:05 -0400 Subject: [PATCH] =?UTF-8?q?fix(home):=20buildSongsLikeRow=20ReturnCount=20?= =?UTF-8?q?=E2=89=A4=202=20(detekt)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Collapse the three early returns into a single `when` expression — detekt's ReturnCount capped at 2. No behavior change. Co-Authored-By: Claude Opus 4.8 (1M context) --- .../fabledsword/minstrel/home/ui/HomeScreen.kt | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/android/app/src/main/java/com/fabledsword/minstrel/home/ui/HomeScreen.kt b/android/app/src/main/java/com/fabledsword/minstrel/home/ui/HomeScreen.kt index 573fcfa8..defdb766 100644 --- a/android/app/src/main/java/com/fabledsword/minstrel/home/ui/HomeScreen.kt +++ b/android/app/src/main/java/com/fabledsword/minstrel/home/ui/HomeScreen.kt @@ -1094,13 +1094,15 @@ internal fun buildSongsLikeRow( offline: Boolean, ): List { val mixes = owned.filter { it.systemVariant == "songs_like_artist" } - if (offline) { - val (available, greyed) = mixes.partition { !it.unavailableOffline } - return (available + greyed).map { PlaylistRowItem.Real(it) } - } - if (mixes.isNotEmpty()) return mixes.map { PlaylistRowItem.Real(it) } - return List(SONGS_LIKE_PLACEHOLDER_SLOTS) { - PlaylistRowItem.Placeholder("Songs like…", variantFor("songs-like", status)) + return when { + offline -> { + val (available, greyed) = mixes.partition { !it.unavailableOffline } + (available + greyed).map { PlaylistRowItem.Real(it) } + } + mixes.isNotEmpty() -> mixes.map { PlaylistRowItem.Real(it) } + else -> List(SONGS_LIKE_PLACEHOLDER_SLOTS) { + PlaylistRowItem.Placeholder("Songs like…", variantFor("songs-like", status)) + } } }