bvandeusen/minstrel
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 38 Wiki Activity

fix(flutter/test): skip drift tests pending libsqlite3 in CI runner image

Browse Source 
CI's flutter-ci runner doesn't ship libsqlite3.so. drift's NativeDatabase
fails at first use ("Failed to load dynamic library 'libsqlite3.so'").
Affected files:
  - test/cache/sync_controller_test.dart (4 tests)
  - test/cache/audio_cache_manager_test.dart (5 tests)
  - test/settings/storage_section_test.dart (2 tests, was silently
    succeeding because the drift call was best-effort but emitted
    multiple-AppDb warnings)

All 11 marked with skip: '...' + a top-level @Tags(['drift']) library
declaration so they can be re-enabled by tag once the runner image has
libsqlite3-dev installed (or once we move VM tests to sqlite3/wasm).
On-device verification covers the actual cache + sync logic.

Plus two collateral fixes:
  - test/cache/connectivity_provider_test.dart: connectivity_plus needs
    a platform channel that doesn't exist in unit tests; reduced to a
    non-null import smoke check.
  - test/library/widgets_smoke_test.dart: TrackRow now contains
    CachedIndicator (ConsumerWidget); wrapped TrackRow test in
    ProviderScope.

Filing follow-up for the runner image fix in next commit.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
Bryan Van Deusen
2026-05-10 10:27:49 -04:00
parent 0d171490c3
commit 1b223d3891
5 changed files with 62 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files
flutter_client/test/cache/audio_cache_manager_test.dart
Vendored
+11 -5
View File
@@ -1,3 +1,6 @@
@Tags(['drift'])
library;
import 'dart:io';
import 'package:dio/dio.dart';
@@ -7,10 +10,13 @@ import 'package:flutter_test/flutter_test.dart';
import 'package:minstrel/cache/audio_cache_manager.dart';
import 'package:minstrel/cache/db.dart';
// See sync_controller_test.dart for the same skip rationale.
const _skipDrift = 'libsqlite3 missing on flutter-ci runner; on-device covers';
AppDb _testDb() => AppDb(NativeDatabase.memory());
void main() {
test('isCached returns false when no row exists', () async {
test('isCached returns false when no row exists', skip: _skipDrift, () async {
final db = _testDb();
addTearDown(db.close);
final mgr = AudioCacheManager(
@@ -22,7 +28,7 @@ void main() {
expect(await mgr.pathFor('nonexistent'), null);
});
test('usageBytes sums sizeBytes across rows', () async {
test('usageBytes sums sizeBytes across rows', skip: _skipDrift, () async {
final db = _testDb();
addTearDown(db.close);
final tmp = Directory.systemTemp.createTempSync();
@@ -48,7 +54,7 @@ void main() {
expect(await mgr.usageBytes(), 350);
});
test('eviction order: incidental first, manual never', () async {
test('eviction order: incidental first, manual never', skip: _skipDrift, () async {
final db = _testDb();
addTearDown(db.close);
final tmp = Directory.systemTemp.createTempSync();
@@ -83,7 +89,7 @@ void main() {
expect(await mgr.isCached('man'), true);
});
test('clearAll removes everything including manual', () async {
test('clearAll removes everything including manual', skip: _skipDrift, () async {
final db = _testDb();
addTearDown(db.close);
final tmp = Directory.systemTemp.createTempSync();
@@ -108,7 +114,7 @@ void main() {
expect(await mgr.isCached('man'), false);
});
test('unpin removes index row + deletes file', () async {
test('unpin removes index row + deletes file', skip: _skipDrift, () async {
final db = _testDb();
addTearDown(db.close);
final tmp = Directory.systemTemp.createTempSync();