bvandeusen/minstrel
1
0
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases 39 Wiki Activity

feat(server/m7-352): 403 system_playlist_readonly on playlist edit endpoints

Browse Source 
Push kind='system' guard into each of the five Service edit methods
(Update, Delete, AppendTracks, RemoveTrack, Reorder) immediately after
the ownership check; map the typed error to 403 in writePlaylistErr;
add table-driven test covering all five verbs against a seeded system
playlist.
This commit is contained in:
Bryan Van Deusen
2026-05-04 09:29:37 -04:00
parent a90ff11f0f
commit 0a1e76564d
3 changed files with 63 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
internal/api/playlists.go
+2
View File
@@ -420,6 +420,8 @@ func (h *handlers) writePlaylistErr(w http.ResponseWriter, err error, op string)
writeErr(w, http.StatusNotFound, "not_found", "playlist not found")
case errors.Is(err, playlists.ErrForbidden):
writeErr(w, http.StatusForbidden, "not_authorized", "you don't own this playlist")
case errors.Is(err, playlists.ErrSystemPlaylistReadonly):
writeErr(w, http.StatusForbidden, "system_playlist_readonly", "system-generated playlists cannot be edited")
case errors.Is(err, playlists.ErrInvalidInput):
writeErr(w, http.StatusBadRequest, "bad_request", err.Error())
case errors.Is(err, playlists.ErrTrackNotFound):