bvandeusen/minstrel
1
0
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases 39 Wiki Activity

test(web/admin): align Lidarr bootstrap tests with file conventions

Browse Source 
Refactors the new describe block to use the existing setupFresh()
helper pattern (mirrors setup() but with empty profile/folder lists
so we can verify the test response is what populates the dropdowns),
the lidarrSection() scoping helper (the cover-providers and SMTP
panels also have "Save changes" buttons that match unscoped queries),
and the correct mockQuery({ data: ... }) shape used elsewhere in the
file. Drops the duplicate afterEach (the file already has a global
one at line 131).

No behavior change in the tests themselves — same three cases.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This commit is contained in:
Bryan Van Deusen
2026-05-08 23:11:35 -04:00
parent c47ec6093f
commit 088e8f4bf8
1 changed files with 41 additions and 44 deletions
Download Patch File Download Diff File Expand all files Collapse all files
web/src/routes/admin/integrations/integrations.test.ts
+41 -44
View File
@@ -522,29 +522,38 @@ describe('/admin/integrations — SMTP card', () => {
}); });
describe('Lidarr first-time setup (Test-then-Save)', () => { describe('Lidarr first-time setup (Test-then-Save)', () => {
afterEach(() => { // Fresh-install variant of setup() — the three list queries return
vi.clearAllMocks(); // empty arrays so we can verify the dropdowns get populated from the
}); // test response, not from the (empty) cached query data.
function setupFresh() {
(createLidarrConfigQuery as ReturnType<typeof vi.fn>).mockReturnValue(
mockQuery({ data: cfgUnset })
);
(createQualityProfilesQuery as ReturnType<typeof vi.fn>).mockReturnValue(mockQuery({ data: [] }));
(createMetadataProfilesQuery as ReturnType<typeof vi.fn>).mockReturnValue(mockQuery({ data: [] }));
(createRootFoldersQuery as ReturnType<typeof vi.fn>).mockReturnValue(mockQuery({ data: [] }));
(createCoverProvidersQuery as ReturnType<typeof vi.fn>).mockReturnValue(
mockQuery({ data: defaultCoverProviders })
);
(createSMTPConfigQuery as ReturnType<typeof vi.fn>).mockReturnValue(
mockQuery({ data: smtpUnset })
);
return render(IntegrationsPage);
}
test('Save calls test first, fills defaults from response, then put-config', async () => { test('Save calls test first, fills defaults from response, then put-config', async () => {
vi.mocked(createLidarrConfigQuery).mockReturnValue(mockQuery(cfgUnset)); setupFresh();
vi.mocked(createQualityProfilesQuery).mockReturnValue(mockQuery([])); (testLidarrConnection as ReturnType<typeof vi.fn>).mockResolvedValueOnce(testResponseOk);
vi.mocked(createMetadataProfilesQuery).mockReturnValue(mockQuery([])); (putLidarrConfig as ReturnType<typeof vi.fn>).mockResolvedValueOnce(cfgConnected);
vi.mocked(createRootFoldersQuery).mockReturnValue(mockQuery([]));
vi.mocked(createCoverProvidersQuery).mockReturnValue(mockQuery(defaultCoverProviders));
vi.mocked(createSMTPConfigQuery).mockReturnValue(mockQuery(smtpUnset));
vi.mocked(testLidarrConnection).mockResolvedValue(testResponseOk);
vi.mocked(putLidarrConfig).mockResolvedValue(cfgConnected);
render(IntegrationsPage); const section = lidarrSection();
await fireEvent.input(within(section).getByLabelText(/Base URL/i), {
await fireEvent.input(screen.getByLabelText(/Base URL/i), {
target: { value: 'http://lidarr.local' } target: { value: 'http://lidarr.local' }
}); });
await fireEvent.input(screen.getByLabelText(/API key/i), { await fireEvent.input(within(section).getByLabelText(/API key/i), {
target: { value: 'secret-key' } target: { value: 'secret-key' }
}); });
await fireEvent.click(screen.getByRole('button', { name: /Save changes/i })); await fireEvent.click(within(section).getByRole('button', { name: /Save changes/i }));
await waitFor(() => { await waitFor(() => {
expect(testLidarrConnection).toHaveBeenCalledWith({ expect(testLidarrConnection).toHaveBeenCalledWith({
@@ -565,64 +574,52 @@ describe('Lidarr first-time setup (Test-then-Save)', () => {
}); });
test('Save aborts when test fails and surfaces the error', async () => { test('Save aborts when test fails and surfaces the error', async () => {
vi.mocked(createLidarrConfigQuery).mockReturnValue(mockQuery(cfgUnset)); setupFresh();
vi.mocked(createQualityProfilesQuery).mockReturnValue(mockQuery([])); (testLidarrConnection as ReturnType<typeof vi.fn>).mockResolvedValueOnce({
vi.mocked(createMetadataProfilesQuery).mockReturnValue(mockQuery([]));
vi.mocked(createRootFoldersQuery).mockReturnValue(mockQuery([]));
vi.mocked(createCoverProvidersQuery).mockReturnValue(mockQuery(defaultCoverProviders));
vi.mocked(createSMTPConfigQuery).mockReturnValue(mockQuery(smtpUnset));
vi.mocked(testLidarrConnection).mockResolvedValue({
ok: false, ok: false,
error: 'lidarr_unreachable' error: 'lidarr_unreachable'
}); });
render(IntegrationsPage); const section = lidarrSection();
await fireEvent.input(within(section).getByLabelText(/Base URL/i), {
await fireEvent.input(screen.getByLabelText(/Base URL/i), {
target: { value: 'http://wrong.local' } target: { value: 'http://wrong.local' }
}); });
await fireEvent.input(screen.getByLabelText(/API key/i), { await fireEvent.input(within(section).getByLabelText(/API key/i), {
target: { value: 'k' } target: { value: 'k' }
}); });
await fireEvent.click(screen.getByRole('button', { name: /Save changes/i })); await fireEvent.click(within(section).getByRole('button', { name: /Save changes/i }));
await waitFor(() => { await waitFor(() => {
expect(testLidarrConnection).toHaveBeenCalled(); expect(testLidarrConnection).toHaveBeenCalled();
}); });
expect(putLidarrConfig).not.toHaveBeenCalled(); expect(putLidarrConfig).not.toHaveBeenCalled();
await waitFor(() => { await waitFor(() => {
expect(screen.getByText(/Save failed — lidarr_unreachable/i)).toBeInTheDocument(); expect(within(lidarrSection()).getByText(/save failed — lidarr_unreachable/i)).toBeInTheDocument();
}); });
}); });
test('Save preserves operator-picked defaults over auto-defaults', async () => { test('Save preserves operator-picked defaults over auto-defaults', async () => {
vi.mocked(createLidarrConfigQuery).mockReturnValue(mockQuery(cfgUnset)); setupFresh();
vi.mocked(createQualityProfilesQuery).mockReturnValue(mockQuery([])); (testLidarrConnection as ReturnType<typeof vi.fn>).mockResolvedValue(testResponseOk);
vi.mocked(createMetadataProfilesQuery).mockReturnValue(mockQuery([])); (putLidarrConfig as ReturnType<typeof vi.fn>).mockResolvedValueOnce(cfgConnected);
vi.mocked(createRootFoldersQuery).mockReturnValue(mockQuery([]));
vi.mocked(createCoverProvidersQuery).mockReturnValue(mockQuery(defaultCoverProviders));
vi.mocked(createSMTPConfigQuery).mockReturnValue(mockQuery(smtpUnset));
vi.mocked(testLidarrConnection).mockResolvedValue(testResponseOk);
vi.mocked(putLidarrConfig).mockResolvedValue(cfgConnected);
render(IntegrationsPage); const section = lidarrSection();
await fireEvent.input(within(section).getByLabelText(/Base URL/i), {
await fireEvent.input(screen.getByLabelText(/Base URL/i), {
target: { value: 'http://lidarr.local' } target: { value: 'http://lidarr.local' }
}); });
await fireEvent.input(screen.getByLabelText(/API key/i), { await fireEvent.input(within(section).getByLabelText(/API key/i), {
target: { value: 'secret-key' } target: { value: 'secret-key' }
}); });
// Click Test first to populate the dropdowns, then change the // Click Test first to populate the dropdowns, then change the
// quality profile selection before clicking Save. // quality profile selection before clicking Save.
await fireEvent.click(screen.getByRole('button', { name: /Test connection/i })); await fireEvent.click(within(section).getByRole('button', { name: /Test connection/i }));
await waitFor(() => { await waitFor(() => {
expect(testLidarrConnection).toHaveBeenCalledTimes(1); expect(testLidarrConnection).toHaveBeenCalledTimes(1);
}); });
const qualitySelect = screen.getByLabelText(/Default quality profile/i); const qualitySelect = within(section).getByLabelText(/Default quality profile/i);
await fireEvent.change(qualitySelect, { target: { value: '2' } }); await fireEvent.change(qualitySelect, { target: { value: '2' } });
await fireEvent.click(screen.getByRole('button', { name: /Save changes/i })); await fireEvent.click(within(section).getByRole('button', { name: /Save changes/i }));
await waitFor(() => { await waitFor(() => {
expect(putLidarrConfig).toHaveBeenCalledWith( expect(putLidarrConfig).toHaveBeenCalledWith(